From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0096C4332F for ; Wed, 23 Nov 2022 17:27:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1261F6B0071; Wed, 23 Nov 2022 12:27:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D6036B0073; Wed, 23 Nov 2022 12:27:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F06836B0074; Wed, 23 Nov 2022 12:27:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E102F6B0071 for ; Wed, 23 Nov 2022 12:27:22 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B1EE4A08C3 for ; Wed, 23 Nov 2022 17:27:22 +0000 (UTC) X-FDA: 80165388324.27.7C0E140 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf16.hostedemail.com (Postfix) with ESMTP id 1CE1C180013 for ; Wed, 23 Nov 2022 17:27:21 +0000 (UTC) Received: by mail-qt1-f178.google.com with SMTP id s4so11666195qtx.6 for ; Wed, 23 Nov 2022 09:27:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X4ror3WW8EMAvSzzIPDDvs1aj+7+7UMUKzLin0vg3Y4=; b=et+IYbyjRj/0/GetQ/OQK6v6unqnZJqfadSoTXdZs21oe7kqXw9yKumIOsLRcvRLAb 2/qw/Rsk7xO45+SrRMfYSGUiAqqtTnXRxtrFLEWwgoVRvMVwXOf9qtiG750xi/ea/OZf VzuwqsPshGK2ywA0l0zPNSTfxrMw1DpOs27nfyk+XXx/nqLV2RiQM4IVoTqKJjnJoron n0Ls1hCzNECE3owA0A6xRaqpDJzecJgrDcEHkERtwfk0IpehdenGT9jev9GhUhoLbGIF Xswb7Expvq/oZtmkh5WIMAcirILqMPlKPRZ+ixpIERfSmcgszoY+zY2P80xsK/2b4Dqh VXug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X4ror3WW8EMAvSzzIPDDvs1aj+7+7UMUKzLin0vg3Y4=; b=ywk0zbgradzDN5RQI4g8ZofDoA4j9ySDNM+d/LRNH7Wr9H3jssgGliiOC0TskVVOTL Sy8rThpqB7L3weyn9GMXNr4wO9xvegVDvvq8TvGW/ShkxbS2Kd81yEwZtBm9LC2emj2r roM9csT2LzkMhy2nktP1tnhLQ2logLo2BMdzW1oP/FsQeHfaFzFLWHmO4XyClW1eF/Bd ovAYdhf+eXv6aVMGFnnURhj1pMOscAfd1wMLJJuSCqPzs/0Z96Q/V+HJS4zJSIZvCUvE 4xBi1QLn4kLwUx4UpIJk97DP8/sqhAfPkT0lLBQ0Acd8tEoPOJv7TGUcabH7LNw1Ul4v 2pjw== X-Gm-Message-State: ANoB5pkk5lqQp47PkD5fQyHRlT+o7WymdF7z2jgGpHtVsNXLROK6Hau1 +1ePhFMI1AeE3gLXM2u1mV7rApj78FrdfQ== X-Google-Smtp-Source: AA0mqf7g8nd6AoDgQOa5G02kZfOqxagyJQeBvC7rocH/QPZ/xTbkw/zaXC17S4uqYkFQsKK3WS83Rw== X-Received: by 2002:ac8:1347:0:b0:39c:b637:a890 with SMTP id f7-20020ac81347000000b0039cb637a890mr26964943qtj.613.1669224441270; Wed, 23 Nov 2022 09:27:21 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:bc4]) by smtp.gmail.com with ESMTPSA id l16-20020a05620a28d000b006f3e6933bacsm12849206qkp.113.2022.11.23.09.27.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 09:27:20 -0800 (PST) Date: Wed, 23 Nov 2022 12:27:47 -0500 From: Johannes Weiner To: Nhat Pham Cc: senozhatsky@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, akpm@linux-foundation.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v6 6/6] zsmalloc: Implement writeback mechanism for zsmalloc Message-ID: References: <20221123163044.2029016-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123163044.2029016-1-nphamcs@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669224442; a=rsa-sha256; cv=none; b=fY8LmcMFftw9XC/QkLOkeK03C6ZDe3z8fwngFyzrY+trhRGIA4bIfxDhTRP9N7RrPL3WKM 5nAviDDMFH8AVS2d8BmaluUegiBfUlm5LT7xXioCiMMgLJmSb4teWl7qjLKiWzQeSja/7z vAyVUS2OG8yoID0yf1lNICtN30q6lg0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=et+IYbyj; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf16.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669224442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X4ror3WW8EMAvSzzIPDDvs1aj+7+7UMUKzLin0vg3Y4=; b=udegBQWdOerwXqf9VT2kBAzqyu4VelLqxb/MVi1P/M+Md3ZRRKTQ7QplM1YRBGKHS+XEJM +QQgQUExZIeg0ghHeMLWScmU8VDvx1VsXA96tVKkNMyhnjbhXVnSUvvif0sFVEoCVmD8eS mVqjiO7kalCr9JOSsYOV8qickL+HF9M= Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=et+IYbyj; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf16.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org X-Stat-Signature: 8jpjh4x13q3md3ndjpp5g7tj3mhtwuz1 X-Rspamd-Queue-Id: 1CE1C180013 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1669224441-837481 X-Bogosity: Ham, tests=bogofilter, spamicity=0.055582, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 23, 2022 at 08:30:44AM -0800, Nhat Pham wrote: > I'll put it right after releasing the pool's lock in the retry loop: > > /* Lock out object allocations and object compaction */ > remove_zspage(class, zspage, fullness); > > spin_unlock(&pool->lock); > cond_resched(); > > /* Lock backing pages into place */ > lock_zspage(zspage); > > This will also appear in v7. In the meantime, please feel free to discuss all > the patches - I'll try to batch the changes to minimize the churning. Oh, our emails collided. This is easier than my version :)