From: Johannes Weiner <hannes@cmpxchg.org>
To: Yu Zhao <yuzhao@google.com>
Cc: Ivan Babrou <ivan@cloudflare.com>, Linux MM <linux-mm@kvack.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <songmuchun@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
cgroups@vger.kernel.org, kernel-team <kernel-team@cloudflare.com>
Subject: Re: Low TCP throughput due to vmpressure with swap enabled
Date: Wed, 23 Nov 2022 16:22:31 -0500 [thread overview]
Message-ID: <Y36PF972kOK3ADvx@cmpxchg.org> (raw)
In-Reply-To: <Y31s/K8T85jh05wH@google.com>
On Tue, Nov 22, 2022 at 05:44:44PM -0700, Yu Zhao wrote:
> Hi Johannes,
>
> Do you think it makes sense to have the below for both the baseline and
> MGLRU or it's some behavior change that the baseline doesn't want to
> risk?
It looks good to me. Besides the new FMODE_NOREUSE, it's also a nice
cleanup on the rmap side!
It would just be good to keep the comment from folio_referenced_one() and
move it to the vma_has_locality() check in invalid_folio_referenced_vma().
Otherwise,
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2022-11-23 21:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 0:53 Low TCP throughput due to vmpressure with swap enabled Ivan Babrou
2022-11-22 0:53 ` Ivan Babrou
2022-11-22 18:01 ` Eric Dumazet
[not found] ` <CANn89iLzARPp6jW1xS0rf+-wS_RnwK-Kfgs9uQFYan2AHPRQFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-11-22 18:11 ` Ivan Babrou
2022-11-22 18:11 ` Ivan Babrou
[not found] ` <CABWYdi2TWJej806yif9hi7cxD9P9-EpMB9EU_72wWw9fFqtt4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-11-22 18:23 ` Eric Dumazet
2022-11-22 18:23 ` Eric Dumazet
[not found] ` <CABWYdi0G7cyNFbndM-ELTDAR3x4Ngm0AehEp5aP0tfNkXUE+Uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-11-22 18:59 ` Yu Zhao
2022-11-22 18:59 ` Yu Zhao
[not found] ` <CAOUHufbQ_JjW=zXEi10+=LQOREOPHrK66Rqayr=sFUH_tQbW1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-11-22 19:05 ` Ivan Babrou
2022-11-22 19:05 ` Ivan Babrou
[not found] ` <CABWYdi3aOtJuMe4Z=FFzBb3iR6Cc9k8G2swSuZ_GDnaESuE_EQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-11-22 19:08 ` Yu Zhao
2022-11-22 19:08 ` Yu Zhao
2022-11-22 19:46 ` Yu Zhao
2022-11-22 19:46 ` Yu Zhao
2022-11-22 20:05 ` Yu Zhao
[not found] ` <CAOUHufYSeTeO5ZMpnCR781esHV4QV5Th+pd=52UaM9cXNNKF9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-11-23 0:44 ` Yu Zhao
2022-11-23 0:44 ` Yu Zhao
2022-11-23 21:22 ` Johannes Weiner [this message]
[not found] ` <Y36PF972kOK3ADvx-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-11-24 1:18 ` Yu Zhao
2022-11-24 1:18 ` Yu Zhao
2022-11-24 1:29 ` Yu Zhao
2022-11-22 20:05 ` Johannes Weiner
2022-11-22 20:05 ` Johannes Weiner
2022-11-22 22:11 ` Ivan Babrou
2022-11-23 1:28 ` Ivan Babrou
[not found] ` <CABWYdi0qhWs56WK=k+KoQBAMh+Tb6Rr0nY4kJN+E5YqfGhKTmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-11-28 18:07 ` Johannes Weiner
2022-11-28 18:07 ` Johannes Weiner
[not found] ` <Y4T43Tc54vlKjTN0-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-12-05 19:28 ` Shakeel Butt
2022-12-05 19:28 ` Shakeel Butt
2022-12-05 23:57 ` Ivan Babrou
2022-12-05 23:57 ` Ivan Babrou
[not found] ` <CABWYdi0z6-46PrNWumSXWki6Xf4G_EP1Nvc-2t00nEi0PiOU3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-12-06 0:50 ` Ivan Babrou
2022-12-06 0:50 ` Ivan Babrou
2022-12-06 19:00 ` Johannes Weiner
[not found] ` <Y4+RPry2tfbWFdSA-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-12-06 19:13 ` Eric Dumazet
2022-12-06 19:13 ` Eric Dumazet
[not found] ` <CANn89iJfx4QdVBqJ23oFJoz5DJKou=ZwVBNNXFNDJRNAqNvzwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-12-06 20:51 ` Johannes Weiner
2022-12-06 20:51 ` Johannes Weiner
[not found] ` <Y4+rNYF9WZyJyBQp-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-12-06 23:10 ` Shakeel Butt
2022-12-06 23:10 ` Shakeel Butt
2022-12-07 12:53 ` Johannes Weiner
2022-12-08 0:31 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y36PF972kOK3ADvx@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=ivan@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.