From: Sean Christopherson <seanjc@google.com>
To: Mingwei Zhang <mizhang@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Nagareddy Reddy <nspreddy@google.com>,
Jim Mattson <jmattson@google.com>,
David Matlack <dmatlack@google.com>
Subject: Re: [RFC PATCH] KVM: x86/mmu: replace BUG() with KVM_BUG() in shadow mmu
Date: Wed, 23 Nov 2022 23:18:12 +0000 [thread overview]
Message-ID: <Y36qNDBxlOslo7no@google.com> (raw)
In-Reply-To: <20221123231206.274392-1-mizhang@google.com>
On Wed, Nov 23, 2022, Mingwei Zhang wrote:
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index 4736d7849c60..075d31b0db9c 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -955,12 +955,12 @@ static void pte_list_remove(u64 *spte, struct kvm_rmap_head *rmap_head)
>
> if (!rmap_head->val) {
> pr_err("%s: %p 0->BUG\n", __func__, spte);
> - BUG();
> + KVM_BUG();
This won't compile. KVM_BUG() isn't a direct replacement for BUG(), it's more
akin to WARN().
And that's why I suggested this be RFC: @kvm needs to be plumbed down here in order
to use KVM_BUG(). I don't mind that too much, it's just a little unfortunate.
next prev parent reply other threads:[~2022-11-23 23:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 23:12 [RFC PATCH] KVM: x86/mmu: replace BUG() with KVM_BUG() in shadow mmu Mingwei Zhang
2022-11-23 23:18 ` Sean Christopherson [this message]
2022-11-23 23:48 ` Mingwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y36qNDBxlOslo7no@google.com \
--to=seanjc@google.com \
--cc=dmatlack@google.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mizhang@google.com \
--cc=nspreddy@google.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.