From: Jeff King <peff@peff.net>
To: Glen Choo via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Taylor Blau" <me@ttaylorr.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Glen Choo" <chooglen@google.com>
Subject: Re: [PATCH v3] object-file: use real paths when adding alternates
Date: Wed, 23 Nov 2022 20:08:34 -0500 [thread overview]
Message-ID: <Y37EEiJembUN9PmL@coredump.intra.peff.net> (raw)
In-Reply-To: <pull.1382.v3.git.git.1669251331340.gitgitgadget@gmail.com>
On Thu, Nov 24, 2022 at 12:55:31AM +0000, Glen Choo via GitGitGadget wrote:
> object-file: use real paths when adding alternates
>
> Thanks all for the feedback on v2. Once again, this version takes nearly
> all of Ævar's fixup patches [1] :)
This looks fine to me. I'd probably have done the strbuf_realpath()
change I suggested, but I don't mind if you want to punt on it for now.
-Peff
next prev parent reply other threads:[~2022-11-24 1:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 17:31 [PATCH] object-file: use real paths when adding alternates Glen Choo via GitGitGadget
2022-11-17 18:47 ` Jeff King
2022-11-17 19:41 ` Ævar Arnfjörð Bjarmason
2022-11-17 21:57 ` Jeff King
2022-11-17 22:03 ` Taylor Blau
2022-11-18 0:00 ` Glen Choo
2022-11-17 21:54 ` Taylor Blau
2022-11-21 23:49 ` [PATCH v2] " Glen Choo via GitGitGadget
2022-11-22 0:56 ` Ævar Arnfjörð Bjarmason
2022-11-22 19:53 ` Jeff King
2022-11-24 0:50 ` Glen Choo
2022-11-24 1:06 ` Jeff King
2022-11-24 0:20 ` Glen Choo
2022-11-22 19:40 ` Jeff King
2022-11-24 0:55 ` [PATCH v3] " Glen Choo via GitGitGadget
2022-11-24 1:08 ` Jeff King [this message]
2022-11-25 6:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y37EEiJembUN9PmL@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.