From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
tglx@linutronix.de, linux-crypto@vger.kernel.org, x86@kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH v6 2/3] random: introduce generic vDSO getrandom() implementation
Date: Thu, 24 Nov 2022 12:57:30 +0100 [thread overview]
Message-ID: <Y39cKn2FbSxe+SWj@zx2c4.com> (raw)
In-Reply-To: <875yf47wfn.fsf@oldenburg.str.redhat.com>
Hi Florian,
On Thu, Nov 24, 2022 at 06:28:44AM +0100, Florian Weimer wrote:
> > Right? And if you look at the expansion of that glibc macro, it's just:
> >
> > #define INTERNAL_SYSCALL_ERROR_P(val) \
> > ((unsigned long int) (val) > -4096UL)
> >
> > So it looks like the same exact thing?
>
> syscall already does internally (with a translation to -1, not NULL), so
> the caller shouldn't do it again. The userspace syscall function does
> *not* return an error code.
Ahh, okay. Thanks. I'll fix up the example to assume those semantics.
Jason
next prev parent reply other threads:[~2022-11-24 11:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 15:29 [PATCH v6 0/3] implement getrandom() in vDSO Jason A. Donenfeld
2022-11-21 15:29 ` [PATCH v6 1/3] random: add vgetrandom_alloc() syscall Jason A. Donenfeld
2022-11-23 10:46 ` Florian Weimer
2022-11-24 1:04 ` Jason A. Donenfeld
2022-11-24 5:25 ` Florian Weimer
2022-11-24 12:03 ` Jason A. Donenfeld
2022-11-24 12:15 ` Florian Weimer
2022-11-24 12:24 ` Jason A. Donenfeld
2022-11-24 12:48 ` Jason A. Donenfeld
2022-11-24 13:18 ` Arnd Bergmann
2022-11-24 12:49 ` Christian Brauner
2022-11-24 12:57 ` Jason A. Donenfeld
2022-11-24 16:30 ` Jason A. Donenfeld
2022-11-21 15:29 ` [PATCH v6 2/3] random: introduce generic vDSO getrandom() implementation Jason A. Donenfeld
2022-11-23 8:51 ` Rasmus Villemoes
2022-11-24 1:18 ` Jason A. Donenfeld
2022-11-25 8:02 ` Rasmus Villemoes
2022-11-23 10:48 ` Florian Weimer
2022-11-24 1:08 ` Jason A. Donenfeld
2022-11-24 5:28 ` Florian Weimer
2022-11-24 11:57 ` Jason A. Donenfeld [this message]
2022-11-21 15:29 ` [PATCH v6 3/3] x86: vdso: Wire up getrandom() vDSO implementation Jason A. Donenfeld
2022-11-22 20:14 ` [PATCH v6 0/3] implement getrandom() in vDSO Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y39cKn2FbSxe+SWj@zx2c4.com \
--to=jason@zx2c4.com \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.