From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA8216FDF for ; Sun, 13 Nov 2022 22:12:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC86EC433D6; Sun, 13 Nov 2022 22:12:15 +0000 (UTC) Date: Sun, 13 Nov 2022 22:12:12 +0000 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Marc Zyngier , Zhang Lei , James Morse , Alexandru Elisei , Andre Przywara , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/8] arm64/fpsimd: Track the saved FPSIMD state type separately to TIF_SVE Message-ID: References: <20221021230321.1159287-1-broonie@kernel.org> <20221021230321.1159287-3-broonie@kernel.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221021230321.1159287-3-broonie@kernel.org> On Sat, Oct 22, 2022 at 12:03:15AM +0100, Mark Brown wrote: > diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h > index 445aa3af3b76..3cce0a4c4e8d 100644 > --- a/arch/arm64/include/asm/processor.h > +++ b/arch/arm64/include/asm/processor.h > @@ -122,6 +122,11 @@ enum vec_type { > ARM64_VEC_MAX, > }; > > +enum fp_type { > + FP_STATE_FPSIMD, > + FP_STATE_SVE, > +}; More of a nitpick, I still find the type/state naming confusing but I don't have a better suggestion. Maybe call them FP_TYPE_* or rename the enum to fp_state_type (up to you really, feel free to leave them as they are). Either way, I think having an explicit type of what state is about is a significant improvement in clarity. Reviewed-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 746C4C433FE for ; Sun, 13 Nov 2022 22:13:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tNqJqT1QM/WCx3/4JPy5bRPv8oVHHWn1Rd74YGKx1TU=; b=JWYgp8ngMWDbBv sXsojphfKrcP1Dwn9n+SgJ+VlsZtgnLtHjJRyykifvzmM56Fw1r+IMVGJ3pfmDon2XVrjugiPSbgi CG9/4vleKn30T3w+CcBgCUeN+gtHpd2POVVC+Fe6oZF3bRHqgZGRdlWF15bjbli8ZddKaecY0ANCo 9gWpR0d/8omb9kT0JrZgjhatQdZDHU64VPdZS8PwWJy90suaklUc5AdwB5lML7QFVJQlLC71rbufz HkJox6YBGzJdq4/7+Y8NgC9q6a5DGNgdiA4WdFML1thf/jGfqkBzYR/OlXQAZuz3G9/PV/VoLhNqA 2u0AkpvCtQ2Y4Q6AY5uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouLDB-00EZA0-Ir; Sun, 13 Nov 2022 22:12:21 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouLD8-00EZ9J-KD for linux-arm-kernel@lists.infradead.org; Sun, 13 Nov 2022 22:12:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC74760BDE; Sun, 13 Nov 2022 22:12:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC86EC433D6; Sun, 13 Nov 2022 22:12:15 +0000 (UTC) Date: Sun, 13 Nov 2022 22:12:12 +0000 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Marc Zyngier , Zhang Lei , James Morse , Alexandru Elisei , Andre Przywara , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/8] arm64/fpsimd: Track the saved FPSIMD state type separately to TIF_SVE Message-ID: References: <20221021230321.1159287-1-broonie@kernel.org> <20221021230321.1159287-3-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221021230321.1159287-3-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221113_141218_724922_0AB02A00 X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 22, 2022 at 12:03:15AM +0100, Mark Brown wrote: > diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h > index 445aa3af3b76..3cce0a4c4e8d 100644 > --- a/arch/arm64/include/asm/processor.h > +++ b/arch/arm64/include/asm/processor.h > @@ -122,6 +122,11 @@ enum vec_type { > ARM64_VEC_MAX, > }; > > +enum fp_type { > + FP_STATE_FPSIMD, > + FP_STATE_SVE, > +}; More of a nitpick, I still find the type/state naming confusing but I don't have a better suggestion. Maybe call them FP_TYPE_* or rename the enum to fp_state_type (up to you really, feel free to leave them as they are). Either way, I think having an explicit type of what state is about is a significant improvement in clarity. Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel