From: Vinod Koul <vkoul@kernel.org>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
dmaengine@vger.kernel.org, Nirav N Shah <nirav.n.shah@intel.com>
Subject: Re: [PATCH] dmaengine: idxd: Fix crc_val field for completion record
Date: Mon, 14 Nov 2022 03:58:08 +0530 [thread overview]
Message-ID: <Y3FveOiymPb3fpWc@matsya> (raw)
In-Reply-To: <20221111012715.2031481-1-fenghua.yu@intel.com>
On 10-11-22, 17:27, Fenghua Yu wrote:
> The crc_val in the completion record should be 64 bits and not 32 bits.
>
> Fixes: 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record")
>
Please no empty line after the fixes tag!
Applied after removing the empty line, thanks
> Reported-by: Nirav N Shah <nirav.n.shah@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
> include/uapi/linux/idxd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h
> index 61ee43823622..09947ae61663 100644
> --- a/include/uapi/linux/idxd.h
> +++ b/include/uapi/linux/idxd.h
> @@ -329,7 +329,7 @@ struct dsa_completion_record {
> };
>
> uint32_t delta_rec_size;
> - uint32_t crc_val;
> + uint64_t crc_val;
>
> /* DIF check & strip */
> struct {
> --
> 2.32.0
--
~Vinod
prev parent reply other threads:[~2022-11-13 22:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 1:27 [PATCH] dmaengine: idxd: Fix crc_val field for completion record Fenghua Yu
2022-11-11 15:09 ` Dave Jiang
2022-11-13 22:28 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3FveOiymPb3fpWc@matsya \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nirav.n.shah@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.