From: Greg KH <gregkh@linuxfoundation.org>
To: Hunter Chasens <hunter.chasens18@ncf.edu>
Cc: outreachy@lists.linux.dev, johan@kernel.org, elder@kernel.org,
hvaibhav.linux@gmail.com, vireshk@kernel.org,
pure.logic@nexus-software.ie
Subject: Re: [PATCH v3 2/2] Staging: greybus: Removes redundant 'int'
Date: Mon, 14 Nov 2022 08:22:26 +0100 [thread overview]
Message-ID: <Y3HssqWzfXqPdNk3@kroah.com> (raw)
In-Reply-To: <ba94cc91fd452319a198e55884a1e4a18518bb75.1668395762.git.hunter.chasens18@ncf.edu>
On Sun, Nov 13, 2022 at 10:26:46PM -0500, Hunter Chasens wrote:
> Removes redundant 'int' from phrase `unsigned long long int`.
Why is it redundant? This says what you did, but not _WHY_ you are
doing it.
Also you forgot to cc: the proper public mailing lists that
scripts/get_maintainer.pl will ask you to cc: Without that, I can not
take your patches no matter how good they are.
thanks,
greg k-h
prev parent reply other threads:[~2022-11-14 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 3:26 [PATCH v3 0/2] Staging: greybus: Code style cleanup Hunter Chasens
2022-11-14 3:26 ` [PATCH v3 1/2] Staging: greybus: Whitespace cleanup Hunter Chasens
2022-11-14 3:37 ` Viresh Kumar
2022-11-14 7:20 ` Greg KH
2022-11-14 3:26 ` [PATCH v3 2/2] Staging: greybus: Removes redundant 'int' Hunter Chasens
2022-11-14 7:22 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3HssqWzfXqPdNk3@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=elder@kernel.org \
--cc=hunter.chasens18@ncf.edu \
--cc=hvaibhav.linux@gmail.com \
--cc=johan@kernel.org \
--cc=outreachy@lists.linux.dev \
--cc=pure.logic@nexus-software.ie \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.