All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Hao Lan <lanhao@huawei.com>
Cc: lipeng321@huawei.com, shenjian15@huawei.com,
	linyunsheng@huawei.com, liuyonglong@huawei.com,
	chenhao418@huawei.com, wangjie125@huawei.com,
	huangguangbin2@huawei.com, yisen.zhuang@huawei.com,
	salil.mehta@huawei.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
	xiaojiantao1@h-partners.com
Subject: Re: [PATCH net 2/3] net: hns3: fix return value check bug of rx copybreak
Date: Mon, 14 Nov 2022 09:39:52 +0200	[thread overview]
Message-ID: <Y3HwyOlO1FXhiPcS@unreal> (raw)
In-Reply-To: <20221112082118.57844-3-lanhao@huawei.com>

On Sat, Nov 12, 2022 at 04:21:17PM +0800, Hao Lan wrote:
> From: Jie Wang <wangjie125@huawei.com>
> 
> The refactoring of rx copybreak modifies the original return logic, which
> will make this feature unavailable. So this patch fixes the return logic of
> rx copybreak.
> 
> Fixes: e74a726da2c4 ("net: hns3: refactor hns3_nic_reuse_page()")
> Fixes: 99f6b5fb5f63 ("net: hns3: use bounce buffer when rx page can not be reused")
> 
> Signed-off-by: Jie Wang <wangjie125@huawei.com>

Please delete blank line between Fixes and SOBs, in all three patches.

Thanks

  reply	other threads:[~2022-11-14  7:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-12  8:21 [PATCH net 0/3] net: hns3: This series bugfix for the HNS3 ethernet driver Hao Lan
2022-11-12  8:21 ` [PATCH net 1/3] net: hns3: fix incorrect hw rss hash type of rx packet Hao Lan
2022-11-12  8:21 ` [PATCH net 2/3] net: hns3: fix return value check bug of rx copybreak Hao Lan
2022-11-14  7:39   ` Leon Romanovsky [this message]
2022-11-14  8:47     ` Hao Lan
2022-11-12  8:21 ` [PATCH net 3/3] net: hns3: fix setting incorrect phy link ksettings for firmware in resetting process Hao Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3HwyOlO1FXhiPcS@unreal \
    --to=leon@kernel.org \
    --cc=chenhao418@huawei.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=huangguangbin2@huawei.com \
    --cc=kuba@kernel.org \
    --cc=lanhao@huawei.com \
    --cc=linyunsheng@huawei.com \
    --cc=lipeng321@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=salil.mehta@huawei.com \
    --cc=shenjian15@huawei.com \
    --cc=wangjie125@huawei.com \
    --cc=xiaojiantao1@h-partners.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.