From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFD29256D for ; Mon, 14 Nov 2022 10:05:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F53EC433C1; Mon, 14 Nov 2022 10:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668420350; bh=NhbLUkVP1qgXtJ3N5nkqK7ZHPyOyPFqJ0lETMsTVYws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c3/xqHsgaufIAMdRP91uc5oGFKPH6u7DIAYCBEJ1ZkEeqyrESomFRzqxttQqIUY6m 4qh+KhN2tnUOrXjLTJiR+gz0VOTCqYxrA0JytJ3b90JwtGjRP9d/hOcCityd/ecDIT LyHHHUVLTRpG2chq4+AhNkoSlQeEjio/0N2uq/qWBdyI2/JbMjhZTNK4wWTGI8TpmA Hr03doA+gJ+IOgfJvZ75vgcfqKqeLj2T0taLl8D3QSh50KNgSnpy7M+nuoEF6EZOoX RI8ePXZAC8s7oAw1x//Flr4Om7AX1UJS3zKbklaxR6mVAuP6U6osjYKX9fktcPw7uu 4KQleIGBiObug== Date: Mon, 14 Nov 2022 10:05:43 +0000 From: Lee Jones To: Rob Herring Cc: "Russell King (Oracle)" , Krzysztof Kozlowski , Linus Walleij , Bartosz Golaszewski , Alyssa Rosenzweig , Andy Shevchenko , asahi@lists.linux.dev, devicetree@vger.kernel.org, Hector Martin , Jonathan Corbet , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Sven Peter Subject: Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller Message-ID: References: <531d88b8-75db-1d8f-1384-b8d05594e7b3@linaro.org> <20221109221723.GA2948356-robh@kernel.org> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221109221723.GA2948356-robh@kernel.org> On Wed, 09 Nov 2022, Rob Herring wrote: > On Tue, Nov 08, 2022 at 10:22:31PM +0000, Russell King (Oracle) wrote: > > On Tue, Nov 08, 2022 at 09:55:58PM +0100, Krzysztof Kozlowski wrote: > > > On 08/11/2022 17:33, Russell King (Oracle) wrote: > > > > Add a DT binding for the Apple Mac System Management Controller. > > > > > > Drop the second, redundant "binding" from subject. It's already in prefix. > > > > Yet another thing that's been there from the start... how many more > > things are you going to pick up in subsequent versions of the patch? > > When does this stop? > > > > In any case, taking your comment literally, > > > > "dt-bindings: mfd: add for Apple Mac System Management Controller" > > > > makes no sense, so presumably you want something more than that. > > > > In any case, I see several recent cases already merged which follow > > the pattern that I've used and that you've reviewed. > > > > > > Signed-off-by: Russell King (Oracle) > > > > --- > > > > .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ > > > > 1 file changed, 67 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > > > > new file mode 100644 > > > > index 000000000000..014eba5a1bbc > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > > > > @@ -0,0 +1,67 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Apple Mac System Management Controller > > > > + > > > > +maintainers: > > > > + - Hector Martin > > > > + > > > > +description: > > > > + Apple Mac System Management Controller implements various functions > > > > + such as GPIO, RTC, power, reboot. > > > > + > > > > +properties: > > > > + compatible: > > > > + items: > > > > + - enum: > > > > + - apple,t6000-smc > > > > + - apple,t8103-smc > > > > + - apple,t8112-smc > > > > + - const: apple,smc > > > > + > > > > + reg: > > > > + items: > > > > + - description: SMC area > > > > + - description: SRAM area > > > > + > > > > + reg-names: > > > > + items: > > > > + - const: smc > > > > + - const: sram > > > > + > > > > + mboxes: > > > > + maxItems: 1 > > > > + > > > > + gpio: > > > > + $ref: /schemas/gpio/gpio-macsmc.yaml > > > > > > So this depends on other patch, so: > > > 1. You need mention the dependency in cover letter (nothing there), > > > 2. Re-order patches. > > > > > > The GPIO cannot go separate tree and this must be explicitly communicated. > > > > Sigh, getting an order that is sensible is really bloody difficult. > > It's not. Sub-devices before the MFD. The only time that doesn't work is > when the sub-devices put the parent MFD in their example. The solution > there is don't do that. Just 1 complete example in the MFD schema and no > examples in the sub-devices. > > > I'm quite sure Lee is only going to want to apply the mfd bits. > > Indeed. I can't seem to make Lee care... All the schemas should really > be applied together. I care about drivers. Happy to take the set as a whole if it helps. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 123CEC4332F for ; Mon, 14 Nov 2022 10:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fYo4rRbiWGBFgvBpwc8SPizLE+wAStVQzFMDZYgxkB8=; b=XHPY8SvaeXFYSF nDEr7xiuWCKmw7ZzoTannzqYSj/Ds5XuKy/fsvzqP4NktARypcZnfqljsfrfseFrQK1H1U9Fg3PPj 6ul1icOxo3TcGgXaGLlZJEM+NdfAYPH6bEdyqJwhnlV5PU9sE+6PvNBlUcYuIpgN8ET6HM5S96rIU pSIW48Yu6Lyl79HXoBkc+pTIYmSYqW7dIlmPEAD7Y2C/np0byUQxG2XFatjx7fKSz7veybVGJk+IB FAlGqJO64huRodqKXGPE5SpqQQocv0oS/O5niI5pvGs1k2jaBJJX0+GrQy1XVzaBXyPAb1uoM8/Kj VGHcWzIVCGm0npEmHWIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouWLl-00HP5l-Dh; Mon, 14 Nov 2022 10:05:57 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouWLh-00HP4X-7e for linux-arm-kernel@lists.infradead.org; Mon, 14 Nov 2022 10:05:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E424FB80D95; Mon, 14 Nov 2022 10:05:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F53EC433C1; Mon, 14 Nov 2022 10:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668420350; bh=NhbLUkVP1qgXtJ3N5nkqK7ZHPyOyPFqJ0lETMsTVYws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c3/xqHsgaufIAMdRP91uc5oGFKPH6u7DIAYCBEJ1ZkEeqyrESomFRzqxttQqIUY6m 4qh+KhN2tnUOrXjLTJiR+gz0VOTCqYxrA0JytJ3b90JwtGjRP9d/hOcCityd/ecDIT LyHHHUVLTRpG2chq4+AhNkoSlQeEjio/0N2uq/qWBdyI2/JbMjhZTNK4wWTGI8TpmA Hr03doA+gJ+IOgfJvZ75vgcfqKqeLj2T0taLl8D3QSh50KNgSnpy7M+nuoEF6EZOoX RI8ePXZAC8s7oAw1x//Flr4Om7AX1UJS3zKbklaxR6mVAuP6U6osjYKX9fktcPw7uu 4KQleIGBiObug== Date: Mon, 14 Nov 2022 10:05:43 +0000 From: Lee Jones To: Rob Herring Cc: "Russell King (Oracle)" , Krzysztof Kozlowski , Linus Walleij , Bartosz Golaszewski , Alyssa Rosenzweig , Andy Shevchenko , asahi@lists.linux.dev, devicetree@vger.kernel.org, Hector Martin , Jonathan Corbet , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Sven Peter Subject: Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller Message-ID: References: <531d88b8-75db-1d8f-1384-b8d05594e7b3@linaro.org> <20221109221723.GA2948356-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221109221723.GA2948356-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221114_020553_577754_FA0CD6F6 X-CRM114-Status: GOOD ( 32.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAwOSBOb3YgMjAyMiwgUm9iIEhlcnJpbmcgd3JvdGU6Cgo+IE9uIFR1ZSwgTm92IDA4 LCAyMDIyIGF0IDEwOjIyOjMxUE0gKzAwMDAsIFJ1c3NlbGwgS2luZyAoT3JhY2xlKSB3cm90ZToK PiA+IE9uIFR1ZSwgTm92IDA4LCAyMDIyIGF0IDA5OjU1OjU4UE0gKzAxMDAsIEtyenlzenRvZiBL b3psb3dza2kgd3JvdGU6Cj4gPiA+IE9uIDA4LzExLzIwMjIgMTc6MzMsIFJ1c3NlbGwgS2luZyAo T3JhY2xlKSB3cm90ZToKPiA+ID4gPiBBZGQgYSBEVCBiaW5kaW5nIGZvciB0aGUgQXBwbGUgTWFj IFN5c3RlbSBNYW5hZ2VtZW50IENvbnRyb2xsZXIuCj4gPiA+IAo+ID4gPiBEcm9wIHRoZSBzZWNv bmQsIHJlZHVuZGFudCAiYmluZGluZyIgZnJvbSBzdWJqZWN0LiBJdCdzIGFscmVhZHkgaW4gcHJl Zml4Lgo+ID4gCj4gPiBZZXQgYW5vdGhlciB0aGluZyB0aGF0J3MgYmVlbiB0aGVyZSBmcm9tIHRo ZSBzdGFydC4uLiBob3cgbWFueSBtb3JlCj4gPiB0aGluZ3MgYXJlIHlvdSBnb2luZyB0byBwaWNr IHVwIGluIHN1YnNlcXVlbnQgdmVyc2lvbnMgb2YgdGhlIHBhdGNoPwo+ID4gV2hlbiBkb2VzIHRo aXMgc3RvcD8KPiA+IAo+ID4gSW4gYW55IGNhc2UsIHRha2luZyB5b3VyIGNvbW1lbnQgbGl0ZXJh bGx5LAo+ID4gCj4gPiAiZHQtYmluZGluZ3M6IG1mZDogYWRkIGZvciBBcHBsZSBNYWMgU3lzdGVt IE1hbmFnZW1lbnQgQ29udHJvbGxlciIKPiA+IAo+ID4gbWFrZXMgbm8gc2Vuc2UsIHNvIHByZXN1 bWFibHkgeW91IHdhbnQgc29tZXRoaW5nIG1vcmUgdGhhbiB0aGF0Lgo+ID4gCj4gPiBJbiBhbnkg Y2FzZSwgSSBzZWUgc2V2ZXJhbCByZWNlbnQgY2FzZXMgYWxyZWFkeSBtZXJnZWQgd2hpY2ggZm9s bG93Cj4gPiB0aGUgcGF0dGVybiB0aGF0IEkndmUgdXNlZCBhbmQgdGhhdCB5b3UndmUgcmV2aWV3 ZWQuCj4gPiAKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBSdXNzZWxsIEtpbmcgKE9yYWNsZSkgPHJt aytrZXJuZWxAYXJtbGludXgub3JnLnVrPgo+ID4gPiA+IC0tLQo+ID4gPiA+ICAuLi4vZGV2aWNl dHJlZS9iaW5kaW5ncy9tZmQvYXBwbGUsc21jLnlhbWwgICAgfCA2NyArKysrKysrKysrKysrKysr KysrCj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA2NyBpbnNlcnRpb25zKCspCj4gPiA+ID4gIGNy ZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL2Fw cGxlLHNtYy55YW1sCj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9tZmQvYXBwbGUsc21jLnlhbWwgYi9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvbWZkL2FwcGxlLHNtYy55YW1sCj4gPiA+ID4gbmV3IGZpbGUgbW9k ZSAxMDA2NDQKPiA+ID4gPiBpbmRleCAwMDAwMDAwMDAwMDAuLjAxNGViYTVhMWJiYwo+ID4gPiA+ IC0tLSAvZGV2L251bGwKPiA+ID4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvbWZkL2FwcGxlLHNtYy55YW1sCj4gPiA+ID4gQEAgLTAsMCArMSw2NyBAQAo+ID4gPiA+ ICsjIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiAoR1BMLTIuMC1vbmx5IE9SIEJTRC0yLUNsYXVz ZSkKPiA+ID4gPiArJVlBTUwgMS4yCj4gPiA+ID4gKy0tLQo+ID4gPiA+ICskaWQ6IGh0dHA6Ly9k ZXZpY2V0cmVlLm9yZy9zY2hlbWFzL21mZC9hcHBsZSxzbWMueWFtbCMKPiA+ID4gPiArJHNjaGVt YTogaHR0cDovL2RldmljZXRyZWUub3JnL21ldGEtc2NoZW1hcy9jb3JlLnlhbWwjCj4gPiA+ID4g Kwo+ID4gPiA+ICt0aXRsZTogQXBwbGUgTWFjIFN5c3RlbSBNYW5hZ2VtZW50IENvbnRyb2xsZXIK PiA+ID4gPiArCj4gPiA+ID4gK21haW50YWluZXJzOgo+ID4gPiA+ICsgIC0gSGVjdG9yIE1hcnRp biA8bWFyY2FuQG1hcmNhbi5zdD4KPiA+ID4gPiArCj4gPiA+ID4gK2Rlc2NyaXB0aW9uOgo+ID4g PiA+ICsgIEFwcGxlIE1hYyBTeXN0ZW0gTWFuYWdlbWVudCBDb250cm9sbGVyIGltcGxlbWVudHMg dmFyaW91cyBmdW5jdGlvbnMKPiA+ID4gPiArICBzdWNoIGFzIEdQSU8sIFJUQywgcG93ZXIsIHJl Ym9vdC4KPiA+ID4gPiArCj4gPiA+ID4gK3Byb3BlcnRpZXM6Cj4gPiA+ID4gKyAgY29tcGF0aWJs ZToKPiA+ID4gPiArICAgIGl0ZW1zOgo+ID4gPiA+ICsgICAgICAtIGVudW06Cj4gPiA+ID4gKyAg ICAgICAgICAtIGFwcGxlLHQ2MDAwLXNtYwo+ID4gPiA+ICsgICAgICAgICAgLSBhcHBsZSx0ODEw My1zbWMKPiA+ID4gPiArICAgICAgICAgIC0gYXBwbGUsdDgxMTItc21jCj4gPiA+ID4gKyAgICAg IC0gY29uc3Q6IGFwcGxlLHNtYwo+ID4gPiA+ICsKPiA+ID4gPiArICByZWc6Cj4gPiA+ID4gKyAg ICBpdGVtczoKPiA+ID4gPiArICAgICAgLSBkZXNjcmlwdGlvbjogU01DIGFyZWEKPiA+ID4gPiAr ICAgICAgLSBkZXNjcmlwdGlvbjogU1JBTSBhcmVhCj4gPiA+ID4gKwo+ID4gPiA+ICsgIHJlZy1u YW1lczoKPiA+ID4gPiArICAgIGl0ZW1zOgo+ID4gPiA+ICsgICAgICAtIGNvbnN0OiBzbWMKPiA+ ID4gPiArICAgICAgLSBjb25zdDogc3JhbQo+ID4gPiA+ICsKPiA+ID4gPiArICBtYm94ZXM6Cj4g PiA+ID4gKyAgICBtYXhJdGVtczogMQo+ID4gPiA+ICsKPiA+ID4gPiArICBncGlvOgo+ID4gPiA+ ICsgICAgJHJlZjogL3NjaGVtYXMvZ3Bpby9ncGlvLW1hY3NtYy55YW1sCj4gPiA+IAo+ID4gPiBT byB0aGlzIGRlcGVuZHMgb24gb3RoZXIgcGF0Y2gsIHNvOgo+ID4gPiAxLiBZb3UgbmVlZCBtZW50 aW9uIHRoZSBkZXBlbmRlbmN5IGluIGNvdmVyIGxldHRlciAobm90aGluZyB0aGVyZSksCj4gPiA+ IDIuIFJlLW9yZGVyIHBhdGNoZXMuCj4gPiA+IAo+ID4gPiBUaGUgR1BJTyBjYW5ub3QgZ28gc2Vw YXJhdGUgdHJlZSBhbmQgdGhpcyBtdXN0IGJlIGV4cGxpY2l0bHkgY29tbXVuaWNhdGVkLgo+ID4g Cj4gPiBTaWdoLCBnZXR0aW5nIGFuIG9yZGVyIHRoYXQgaXMgc2Vuc2libGUgaXMgcmVhbGx5IGJs b29keSBkaWZmaWN1bHQuCj4gCj4gSXQncyBub3QuIFN1Yi1kZXZpY2VzIGJlZm9yZSB0aGUgTUZE LiBUaGUgb25seSB0aW1lIHRoYXQgZG9lc24ndCB3b3JrIGlzIAo+IHdoZW4gdGhlIHN1Yi1kZXZp Y2VzIHB1dCB0aGUgcGFyZW50IE1GRCBpbiB0aGVpciBleGFtcGxlLiBUaGUgc29sdXRpb24gCj4g dGhlcmUgaXMgZG9uJ3QgZG8gdGhhdC4gSnVzdCAxIGNvbXBsZXRlIGV4YW1wbGUgaW4gdGhlIE1G RCBzY2hlbWEgYW5kIG5vIAo+IGV4YW1wbGVzIGluIHRoZSBzdWItZGV2aWNlcy4KPiAKPiA+IEkn bSBxdWl0ZSBzdXJlIExlZSBpcyBvbmx5IGdvaW5nIHRvIHdhbnQgdG8gYXBwbHkgdGhlIG1mZCBi aXRzLiAKPiAKPiBJbmRlZWQuIEkgY2FuJ3Qgc2VlbSB0byBtYWtlIExlZSBjYXJlLi4uIEFsbCB0 aGUgc2NoZW1hcyBzaG91bGQgcmVhbGx5IAo+IGJlIGFwcGxpZWQgdG9nZXRoZXIuCgpJIGNhcmUg YWJvdXQgZHJpdmVycy4gIEhhcHB5IHRvIHRha2UgdGhlIHNldCBhcyBhIHdob2xlIGlmIGl0IGhl bHBzLgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=