From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61083C433FE for ; Mon, 14 Nov 2022 10:03:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2JjMoY23ifetSl85WGgkes+i1aIqaQO/mAwXpd3w2XA=; b=AIH+ND1+XXTnPL 5gB6QPeCMXR3mc6tVE/vDzu1U4gbGkQIm6ilaYas5efZOUiGR48dCRyEJaeFjIpFgUlogzBecrNHV POUkYqKnPFwGIt1KI88iLApn9iAZzFu6xGpNyPHU0PN5O7xHnDAUZnkvr4N9E6Y88BPOc6sU0H4hG U56aeNOZrQrcPGL40oETDiMyo4njFuVfsFU5licWdE6/s9RYOCqo/NtCZILRwMNbcl29xUJmodujg iGWQvyeziGf6gvz7h4AC44b8hnppxQJbQ90TUeuMuGtkraDqtA5g76Tv/q/5BlS1CImTPL77w4FDb xLBrkq3I+zaXNx7j5RtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouWHy-00HNmW-9x; Mon, 14 Nov 2022 10:02:02 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouWHv-00HNjs-5h for linux-arm-kernel@lists.infradead.org; Mon, 14 Nov 2022 10:02:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 99A34B80D96; Mon, 14 Nov 2022 10:01:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B6D0C433D6; Mon, 14 Nov 2022 10:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668420113; bh=0AWDgj8YRiMgi+RCQmhjPkOW5dw2tU+daCdk+KQy8U8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uiw0du2Mn3DKr94KgOc6lFzKfMp0U0UJWL9mUM2a89p4q+S8FvSsFFihv+vNk+RFl ADaK7pe4lGb0pD9+FOqBNtQPwWL54XYGppMM6lsBEYvtQul0FGn9xf7+u12Cydh6aQ xas6VneccrgIZlzJ7mZRDAH+NV/d+WnxMlQQyjkO9spZFjtAg445WC6ZM4IB7fWP4J 5pFXgmm4MkFnkdhtriiNxNUWVfrbg5iC812Ly7flrLFNcz436eNQaSDGJLORpwlnZl hHeHRQ3IZqgu1p6U/zyZJD3AkFphUDVmaO0HCghcgUoR0sBhOjKnW6xKvWNC2KBOb/ 8fonfWtvLMKWQ== Date: Mon, 14 Nov 2022 10:01:47 +0000 From: Lee Jones To: Liu Ying Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org Subject: Re: [PATCH RESEND] mfd: Add Freescale i.MX8qxp Control and Status Registers (CSR) module driver Message-ID: References: <20221017075702.4182846-1-victor.liu@nxp.com> <4dfb7699c33974a682d798071c85b431b87e5432.camel@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4dfb7699c33974a682d798071c85b431b87e5432.camel@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221114_020159_536656_58DE5300 X-CRM114-Status: GOOD ( 61.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwOCBOb3YgMjAyMiwgTGl1IFlpbmcgd3JvdGU6Cgo+IEhpIExlZSwKPiAKPiBPbiBN b24sIDIwMjItMTEtMDcgYXQgMDk6MDUgKzAwMDAsIExlZSBKb25lcyB3cm90ZToKPiA+IE9uIFdl ZCwgMDIgTm92IDIwMjIsIExpdSBZaW5nIHdyb3RlOgo+ID4gCj4gPiA+IEhpIExlZSwKPiA+ID4g Cj4gPiA+IE9uIFR1ZSwgMjAyMi0xMS0wMSBhdCAxMzo1MyArMDgwMCwgTGl1IFlpbmcgd3JvdGU6 Cj4gPiA+ID4gSGkgTGVlLAo+ID4gPiA+IAo+ID4gPiA+IE9uIE1vbiwgMjAyMi0xMC0zMSBhdCAx NTo0MCArMDAwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gPiA+ID4gT24gTW9uLCAxNyBPY3QgMjAy MiwgTGl1IFlpbmcgd3JvdGU6Cj4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gRnJlZXNjYWxlIGkuTVg4 cXhwIENvbnRyb2wgYW5kIFN0YXR1cyBSZWdpc3RlcnMgKENTUikgbW9kdWxlIGlzIGEKPiA+ID4g PiA+ID4gc3lzdGVtCj4gPiA+ID4gPiA+IGNvbnRyb2xsZXIuIEl0IHJlcHJlc2VudHMgYSBzZXQg b2YgbWlzY2VsbGFuZW91cyByZWdpc3RlcnMgb2YgYQo+ID4gPiA+ID4gPiBzcGVjaWZpYwo+ID4g PiA+ID4gPiBzdWJzeXN0ZW0uIEl0IG1heSBwcm92aWRlIGNvbnRyb2wgYW5kL29yIHN0YXR1cyBy ZXBvcnQgaW50ZXJmYWNlcwo+ID4gPiA+ID4gPiB0byBhCj4gPiA+ID4gPiA+IG1peCBvZiBzdGFu ZGFsb25lIGhhcmR3YXJlIGRldmljZXMgd2l0aGluIHRoYXQgc3Vic3lzdGVtLgo+ID4gPiA+ID4g PiAKPiA+ID4gPiA+ID4gVGhlIENTUiBtb2R1bGUgaW4gaS5NWDhxbS9xeHAgU29DcyBpcyBhIGNo aWxkIG5vZGUgb2YgYSBzaW1wbGUKPiA+ID4gPiA+ID4gcG93ZXItbWFuYWdlZAo+ID4gPiA+ID4g PiBidXMoaS5NWDhxeHAgcGl4ZWwgbGluayBNU0kgYnVzKS4gVG8gcHJvcGFnYXRlIHBvd2VyIG1h bmFnZW1lbnQKPiA+ID4gPiA+ID4gb3BlcmF0aW9ucwo+ID4gPiA+ID4gPiBvZiB0aGUgQ1NSIG1v ZHVsZSdzIGNoaWxkIGRldmljZXMgdG8gdGhhdCBzaW1wbGUgcG93ZXItbWFuYWdlZAo+ID4gPiA+ ID4gPiBidXMsIGFkZCBhCj4gPiA+ID4gPiA+IGRlZGljYXRlZCBkcml2ZXIgZm9yIHRoZSBDU1Ig bW9kdWxlLiBBbHNvLCB0aGUgZHJpdmVyIHdvdWxkCj4gPiA+ID4gPiA+IHBvcHVsYXRlIHRoZSBD U1IKPiA+ID4gPiA+ID4gbW9kdWxlJ3MgY2hpbGQgZGV2aWNlcy4KPiA+ID4gPiA+ID4gCj4gPiA+ ID4gPiA+IFNpZ25lZC1vZmYtYnk6IExpdSBZaW5nIDx2aWN0b3IubGl1QG54cC5jb20+Cj4gPiA+ ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiBUaGUgRnJlZXNjYWxlIGkuTVg4cXhwIENTUiBEVCBiaW5k aW5ncyBpcyBhdAo+ID4gPiA+ID4gPiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv bWZkL2ZzbCxpbXg4cXhwLWNzci55YW1sLgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gUmVzZW5k IHRoZSBwYXRjaCBiYXNlZCBvbiB2Ni4xLXJjMS4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ICBk cml2ZXJzL21mZC9LY29uZmlnICAgICAgICAgICB8IDEwICsrKysrKysKPiA+ID4gPiA+ID4gIGRy aXZlcnMvbWZkL01ha2VmaWxlICAgICAgICAgIHwgIDEgKwo+ID4gPiA+ID4gPiAgZHJpdmVycy9t ZmQvZnNsLWlteDhxeHAtY3NyLmMgfCA1Mwo+ID4gPiA+ID4gPiArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKwo+ID4gPiA+ID4gPiAgMyBmaWxlcyBjaGFuZ2VkLCA2NCBpbnNlcnRp b25zKCspCj4gPiA+ID4gPiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tZmQvZnNsLWlt eDhxeHAtY3NyLmMKPiA+ID4gPiAKPiA+ID4gPiBbLi4uXQo+ID4gPiA+IAo+ID4gPiA+ID4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvZnNsLWlteDhxeHAtY3NyLmMgYi9kcml2ZXJzL21mZC9m c2wtCj4gPiA+ID4gPiA+IGlteDhxeHAtY3NyLmMKPiA+ID4gPiA+ID4gbmV3IGZpbGUgbW9kZSAx MDA2NDQKPiA+ID4gPiA+ID4gaW5kZXggMDAwMDAwMDAwMDAwLi4zOTE1ZDNkNmNhNjUKPiA+ID4g PiA+ID4gLS0tIC9kZXYvbnVsbAo+ID4gPiA+ID4gPiArKysgYi9kcml2ZXJzL21mZC9mc2wtaW14 OHF4cC1jc3IuYwo+ID4gPiA+ID4gPiBAQCAtMCwwICsxLDUzIEBACj4gPiA+ID4gPiA+ICsvLyBT UERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMCsKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4g PiArLyoKPiA+ID4gPiA+ID4gKyAqIENvcHlyaWdodCAyMDIyIE5YUAo+ID4gPiA+ID4gPiArICov Cj4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gKyNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KPiA+ ID4gPiA+ID4gKyNpbmNsdWRlIDxsaW51eC9vZl9wbGF0Zm9ybS5oPgo+ID4gPiA+ID4gPiArI2lu Y2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RldmljZS5oPgo+ID4gPiA+ID4gPiArI2luY2x1ZGUgPGxp bnV4L3BtX3J1bnRpbWUuaD4KPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiArc3RhdGljIGludCBp bXg4cXhwX2Nzcl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4gPiA+ID4g PiArewo+ID4gPiA+ID4gPiArCWludCByZXQ7Cj4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gKwlw bV9ydW50aW1lX2VuYWJsZSgmcGRldi0+ZGV2KTsKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiAr CXJldCA9IGRldm1fb2ZfcGxhdGZvcm1fcG9wdWxhdGUoJnBkZXYtPmRldik7Cj4gPiA+ID4gPiAK PiA+ID4gPiA+IFRoZSB1c2Ugb2YgdGhpcyBBUEkgZG9lcyBub3QgY29uc3RpdHV0ZSBhIE1GRC4K PiA+ID4gPiA+IAo+ID4gPiA+ID4gUGxlYXNlIHVzZSAic2ltcGxlLW1mZCIgaW5zdGVhZC4KPiA+ ID4gPiAKPiA+ID4gPiBzaW1wbGUtbWZkIGRldmljZXMgaGF2ZSAiT05MWV9CVVMiIHNldCBpbiBz aW1wbGUtcG0tYnVzLmMsIHNvIHRoZQo+ID4gPiA+IHNpbXBsZS1wbS1idXMgZHJpdmVyIHdvdWxk IG5vdCBwb3B1bGF0ZSBjaGlsZCBkZXZpY2VzIG9mIHNpbXBsZS1tZmQKPiA+ID4gPiBkZXZpY2Vz Lgo+ID4gCj4gPiBSaWdodCwgc2ltcGxlLXBtLWJ1cyB3aWxsIG5vdCBwb3B1bGF0ZSBjaGlsZCBk ZXZpY2VzLCBiZWNhdXNlOgo+IAo+IHNpbXBsZS1wbS1idXMuYyBtYXkgcG9wdWxhdGUgY2hpbGQg ZGV2aWNlcyBvZiBzaW1wbGUtcG0tYnVzIGRldmljZXMKPiBiZWNhdXNlICJPTkxZX0JVUyIgaXMg X25vdF8gc2V0IGZvciBzaW1wbGUtcG0tYnVzIGRldmljZXMuCj4gCj4gc2ltcGxlLXBtLWJ1cy5j IHdvdWxkIF9ub3RfIHBvcHVsYXRlIGNoaWxkIGRldmljZXMgb2Ygc2ltcGxlLW1mZAo+IGRldmlj ZXMgYmVjYXVzZSAiT05MWV9CVVMiIGlzIHNldCBmb3Igc2ltcGxlLW1mZCBkZXZpY2VzLgo+IAo+ ID4gCj4gPiAgIC8qICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAgICAqIFRoZXNlIGFyZSB0cmFuc3BhcmVudCBi dXMgZGV2aWNlcyAobm90IHNpbXBsZS1wbS1idXMgbWF0Y2hlcykgdGhhdCAgCj4gPiAgICAqIGhh dmUgdGhlaXIgY2hpbGQgbm9kZXMgcG9wdWxhdGVkIGF1dG9tYXRpY2FsbHkuICBTbywgZG9uJ3Qg bmVlZCB0byAgCj4gPiAgICAqIGRvIGFueXRoaW5nIG1vcmUuIFdlIG9ubHkgbWF0Y2ggd2l0aCB0 aGUgZGV2aWNlIGlmIHRoaXMgZHJpdmVyIGlzICAgCj4gPiAgICAqIHRoZSBtb3N0IHNwZWNpZmlj IG1hdGNoIGJlY2F1c2Ugd2UgZG9uJ3Qgd2FudCB0byBpbmNvcnJlY3RseSBiaW5kIHRvCj4gPiAg ICAqIGEgZGV2aWNlIHRoYXQgaGFzIGEgbW9yZSBzcGVjaWZpYyBkcml2ZXIuICAgICAgICAgICAg ICAgICAgICAgICAgICAgCj4gPiAgICAqLyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gPiAKPiA+IFNvICJzaW1wbGUt bWZkIiBtdXN0IGJlIHBvcHVsYXRlZCBlbHNld2hlcmUgaS5lLiBkcml2ZXJzL29mL3BsYXRmb3Jt LmMuCj4gCj4gSWYgc2ltcGxlLW1mZCBkZXZpY2UgaXMgYSBjaGlsZCBkZXZpY2Ugb2Ygb25lIGRl dmljZSBsaXN0ZWQgaW4KPiBvZl9kZWZhdWx0X2J1c19tYXRjaF90YWJsZVtdLCB0aGVuIGl0IG1h eSBiZSBwb3B1bGF0ZWQgYnkKPiBkcml2ZXJzL29mL3BsYXRmb3JtLmMuICBCdXQsIGluIG15IGNh c2UsIHNpbXBsZS1tZmQgZGV2aWNlIGlzIGEgY2hpbGQKPiBkZXZpY2Ugb2Ygc2ltcGxlLXBtLWJ1 cyBkZXZpY2Uobm90IGxpc3RlZCBpbiB0aGF0IHRhYmxlKSwgc28gaXQgd2lsbAo+IG5vdCBiZSBw b3B1bGF0ZWQgYnkgZHJpdmVycy9vZi9wbGF0Zm9ybS5jLiAgSW5zdGVhZCwKPiBkcml2ZXJzL2J1 cy9zaW1wbGUtcG0tYnVzLmMgd291bGQgcG9wdWxhdGUgdGhlIHNpbXBsZS1tZmQgZGV2aWNlLgo+ IAo+ID4gCj4gPiA+ID4gQWxzbywgdGhlIHNpbXBsZS1wbS1idXMgZHJpdmVyIHdvdWxkIG5vdCBl bmFibGUgcnVudGltZQo+ID4gPiA+IHBvd2VyIG1hbmFnZW1lbnQgZm9yIHNpbXBsZS1tZmQgZGV2 aWNlcyBkdWUgdG8gIk9OTFlfQlVTIiwgd2hpY2gKPiA+ID4gPiBtZWFucyBpdCB3b3VsZCBub3Qg cHJvcGFnYXRlIHBvd2VyIG1hbmFnZW1lbnQgb3BlcmF0aW9ucyBmcm9tIGNoaWxkCj4gPiA+ID4g ZGV2aWNlcyBvZiBzaW1wbGUtbWZkIGRldmljZXMgdG8gcGFyZW50IGRldmljZXMgb2Ygc2ltcGxl LW1mZAo+ID4gPiA+IGRldmljZXMuICBUaGF0J3Mgd2h5IGEgZGVkaWNhdGVkIGZzbC1pbXg4cXhw LWNzciBkcml2ZXIgaXMgbmVlZGVkLiAKPiA+IAo+ID4gVGhpcyBpcyBtb3JlIG9mIGFuIGlzc3Vl Lgo+ID4gCj4gPiBXaHkgY2FuJ3QgdGhpcyBkZXZpY2UgdXNlICJzaW1wbGUtcG0tYnVzIiB0byBo YXZlIHN1cHBvcnQgZm9yIGJvdGgKPiA+IGF1dG8tcmVnaXN0cmF0aW9uIEFORCBSdW50aW1lIFBN Pwo+IAo+IElmIEkgY2hhbmdlIHRoZSBjb21wYXRpYmxlIHN0cmluZyBvZiB0aGUgQ1NSIG1vZHVs ZSBmcm9tCj4gImZzbCxpbXg4cXhwLW1pcGktbHZkcy1jc3IiLCAic3lzY29uIiwgInNpbXBsZS1t ZmQiCj4gdG8KPiAiZnNsLGlteDhxeHAtbWlwaS1sdmRzLWNzciIsICJzeXNjb24iLCAic2ltcGxl LXBtLWJ1cyIsCj4gYWxsIGRldmljZXMgSSdtIGludGVyZXN0ZWQgaW4gYXJlIHBvcHVsYXRlZCBh bmQgYWxsIHJlbGV2YW50IGRyaXZlcnMKPiBjYW4gcHJvYmUuCgpPa2F5LCB0aGF0J3MgZ29vZC4K Cj4gQnV0LCB0aGlzIGNoYW5nZSBtYWtlcyAnbWFrZSBkdF9iaW5kaW5nX2NoZWNrJyBmb3IgdGhl Cj4gZXhpc3RpbmcgZnNsLGlteDhxeHAtY3NyLnlhbWwgZmFpbDoKPiAKPiAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLTg8LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t Cj4gL2tlcm5lbC9saW51eC9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL2Zz bCxpbXg4cXhwLQo+IGNzci5leGFtcGxlLmR0Yjogc3lzY29uQDU2MjIxMDAwOiAkbm9kZW5hbWU6 MDogJ3N5c2NvbkA1NjIyMTAwMCcgZG9lcwo+IG5vdCBtYXRjaCAnXmJ1cyhAWzAtOWEtZl0rKT8k Jwo+IAlGcm9tIHNjaGVtYToKPiAva2VybmVsL2xpbnV4L0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9idXMvc2ltcGxlLXBtLWJ1cy55YW1sCj4gL2tlcm5lbC9saW51eC9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL2ZzbCxpbXg4cXhwLQo+IGNzci5leGFtcGxl LmR0Yjogc3lzY29uQDU2MjIxMDAwOiAnI2FkZHJlc3MtY2VsbHMnIGlzIGEgcmVxdWlyZWQKPiBw cm9wZXJ0eQo+IAlGcm9tIHNjaGVtYToKPiAva2VybmVsL2xpbnV4L0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9idXMvc2ltcGxlLXBtLWJ1cy55YW1sCj4gL2tlcm5lbC9saW51eC9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL2ZzbCxpbXg4cXhwLQo+IGNzci5l eGFtcGxlLmR0Yjogc3lzY29uQDU2MjIxMDAwOiAnI3NpemUtY2VsbHMnIGlzIGEgcmVxdWlyZWQg cHJvcGVydHkKPiAJRnJvbSBzY2hlbWE6Cj4gL2tlcm5lbC9saW51eC9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvYnVzL3NpbXBsZS1wbS1idXMueWFtbAo+IC9rZXJuZWwvbGludXgv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9mc2wsaW14OHF4cC0KPiBjc3Iu ZXhhbXBsZS5kdGI6IHN5c2NvbkA1NjIyMTAwMDogJ3JhbmdlcycgaXMgYSByZXF1aXJlZCBwcm9w ZXJ0eQo+IAlGcm9tIHNjaGVtYToKPiAva2VybmVsL2xpbnV4L0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9idXMvc2ltcGxlLXBtLWJ1cy55YW1sCj4gLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS04PC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+IAo+ IFRoZSBlcnJvciBsb2cgYmFzaWNhbGx5IGNvbXBsYWlucyB0d28gdGhpbmdzOgo+IDEpIFRoZSBl eGFtcGxlIG5vZGVuYW1lICdzeXNjb25ANTYyMjEwMDAnIHNob3VsZCBtYXRjaAo+ICdeYnVzKEBb MC05YS1mXSspPyQnLgo+IDIpIE1pc3NpbmcgJyNhZGRyZXNzLWNlbGxzJywgJyNzaXplLWNlbGxz JyBhbmQgJ3JhbmdlcycgcHJvcGVydGllcyBhcwo+IHJlcXVpcmVkIGJ5IHNpbXBsZS1wbS1idXMu Cj4gCj4gUmVnYXJkaW5nIDEpLCBpZiBJIGNoYW5nZSAnc3lzY29uQDU2MjIxMDAwJyB0byAnYnVz QDU2MjIxMDAwJywgdGhlbiB0aGUKPiBiZWxvdyBlcnJvciBjb21lcyBhbG9uZzoKPiAtLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLTg8LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCj4gL2tlcm5lbC9saW51eC9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv bWZkL2ZzbCxpbXg4cXhwLQo+IGNzci5leGFtcGxlLmR0YjogYnVzQDU2MjIxMDAwOiAkbm9kZW5h bWU6MDogJ2J1c0A1NjIyMTAwMCcgZG9lcyBub3QKPiBtYXRjaCAnXnN5c2NvbkBbMC05YS1mXSsk Jwo+IAlGcm9tIHNjaGVtYToKPiAva2VybmVsL2xpbnV4L0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9tZmQvZnNsLGlteDhxeHAtCj4gY3NyLnlhbWwKPiAtLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLTg8LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4g U28sIGl0IGxvb2tzIGxpa2UgInN5c2NvbiIgYW5kICJzaW1wbGUtcG0tYnVzIiBjYW4gbm90IGJl IGluIGNvbXBhdGJpbGUKPiBzdHJpbmcgYXQgdGhlIHNhbWUgdGltZS4gIE5vdGUgdGhhdCAic3lz Y29uIiBpcyBuZWVkZWQgYmVjYXVzZSBvdGhlcgo+IGRldmljZSBub2RlcyBtYXkgcmVmZXJlbmNl IHRoZSBDU1IgbW9kdWxlIHRocm91Z2ggYSBwaGFuZGxlLCBsaWtlIHRoZQo+ICJmc2wsaW14OHF4 cC1taXBpLWRwaHkiIGRldmljZS4KPiAKPiBSZWdhcmRpbmcgMiksIEkgbWF5IHRyeSB0byBhZGQg dGhvc2UgcmVxdWlyZWQgcHJvcGVydGllcywgYnV0IGl0IHdvdWxkCj4gYnJlYWsgdGhlIGV4aXN0 aW5nIHNjaGVtYXMgb2YgdGhlIGNoaWxkIGRldmljZXMgb2YgdGhlIENTUiBtb2R1bGUsIGxpa2UK PiB0aGUgImZzbCxpbXg4cXhwLWxkYiIgZGV2aWNlLCBiZWNhdXNlICJyZWciIHByb3BlcnR5IGlz IG5vdCBhbGxvd2VkLgo+IAo+IFNvLCBpdCBsb29rcyBsaWtlIHRoZSBDU1IgbW9kdWxlIHN0aWxs IHNob3VsZCBiZSBzaW1wbGUtbWZkIGRldmljZSBidXQKPiBub3Qgc2ltcGxlLXBtLWJ1cyBkZXZp Y2UsIHJpZ2h0PwoKSXQgc291bmRzIGxpa2UgdGhlIGdlbmVyaWMgYXV0by1wcm9iaW5nIGZ1bmN0 aW9uYWxpdHkgcHJvdmlkZWQgYnkgdGhlCmtlcm5lbCB3b3JrcyB3ZWxsIHRvIGdpdmUgeW91IHdp dGggYSBmdWxseSBzZWxmLXJlZ2lzdGVyaW5nIG1lY2hhbmlzbS4KQWxsIHlvdSBuZWVkIHRvIGRv IG5vdyBpcyBmaWd1cmUgb3V0IHdoeSB0aGUgRFQgY2hlY2tlciBpcyBub3QgaGFwcHkKd2l0aCB5 b3VyIHNvbHV0aW9uLgoKUGxlYXNlIHdvcmsgd2l0aCB0aGUgRGV2aWNlIFRyZWUgbWFpbnRhaW5l cnMgb24gdGhpcy4KCj4gPiA+IE9uZSBtb3JlIHBvaW50IHdoaWNoIG1pZ2h0IGJlIG92ZXJsb29r ZWQgLSBhcyBtZW50aW9uZWQgaW4gY29tbWl0Cj4gPiA+IG1lc3NhZ2UsIHRoZSBDU1IgbW9kdWxl IGlzIGEgY2hpbGQgbm9kZSBvZiBhIHNpbXBsZSBwb3dlci1tYW5hZ2VkCj4gPiA+IGJ1cyhpLk1Y OHF4cCBwaXhlbCBsaW5rIE1TSSBidXMpLCB3aGljaCBtZWFucyB0aGUgY2hpbGQgZGV2aWNlcyBv ZiB0aGUKPiA+ID4gQ1NSIG1vZHVsZShhcyBhIHNpbXBsZS1tZmQgZGV2aWNlKSB3b24ndCBiZSBw b3B1bGF0ZWQgYnkKPiA+ID4gb2ZfcGxhdGZvcm1fZGVmYXVsdF9wb3B1bGF0ZSgpIGZyb20gb2Zf cGxhdGZvcm1fZGVmYXVsdF9wb3B1bGF0ZV9pbml0KCkKPiA+ID4gYmVjYXVzZSAic2ltcGxlLXBt LWJ1cyIgaXMgbm90IGxpc3RlZCBpbiBvZl9kZWZhdWx0X2J1c19tYXRjaF90YWJsZVtdCj4gPiA+ IGFuZCBoZW5jZSByZWN1cnNpb24gb2Ygb2ZfcGxhdGZvcm1fYnVzX2NyZWF0ZSgpIHdpbGwgc3Rv cCBhdCB0aGUKPiA+ID4gc2ltcGxlLXBtLWJ1cy4gVGhpcyBpcyBhbHNvIGEgcmVhc29uIHdoeSBh IGRlZGljYXRlZCBmc2wtaW14OHF4cC1jc3IKPiA+ID4gZHJpdmVyIGlzIG5lZWRlZCB0byBwb3B1 bGF0ZWQgdGhvc2UgY2hpbGQgZGV2aWNlcyBvZiB0aGUgQ1NSIG1vZHVsZS4KPiA+IAo+ID4gTm90 IHN1cmUgSSBrbm93IHRoZSBzZW1hbnRpY3Mgd2VsbCBlbm91Z2ggKGFueW1vcmUpIHRvIGdldCBh Cj4gPiBtZWFuaW5nZnVsIHBpY3R1cmUgb2Ygd2hhdCB5b3UncmUgdHJ5aW5nIHRvIGV4cGxhaW4s IGFuZCBJIGRvIG5vdCBoYXZlCj4gPiBhbnkgc3VpdGFibGUgSC9XIGhlcmUgdG8gbW9jay11cCBh IHJlYWwtd29ybGQgdGVzdC1iZWQgLyBjb25jZXB0Cj4gPiBkZW1vbnN0cmF0b3IgdG8gZGVidWcg dGhpcyBmb3IgeW91Lgo+IAo+IEkgdW5kZXJzdGFuZCB5b3UgaGF2ZSBubyBoYXJkd2FyZSB0byBk ZWJ1ZyB0aGlzIGRpcmVjdGx5LiAgQnV0LCB0aGUKPiBleGFtcGxlIGluIGR0LWJpbmRpbmcgZG9j IGZvciB0aGUgaS5NWDhxeHAgcGl4ZWwgbGluayBNU0kgYnVzKGEgc2ltcGxlLQo+IHBtLWJ1cykg bWF5IGdpdmUgeW91IGEga2luZGEgZnVsbCBwaWN0dXJlIG9mIHdoYXQgdGhlIHJlbGV2YW50IGRl dmljZXMKPiBsb29rIGxpa2UuICBJIG1lbnRpb25lZCB0aGUgcGF0Y2ggc2V0IHRvIGFkZCB0aGUg TVNJIGJ1cyBwcmV2aW91c2x5LAo+IGhvd2V2ZXIsIHlvdSBtYXkgZmluZCB0aGUgYmluZGluZyBk b2MgZGlyZWN0bHkgaGVyZSAtCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC8yMDIyMTAx NzA3NDAzOS40MTgxODQzLTMtdmljdG9yLmxpdUBueHAuY29tLwo+IAo+ID4gCj4gPiBUaGUgbG9u ZyBhbmQgdGhlIHNob3J0IG9mIGl0IGlzOyB3ZSBoYXZlIGEgYnVuY2ggb2YgYXV0b21hdGljCj4g PiBjaGlsZC1kZXZpY2UtcmVnaXN0ZXJpbmcgaGVscGVycyBpbiB0aGUga2VybmVsLiAgT25lIG9m IHRoZSBtZWNoYW5pc21zCj4gPiBpcyBib3VuZCB0byB3b3JrIGZvciB5b3UgaWYgeW91IHN0cnVj dHVyZSB5b3VyIGNvZGUgYXBwcm9wcmlhdGVseS4KPiA+IAo+ID4gSW50cm9kdWNpbmcgYW4gZW1w dHksIG1lYW5pbmdsZXNzIGRyaXZlciwgc2ltcGx5IHRvIGNhbGwgYSBzaW5nbGUKPiA+IGZ1bmN0 aW9uIGl0IG5vdCBhY2NlcHRhYmxlLiAgUGxlYXNlIG1ha2UgdGhlIGluZnJhc3RydWN0dXJlIGFs cmVhZHkKPiA+IG9mZmVyZWQgc3BlY2lmaWNhbGx5IHRvIHNvbHZlIHRoaXMgY2F0ZWdvcnkgb2Yg aXNzdWUgd29yayBmb3IgeW91cgo+ID4gdXNlLWNhc2UuCj4gCj4gWWVhaCwgSSB0cmllZCB0byBu b3QgdG8gaW50cm9kdWNlIGEgbmV3IGRyaXZlciBmb3IgdGhlIENTUiBtb2R1bGUsIGJ1dAo+IGl0 IHNlZW1zIHRoYXQgaXQgaXMgbmVlZGVkLgoKSXQncyBub3QuIDopCgotLSAKTGVlIEpvbmVzIFvm nY7nkLzmlq9dCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3873EC433FE for ; Mon, 14 Nov 2022 10:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237012AbiKNKFF (ORCPT ); Mon, 14 Nov 2022 05:05:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237071AbiKNKEn (ORCPT ); Mon, 14 Nov 2022 05:04:43 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20C9B1260C; Mon, 14 Nov 2022 02:01:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A2100B80DA2; Mon, 14 Nov 2022 10:01:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B6D0C433D6; Mon, 14 Nov 2022 10:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668420113; bh=0AWDgj8YRiMgi+RCQmhjPkOW5dw2tU+daCdk+KQy8U8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uiw0du2Mn3DKr94KgOc6lFzKfMp0U0UJWL9mUM2a89p4q+S8FvSsFFihv+vNk+RFl ADaK7pe4lGb0pD9+FOqBNtQPwWL54XYGppMM6lsBEYvtQul0FGn9xf7+u12Cydh6aQ xas6VneccrgIZlzJ7mZRDAH+NV/d+WnxMlQQyjkO9spZFjtAg445WC6ZM4IB7fWP4J 5pFXgmm4MkFnkdhtriiNxNUWVfrbg5iC812Ly7flrLFNcz436eNQaSDGJLORpwlnZl hHeHRQ3IZqgu1p6U/zyZJD3AkFphUDVmaO0HCghcgUoR0sBhOjKnW6xKvWNC2KBOb/ 8fonfWtvLMKWQ== Date: Mon, 14 Nov 2022 10:01:47 +0000 From: Lee Jones To: Liu Ying Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org Subject: Re: [PATCH RESEND] mfd: Add Freescale i.MX8qxp Control and Status Registers (CSR) module driver Message-ID: References: <20221017075702.4182846-1-victor.liu@nxp.com> <4dfb7699c33974a682d798071c85b431b87e5432.camel@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4dfb7699c33974a682d798071c85b431b87e5432.camel@nxp.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 08 Nov 2022, Liu Ying wrote: > Hi Lee, > > On Mon, 2022-11-07 at 09:05 +0000, Lee Jones wrote: > > On Wed, 02 Nov 2022, Liu Ying wrote: > > > > > Hi Lee, > > > > > > On Tue, 2022-11-01 at 13:53 +0800, Liu Ying wrote: > > > > Hi Lee, > > > > > > > > On Mon, 2022-10-31 at 15:40 +0000, Lee Jones wrote: > > > > > On Mon, 17 Oct 2022, Liu Ying wrote: > > > > > > > > > > > Freescale i.MX8qxp Control and Status Registers (CSR) module is a > > > > > > system > > > > > > controller. It represents a set of miscellaneous registers of a > > > > > > specific > > > > > > subsystem. It may provide control and/or status report interfaces > > > > > > to a > > > > > > mix of standalone hardware devices within that subsystem. > > > > > > > > > > > > The CSR module in i.MX8qm/qxp SoCs is a child node of a simple > > > > > > power-managed > > > > > > bus(i.MX8qxp pixel link MSI bus). To propagate power management > > > > > > operations > > > > > > of the CSR module's child devices to that simple power-managed > > > > > > bus, add a > > > > > > dedicated driver for the CSR module. Also, the driver would > > > > > > populate the CSR > > > > > > module's child devices. > > > > > > > > > > > > Signed-off-by: Liu Ying > > > > > > --- > > > > > > The Freescale i.MX8qxp CSR DT bindings is at > > > > > > Documentation/devicetree/bindings/mfd/fsl,imx8qxp-csr.yaml. > > > > > > > > > > > > Resend the patch based on v6.1-rc1. > > > > > > > > > > > > drivers/mfd/Kconfig | 10 +++++++ > > > > > > drivers/mfd/Makefile | 1 + > > > > > > drivers/mfd/fsl-imx8qxp-csr.c | 53 > > > > > > +++++++++++++++++++++++++++++++++++ > > > > > > 3 files changed, 64 insertions(+) > > > > > > create mode 100644 drivers/mfd/fsl-imx8qxp-csr.c > > > > > > > > [...] > > > > > > > > > > diff --git a/drivers/mfd/fsl-imx8qxp-csr.c b/drivers/mfd/fsl- > > > > > > imx8qxp-csr.c > > > > > > new file mode 100644 > > > > > > index 000000000000..3915d3d6ca65 > > > > > > --- /dev/null > > > > > > +++ b/drivers/mfd/fsl-imx8qxp-csr.c > > > > > > @@ -0,0 +1,53 @@ > > > > > > +// SPDX-License-Identifier: GPL-2.0+ > > > > > > + > > > > > > +/* > > > > > > + * Copyright 2022 NXP > > > > > > + */ > > > > > > + > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > + > > > > > > +static int imx8qxp_csr_probe(struct platform_device *pdev) > > > > > > +{ > > > > > > + int ret; > > > > > > + > > > > > > + pm_runtime_enable(&pdev->dev); > > > > > > + > > > > > > + ret = devm_of_platform_populate(&pdev->dev); > > > > > > > > > > The use of this API does not constitute a MFD. > > > > > > > > > > Please use "simple-mfd" instead. > > > > > > > > simple-mfd devices have "ONLY_BUS" set in simple-pm-bus.c, so the > > > > simple-pm-bus driver would not populate child devices of simple-mfd > > > > devices. > > > > Right, simple-pm-bus will not populate child devices, because: > > simple-pm-bus.c may populate child devices of simple-pm-bus devices > because "ONLY_BUS" is _not_ set for simple-pm-bus devices. > > simple-pm-bus.c would _not_ populate child devices of simple-mfd > devices because "ONLY_BUS" is set for simple-mfd devices. > > > > > /* > > * These are transparent bus devices (not simple-pm-bus matches) that > > * have their child nodes populated automatically. So, don't need to > > * do anything more. We only match with the device if this driver is > > * the most specific match because we don't want to incorrectly bind to > > * a device that has a more specific driver. > > */ > > > > So "simple-mfd" must be populated elsewhere i.e. drivers/of/platform.c. > > If simple-mfd device is a child device of one device listed in > of_default_bus_match_table[], then it may be populated by > drivers/of/platform.c. But, in my case, simple-mfd device is a child > device of simple-pm-bus device(not listed in that table), so it will > not be populated by drivers/of/platform.c. Instead, > drivers/bus/simple-pm-bus.c would populate the simple-mfd device. > > > > > > > Also, the simple-pm-bus driver would not enable runtime > > > > power management for simple-mfd devices due to "ONLY_BUS", which > > > > means it would not propagate power management operations from child > > > > devices of simple-mfd devices to parent devices of simple-mfd > > > > devices. That's why a dedicated fsl-imx8qxp-csr driver is needed. > > > > This is more of an issue. > > > > Why can't this device use "simple-pm-bus" to have support for both > > auto-registration AND Runtime PM? > > If I change the compatible string of the CSR module from > "fsl,imx8qxp-mipi-lvds-csr", "syscon", "simple-mfd" > to > "fsl,imx8qxp-mipi-lvds-csr", "syscon", "simple-pm-bus", > all devices I'm interested in are populated and all relevant drivers > can probe. Okay, that's good. > But, this change makes 'make dt_binding_check' for the > existing fsl,imx8qxp-csr.yaml fail: > > --------------------------------8<------------------------------------ > /kernel/linux/Documentation/devicetree/bindings/mfd/fsl,imx8qxp- > csr.example.dtb: syscon@56221000: $nodename:0: 'syscon@56221000' does > not match '^bus(@[0-9a-f]+)?$' > From schema: > /kernel/linux/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml > /kernel/linux/Documentation/devicetree/bindings/mfd/fsl,imx8qxp- > csr.example.dtb: syscon@56221000: '#address-cells' is a required > property > From schema: > /kernel/linux/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml > /kernel/linux/Documentation/devicetree/bindings/mfd/fsl,imx8qxp- > csr.example.dtb: syscon@56221000: '#size-cells' is a required property > From schema: > /kernel/linux/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml > /kernel/linux/Documentation/devicetree/bindings/mfd/fsl,imx8qxp- > csr.example.dtb: syscon@56221000: 'ranges' is a required property > From schema: > /kernel/linux/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml > --------------------------------8<------------------------------------ > > The error log basically complains two things: > 1) The example nodename 'syscon@56221000' should match > '^bus(@[0-9a-f]+)?$'. > 2) Missing '#address-cells', '#size-cells' and 'ranges' properties as > required by simple-pm-bus. > > Regarding 1), if I change 'syscon@56221000' to 'bus@56221000', then the > below error comes along: > --------------------------------8<------------------------------------ > /kernel/linux/Documentation/devicetree/bindings/mfd/fsl,imx8qxp- > csr.example.dtb: bus@56221000: $nodename:0: 'bus@56221000' does not > match '^syscon@[0-9a-f]+$' > From schema: > /kernel/linux/Documentation/devicetree/bindings/mfd/fsl,imx8qxp- > csr.yaml > --------------------------------8<------------------------------------ > So, it looks like "syscon" and "simple-pm-bus" can not be in compatbile > string at the same time. Note that "syscon" is needed because other > device nodes may reference the CSR module through a phandle, like the > "fsl,imx8qxp-mipi-dphy" device. > > Regarding 2), I may try to add those required properties, but it would > break the existing schemas of the child devices of the CSR module, like > the "fsl,imx8qxp-ldb" device, because "reg" property is not allowed. > > So, it looks like the CSR module still should be simple-mfd device but > not simple-pm-bus device, right? It sounds like the generic auto-probing functionality provided by the kernel works well to give you with a fully self-registering mechanism. All you need to do now is figure out why the DT checker is not happy with your solution. Please work with the Device Tree maintainers on this. > > > One more point which might be overlooked - as mentioned in commit > > > message, the CSR module is a child node of a simple power-managed > > > bus(i.MX8qxp pixel link MSI bus), which means the child devices of the > > > CSR module(as a simple-mfd device) won't be populated by > > > of_platform_default_populate() from of_platform_default_populate_init() > > > because "simple-pm-bus" is not listed in of_default_bus_match_table[] > > > and hence recursion of of_platform_bus_create() will stop at the > > > simple-pm-bus. This is also a reason why a dedicated fsl-imx8qxp-csr > > > driver is needed to populated those child devices of the CSR module. > > > > Not sure I know the semantics well enough (anymore) to get a > > meaningful picture of what you're trying to explain, and I do not have > > any suitable H/W here to mock-up a real-world test-bed / concept > > demonstrator to debug this for you. > > I understand you have no hardware to debug this directly. But, the > example in dt-binding doc for the i.MX8qxp pixel link MSI bus(a simple- > pm-bus) may give you a kinda full picture of what the relevant devices > look like. I mentioned the patch set to add the MSI bus previously, > however, you may find the binding doc directly here - > https://lore.kernel.org/lkml/20221017074039.4181843-3-victor.liu@nxp.com/ > > > > > The long and the short of it is; we have a bunch of automatic > > child-device-registering helpers in the kernel. One of the mechanisms > > is bound to work for you if you structure your code appropriately. > > > > Introducing an empty, meaningless driver, simply to call a single > > function it not acceptable. Please make the infrastructure already > > offered specifically to solve this category of issue work for your > > use-case. > > Yeah, I tried to not to introduce a new driver for the CSR module, but > it seems that it is needed. It's not. :) -- Lee Jones [李琼斯]