From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Alexandru Tachici <alexandru.tachici@analog.com>
Cc: linux-kernel@vger.kernel.org, andrew@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
steve.glendinning@shawell.net, UNGLinuxDriver@microchip.com,
andre.edich@microchip.com, linux-usb@vger.kernel.org
Subject: Re: [net] net: usb: smsc95xx: fix external PHY reset
Date: Mon, 14 Nov 2022 11:31:52 +0000 [thread overview]
Message-ID: <Y3InKCr9BGaf8wiI@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221114131643.19450-1-alexandru.tachici@analog.com>
On Mon, Nov 14, 2022 at 03:16:43PM +0200, Alexandru Tachici wrote:
> + } else {
> + /* Driver has no knowledge at this point about the external PHY.
> + * The 802.3 specifies that the reset process shall
> + * be completed within 0.5 s.
> + */
> + fsleep(500000);
> + }
It's slightly more code, but would it be better to do this in the
mdiobus reset() method?
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-11-14 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 13:16 [net] net: usb: smsc95xx: fix external PHY reset Alexandru Tachici
2022-11-14 11:31 ` Russell King (Oracle) [this message]
2022-11-14 11:43 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3InKCr9BGaf8wiI@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandru.tachici@analog.com \
--cc=andre.edich@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.