From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ian Cowan <ian@linux.cowan.aero>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: omap4iss: correct cacheflush import
Date: Mon, 14 Nov 2022 16:06:50 +0200 [thread overview]
Message-ID: <Y3JLenvvuRhb0xfZ@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221113003347.93483-1-ian@linux.cowan.aero>
Hi Ian,
Thank you for the patch.
On Sat, Nov 12, 2022 at 07:33:47PM -0500, Ian Cowan wrote:
> Correct the import for cacheflush from the asm directory to the linux
> directory.
Unless I'm mistaken, it looks like the header is actually not needed at
all.
> Signed-off-by: Ian Cowan <ian@linux.cowan.aero>
> ---
> drivers/staging/media/omap4iss/iss_video.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c
> index 842509dcfedf..9f08dd976a24 100644
> --- a/drivers/staging/media/omap4iss/iss_video.c
> +++ b/drivers/staging/media/omap4iss/iss_video.c
> @@ -7,6 +7,7 @@
> * Author: Sergio Aguirre <sergio.a.aguirre@gmail.com>
> */
>
> +#include <linux/cacheflush.h>
> #include <linux/clk.h>
> #include <linux/mm.h>
> #include <linux/pagemap.h>
> @@ -19,8 +20,6 @@
> #include <media/v4l2-ioctl.h>
> #include <media/v4l2-mc.h>
>
> -#include <asm/cacheflush.h>
> -
> #include "iss_video.h"
> #include "iss.h"
>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-11-14 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 0:33 [PATCH] staging: media: omap4iss: correct cacheflush import Ian Cowan
2022-11-14 14:06 ` Laurent Pinchart [this message]
2022-11-14 16:06 ` Ian Cowan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3JLenvvuRhb0xfZ@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=gregkh@linuxfoundation.org \
--cc=ian@linux.cowan.aero \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.