From: Mike Kravetz <mike.kravetz@oracle.com>
To: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: Greg KH <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Yang Shi <shy828301@gmail.com>,
James Houghton <jthoughton@google.com>,
Muchun Song <songmuchun@bytedance.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Naoya Horiguchi <naoya.horiguchi@nec.com>
Subject: Re: hwpoison, shmem: fix data lost issue for 5.15.y
Date: Mon, 14 Nov 2022 14:53:51 -0800 [thread overview]
Message-ID: <Y3LG/+wWSSj6ZYzl@monkey> (raw)
In-Reply-To: <20221114223900.GA3883066@u2004>
On 11/15/22 07:39, Naoya Horiguchi wrote:
> On Mon, Nov 14, 2022 at 05:11:35PM +0100, Greg KH wrote:
> > On Mon, Nov 14, 2022 at 10:14:03PM +0900, Naoya Horiguchi wrote:
> > > Hi,
> > >
> > > I'd like to request the follow commits to be backported to 5.15.y.
> > >
> > > - dd0f230a0a80 ("mm: hwpoison: refactor refcount check handling")
> > > - 4966455d9100 ("mm: hwpoison: handle non-anonymous THP correctly")
> > > - a76054266661 ("mm: shmem: don't truncate page if memory failure happens")
> > >
> > > These patches fixed a data lost issue by preventing shmem pagecache from
> > > being removed by memory error. These were not tagged for stable originally,
> > > but that's revisited recently.
> >
> > And have you tested that these all apply properly (and in which order?)
>
> Yes, I've checked that these cleanly apply (without any change) on
> 5.15.78 in the above order (i.e. dd0f23 is first, 496645 comes next,
> then a76054).
>
> > and work correctly?
>
> Yes, I ran related testcases in my test suite, and their status changed
> FAIL to PASS with these patches.
Hi Naoya,
Just curious if you have plans to do backports for earlier releases?
If not, I can start that effort. We have seen data loss/corruption because of
this on a 4.14 based release. So, I would go at least that far back.
--
Mike Kravetz
next prev parent reply other threads:[~2022-11-14 22:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 13:14 hwpoison, shmem: fix data lost issue for 5.15.y Naoya Horiguchi
2022-11-14 16:11 ` Greg KH
2022-11-14 22:39 ` Naoya Horiguchi
2022-11-14 22:53 ` Mike Kravetz [this message]
2022-11-15 1:16 ` HORIGUCHI NAOYA(堀口 直也)
2022-11-15 1:30 ` Mike Kravetz
2022-11-15 6:39 ` Naoya Horiguchi
2022-11-16 3:48 ` Mike Kravetz
2022-11-16 23:58 ` Naoya Horiguchi
2022-11-23 1:05 ` Mike Kravetz
2022-11-23 18:54 ` Yang Shi
2022-11-24 3:03 ` Naoya Horiguchi
2022-11-16 9:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3LG/+wWSSj6ZYzl@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jthoughton@google.com \
--cc=linmiaohe@huawei.com \
--cc=naoya.horiguchi@linux.dev \
--cc=naoya.horiguchi@nec.com \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.