From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00C3CC4332F for ; Tue, 15 Nov 2022 11:43:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230001AbiKOLnv (ORCPT ); Tue, 15 Nov 2022 06:43:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229879AbiKOLnt (ORCPT ); Tue, 15 Nov 2022 06:43:49 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D7CD2529A; Tue, 15 Nov 2022 03:43:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668512628; x=1700048628; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JO33YPL4NpCf+QtbSvBLune4D/6KvXp403nfS2tAN/c=; b=icX/gImr8kWPZJO6apmqT/0DpRGBYkTIwC8ZYBCIuF4B88ibUMHvXP7s PbAuvdNIL3CelM9JOLcidsdKI6t9NjDgI+qFZPxLUzgqFsFxuNAJplpNV h8oXxuN3ZgM/CoeZ3wmlWMdeH/ag4AY+M95+dhAboxnlY2bDTtyNPxqoG YQDxGtBgLZGXoei90MgswDI6l0ZC0y1LlY6U5xMdWkNhV0y967y5JB3FN oMNNpZw/cc4TgZjgRrbYDHSD12NcgzEt1qGt8Qjpf7H0B852vvVKknGhO a8OU/ZIwnW+T0fEoPQdQ5VhrRzZnI9hpsWAe3+SShcZrKWCI1DZ3QWdRR A==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="374365168" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="374365168" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2022 03:43:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="633206267" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="633206267" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 15 Nov 2022 03:43:43 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ouuLt-00Cb7Y-03; Tue, 15 Nov 2022 13:43:41 +0200 Date: Tue, 15 Nov 2022 13:43:40 +0200 From: Andy Shevchenko To: Andrew Davis Cc: Shawn Guo , Li Yang , Sascha Hauer , Rob Herring , Krzysztof Kozlowski , Nishanth Menon , Vignesh Raghavendra , Masahiro Yamada , Michal Marek , Nick Desaulniers , Geert Uytterhoeven , Frank Rowand , devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kbuild: Cleanup DT Overlay intermediate files as appropriate Message-ID: References: <20221114205939.27994-1-afd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114205939.27994-1-afd@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Mon, Nov 14, 2022 at 02:59:39PM -0600, Andrew Davis wrote: > %.dtbo.o and %.dtbo.S files are used to build-in DT Overlay. They should > should not be removed by Make or the kernel will be needlessly rebuilt. > > These should be removed by "clean" and ignored by git like other > intermediate files. Fixes: 941214a512d8 ("kbuild: Allow DTB overlays to built into .dtbo.S files") Tested-by: Andy Shevchenko > Reported-by: Andy Shevchenko > Signed-off-by: Andrew Davis > --- > .gitignore | 1 + > Makefile | 4 +++- > scripts/Makefile.build | 2 ++ > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/.gitignore b/.gitignore > index 5da004814678d..3ec73ead6757e 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -20,6 +20,7 @@ > *.dtb > *.dtbo > *.dtb.S > +*.dtbo.S > *.dwo > *.elf > *.gcno > diff --git a/Makefile b/Makefile > index 3735d5996c637..0dd7e8d022289 100644 > --- a/Makefile > +++ b/Makefile > @@ -2003,7 +2003,9 @@ clean: $(clean-dirs) > @find $(or $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \ > \( -name '*.[aios]' -o -name '*.rsi' -o -name '*.ko' -o -name '.*.cmd' \ > -o -name '*.ko.*' \ > - -o -name '*.dtb' -o -name '*.dtbo' -o -name '*.dtb.S' -o -name '*.dt.yaml' \ > + -o -name '*.dtb' -o -name '*.dtbo' \ > + -o -name '*.dtb.S' -o -name '*.dtbo.S' \ > + -o -name '*.dt.yaml' \ > -o -name '*.dwo' -o -name '*.lst' \ > -o -name '*.su' -o -name '*.mod' -o -name '*.usyms' \ > -o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \ > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index 41f3602fc8de7..3ceab076127b7 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -468,10 +468,12 @@ intermediate_targets = $(foreach sfx, $(2), \ > $(filter %$(strip $(1)), $(targets)))) > # %.asn1.o <- %.asn1.[ch] <- %.asn1 > # %.dtb.o <- %.dtb.S <- %.dtb <- %.dts > +# %.dtbo.o <- %.dtbo.S <- %.dtbo <- %.dtso > # %.lex.o <- %.lex.c <- %.l > # %.tab.o <- %.tab.[ch] <- %.y > targets += $(call intermediate_targets, .asn1.o, .asn1.c .asn1.h) \ > $(call intermediate_targets, .dtb.o, .dtb.S .dtb) \ > + $(call intermediate_targets, .dtbo.o, .dtbo.S .dtbo) \ > $(call intermediate_targets, .lex.o, .lex.c) \ > $(call intermediate_targets, .tab.o, .tab.c .tab.h) > > -- > 2.38.1 > -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A829C4332F for ; Tue, 15 Nov 2022 11:44:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JhaRrGa+6XJjWmf2PyHtgKUtlIFwn/trrQpt+H56qvU=; b=k0jMBDpypjrZtO n2o1BPQKFDS/6iMBzsjin/OariWsH+DAGQxKL9v6JRkXBH4l67h12hs4osgPFFC7mr33HYKkyTLMc pkQdubzgA+n68gduNsWrnmIM9RSpMLTM5s4ZviHfa7juYYgheJTdRsqA1K/NYT84t013pdlIkNrxs oUeRYBGfc5slhSWhjCL+oXpQgFMklCNJUgHXIiMt+udlb1FypXjXNJJOxtNnPfcOFZ6ZJbB/wQOiv H3hJd08hy5ZoQOMwrMVdhAg6EaQS+AnwVd0Dr51SmqXFhnQcgQQVIVJMBG5GbYElafqCeGtlLaR/X sgS870JMMOqs0ucG3PnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouuM6-00Ago6-QG; Tue, 15 Nov 2022 11:43:54 +0000 Received: from mga05.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouuM4-00Aglg-0e for linux-arm-kernel@lists.infradead.org; Tue, 15 Nov 2022 11:43:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668512631; x=1700048631; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JO33YPL4NpCf+QtbSvBLune4D/6KvXp403nfS2tAN/c=; b=P7DkEJ4BLKz71VSMoP3buhOlpPYFXNkoXWfHCxAht6Ry1xahUqFHLtYu euqkY5GSn7vvZ6Dn5IVlN/TuxTRugZeOkzxfdWr81wklAJJqyWNY4V1sK Fz2HoosmOVDcKL0FM3ceHi0V46krK3cjp1wLFQfz26mpLT68qILFd8C2L C2Xy3pKX/mn5mwnBzCHc9hZlE/Y2L5xai7gqWZyvr7SKgzix10ou/n+jh /dE2WHcj5iZBbivKPp1KTfFhWSGn1YRCN4FBXDekgzhDU6xgX9sU1nOpc XS3pOTnGxD2jDPX5jBnIayxN4lrfdsHP6JZg2e2lz89CvEyfsJTi2tfCu g==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="398521520" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="398521520" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2022 03:43:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="633206267" X-IronPort-AV: E=Sophos;i="5.96,165,1665471600"; d="scan'208";a="633206267" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 15 Nov 2022 03:43:43 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ouuLt-00Cb7Y-03; Tue, 15 Nov 2022 13:43:41 +0200 Date: Tue, 15 Nov 2022 13:43:40 +0200 From: Andy Shevchenko To: Andrew Davis Cc: Shawn Guo , Li Yang , Sascha Hauer , Rob Herring , Krzysztof Kozlowski , Nishanth Menon , Vignesh Raghavendra , Masahiro Yamada , Michal Marek , Nick Desaulniers , Geert Uytterhoeven , Frank Rowand , devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kbuild: Cleanup DT Overlay intermediate files as appropriate Message-ID: References: <20221114205939.27994-1-afd@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221114205939.27994-1-afd@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_034352_087055_4842E2F1 X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 14, 2022 at 02:59:39PM -0600, Andrew Davis wrote: > %.dtbo.o and %.dtbo.S files are used to build-in DT Overlay. They should > should not be removed by Make or the kernel will be needlessly rebuilt. > > These should be removed by "clean" and ignored by git like other > intermediate files. Fixes: 941214a512d8 ("kbuild: Allow DTB overlays to built into .dtbo.S files") Tested-by: Andy Shevchenko > Reported-by: Andy Shevchenko > Signed-off-by: Andrew Davis > --- > .gitignore | 1 + > Makefile | 4 +++- > scripts/Makefile.build | 2 ++ > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/.gitignore b/.gitignore > index 5da004814678d..3ec73ead6757e 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -20,6 +20,7 @@ > *.dtb > *.dtbo > *.dtb.S > +*.dtbo.S > *.dwo > *.elf > *.gcno > diff --git a/Makefile b/Makefile > index 3735d5996c637..0dd7e8d022289 100644 > --- a/Makefile > +++ b/Makefile > @@ -2003,7 +2003,9 @@ clean: $(clean-dirs) > @find $(or $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \ > \( -name '*.[aios]' -o -name '*.rsi' -o -name '*.ko' -o -name '.*.cmd' \ > -o -name '*.ko.*' \ > - -o -name '*.dtb' -o -name '*.dtbo' -o -name '*.dtb.S' -o -name '*.dt.yaml' \ > + -o -name '*.dtb' -o -name '*.dtbo' \ > + -o -name '*.dtb.S' -o -name '*.dtbo.S' \ > + -o -name '*.dt.yaml' \ > -o -name '*.dwo' -o -name '*.lst' \ > -o -name '*.su' -o -name '*.mod' -o -name '*.usyms' \ > -o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \ > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index 41f3602fc8de7..3ceab076127b7 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -468,10 +468,12 @@ intermediate_targets = $(foreach sfx, $(2), \ > $(filter %$(strip $(1)), $(targets)))) > # %.asn1.o <- %.asn1.[ch] <- %.asn1 > # %.dtb.o <- %.dtb.S <- %.dtb <- %.dts > +# %.dtbo.o <- %.dtbo.S <- %.dtbo <- %.dtso > # %.lex.o <- %.lex.c <- %.l > # %.tab.o <- %.tab.[ch] <- %.y > targets += $(call intermediate_targets, .asn1.o, .asn1.c .asn1.h) \ > $(call intermediate_targets, .dtb.o, .dtb.S .dtb) \ > + $(call intermediate_targets, .dtbo.o, .dtbo.S .dtbo) \ > $(call intermediate_targets, .lex.o, .lex.c) \ > $(call intermediate_targets, .tab.o, .tab.c .tab.h) > > -- > 2.38.1 > -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel