From: Andrew Lunn <andrew@lunn.ch>
To: Hui Tang <tanghui20@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
mw@semihalf.com, linux@armlinux.org.uk, leon@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
yusongping@huawei.com
Subject: Re: [PATCH net v2] net: mvpp2: fix possible invalid pointer dereference
Date: Tue, 15 Nov 2022 16:50:47 +0100 [thread overview]
Message-ID: <Y3O1V4FAACa9Ed9S@lunn.ch> (raw)
In-Reply-To: <20221115090433.232165-1-tanghui20@huawei.com>
On Tue, Nov 15, 2022 at 05:04:33PM +0800, Hui Tang wrote:
> It will cause invalid pointer dereference to priv->cm3_base behind,
> if PTR_ERR(priv->cm3_base) in mvpp2_get_sram().
As i pointed out for the MDIO driver, i wonder if this is the correct
fix. mvpp2_get_sram() is probably a better place to handle this
In fact, please add a devm_ioremap_resource_optional() which returns
NULL if the resource does not exist, or an error code for real errors,
and make drivers fail the probe on real errors.
Andrew
next prev parent reply other threads:[~2022-11-15 15:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 9:04 [PATCH net v2] net: mvpp2: fix possible invalid pointer dereference Hui Tang
2022-11-15 9:16 ` Marcin Wojtas
2022-11-15 15:50 ` Andrew Lunn [this message]
2022-11-16 2:06 ` [PATCH net v3] " Hui Tang
2022-11-16 2:14 ` [PATCH net v4] " Hui Tang
2022-11-16 4:28 ` Jakub Kicinski
2022-11-16 6:13 ` Hui Tang
2022-11-16 13:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3O1V4FAACa9Ed9S@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=tanghui20@huawei.com \
--cc=yusongping@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.