diff for duplicates of <Y3P0rAjywL1a7Pme@google.com> diff --git a/a/1.txt b/N1/1.txt index 4a2bf30..9d9e390 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,9 +3,9 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote: > > > > @@ -9283,7 +9283,13 @@ static int > > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops) -> > > > ? int cpu = smp_processor_id(); -> > > > ? struct cpuinfo_x86 *c = &cpu_data(cpu); -> > > > ? +> > > > int cpu = smp_processor_id(); +> > > > struct cpuinfo_x86 *c = &cpu_data(cpu); +> > > > > > > > - WARN_ON(!irqs_disabled()); > > > > + /* > > > > + * Compatibility checks are done when loading KVM and when enabling @@ -15,7 +15,7 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > > > + * an offline CPU. > > > > + */ > > > > + WARN_ON(!irqs_disabled() && cpu_active(cpu)); -> > > > ? +> > > > > > > > > > Also, the logic of: > > > @@ -28,7 +28,7 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > > the IRQ is indeed disabled. > > > > > > But this doesn't make sense anymore after we move to ONLINE section, in which -> > > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON() +> > > IRQ has already been enabled (see start_secondary()). IIUC the WARN_ON() > > > doesn't get exploded is purely because there's an additional cpu_active(cpu) > > > check. > > > @@ -59,3 +59,7 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: Grr, but not routing through this helper is flawed in that KVM doesn't do the CR4 checks in the hardware enabling case. Don't think that changes the WARN, but other patches in this series need tweaks. +_______________________________________________ +kvmarm mailing list +kvmarm@lists.cs.columbia.edu +https://lists.cs.columbia.edu/mailman/listinfo/kvmarm diff --git a/a/content_digest b/N1/content_digest index 2a65fc8..643d904 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,9 +4,44 @@ "ref\0b198fe971cecd301f0c7c66028cfd71dd7ba7e62.camel@intel.com\0" "ref\0Y3PzhANShVlTXVg1@google.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" + "Subject\0Re: [PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" "Date\0Tue, 15 Nov 2022 20:21:00 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Huang" + " Kai <kai.huang@intel.com>\0" + "Cc\0mjrosato@linux.ibm.com <mjrosato@linux.ibm.com>" + david@redhat.com <david@redhat.com> + Yao + Yuan <yuan.yao@intel.com> + paul.walmsley@sifive.com <paul.walmsley@sifive.com> + linux-mips@vger.kernel.org <linux-mips@vger.kernel.org> + mpe@ellerman.id.au <mpe@ellerman.id.au> + linux-riscv@lists.infradead.org <linux-riscv@lists.infradead.org> + imbrenda@linux.ibm.com <imbrenda@linux.ibm.com> + kvmarm@lists.cs.columbia.edu <kvmarm@lists.cs.columbia.edu> + linux-s390@vger.kernel.org <linux-s390@vger.kernel.org> + frankja@linux.ibm.com <frankja@linux.ibm.com> + maz@kernel.org <maz@kernel.org> + chenhuacai@kernel.org <chenhuacai@kernel.org> + aleksandar.qemu.devel@gmail.com <aleksandar.qemu.devel@gmail.com> + borntraeger@linux.ibm.com <borntraeger@linux.ibm.com> + Gao + Chao <chao.gao@intel.com> + farman@linux.ibm.com <farman@linux.ibm.com> + aou@eecs.berkeley.edu <aou@eecs.berkeley.edu> + kvm@vger.kernel.org <kvm@vger.kernel.org> + atishp@atishpatra.org <atishp@atishpatra.org> + kvmarm@lists.linux.dev <kvmarm@lists.linux.dev> + tglx@linutronix.de <tglx@linutronix.de> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + Yamahata + Isaku <isaku.yamahata@intel.com> + farosas@linux.ibm.com <farosas@linux.ibm.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + palmer@dabbelt.com <palmer@dabbelt.com> + kvm-riscv@lists.infradead.org <kvm-riscv@lists.infradead.org> + pbonzini@redhat.com <pbonzini@redhat.com> + vkuznets@redhat.com <vkuznets@redhat.com> + " linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On Tue, Nov 15, 2022, Sean Christopherson wrote:\n" @@ -14,9 +49,9 @@ "> > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote:\n" "> > > > @@ -9283,7 +9283,13 @@ static int\n" "> > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops)\n" - "> > > > ?\tint cpu = smp_processor_id();\n" - "> > > > ?\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" - "> > > > ?\n" + "> > > > \302\240\tint cpu = smp_processor_id();\n" + "> > > > \302\240\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" + "> > > > \302\240\n" "> > > > -\tWARN_ON(!irqs_disabled());\n" "> > > > +\t/*\n" "> > > > +\t * Compatibility checks are done when loading KVM and when enabling\n" @@ -26,7 +61,7 @@ "> > > > +\t * an offline CPU.\n" "> > > > +\t */\n" "> > > > +\tWARN_ON(!irqs_disabled() && cpu_active(cpu));\n" - "> > > > ?\n" + "> > > > \302\240\n" "> > > \n" "> > > Also, the logic of:\n" "> > > \n" @@ -39,7 +74,7 @@ "> > > the IRQ is indeed disabled.\n" "> > > \n" "> > > But this doesn't make sense anymore after we move to ONLINE section, in which\n" - "> > > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON()\n" + "> > > IRQ has already been enabled (see start_secondary()).\302\240 IIUC the WARN_ON()\n" "> > > doesn't get exploded is purely because there's an additional cpu_active(cpu)\n" "> > > check.\n" "> > > \n" @@ -69,6 +104,10 @@ "\n" "Grr, but not routing through this helper is flawed in that KVM doesn't do the\n" "CR4 checks in the hardware enabling case. Don't think that changes the WARN, but\n" - other patches in this series need tweaks. + "other patches in this series need tweaks.\n" + "_______________________________________________\n" + "kvmarm mailing list\n" + "kvmarm@lists.cs.columbia.edu\n" + https://lists.cs.columbia.edu/mailman/listinfo/kvmarm -c67bb9c4c96b5cf3a102852060b726b41832970df39de25aa858e77fe9d0c9fe +4303a48220f186ffda9d327fd605d9bcbb323ebc3dc3a30d965a6bf8213118f2
diff --git a/a/1.txt b/N2/1.txt index 4a2bf30..53e4299 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -3,9 +3,9 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote: > > > > @@ -9283,7 +9283,13 @@ static int > > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops) -> > > > ? int cpu = smp_processor_id(); -> > > > ? struct cpuinfo_x86 *c = &cpu_data(cpu); -> > > > ? +> > > > int cpu = smp_processor_id(); +> > > > struct cpuinfo_x86 *c = &cpu_data(cpu); +> > > > > > > > - WARN_ON(!irqs_disabled()); > > > > + /* > > > > + * Compatibility checks are done when loading KVM and when enabling @@ -15,7 +15,7 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > > > + * an offline CPU. > > > > + */ > > > > + WARN_ON(!irqs_disabled() && cpu_active(cpu)); -> > > > ? +> > > > > > > > > > Also, the logic of: > > > @@ -28,7 +28,7 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > > the IRQ is indeed disabled. > > > > > > But this doesn't make sense anymore after we move to ONLINE section, in which -> > > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON() +> > > IRQ has already been enabled (see start_secondary()). IIUC the WARN_ON() > > > doesn't get exploded is purely because there's an additional cpu_active(cpu) > > > check. > > > diff --git a/a/content_digest b/N2/content_digest index 2a65fc8..8931d5d 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,9 +4,49 @@ "ref\0b198fe971cecd301f0c7c66028cfd71dd7ba7e62.camel@intel.com\0" "ref\0Y3PzhANShVlTXVg1@google.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" + "Subject\0Re: [PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" "Date\0Tue, 15 Nov 2022 20:21:00 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Huang" + " Kai <kai.huang@intel.com>\0" + "Cc\0farman@linux.ibm.com <farman@linux.ibm.com>" + frankja@linux.ibm.com <frankja@linux.ibm.com> + mjrosato@linux.ibm.com <mjrosato@linux.ibm.com> + vkuznets@redhat.com <vkuznets@redhat.com> + chenhuacai@kernel.org <chenhuacai@kernel.org> + aou@eecs.berkeley.edu <aou@eecs.berkeley.edu> + palmer@dabbelt.com <palmer@dabbelt.com> + paul.walmsley@sifive.com <paul.walmsley@sifive.com> + maz@kernel.org <maz@kernel.org> + anup@brainfault.org <anup@brainfault.org> + imbrenda@linux.ibm.com <imbrenda@linux.ibm.com> + pbonzini@redhat.com <pbonzini@redhat.com> + borntraeger@linux.ibm.com <borntraeger@linux.ibm.com> + aleksandar.qemu.devel@gmail.com <aleksandar.qemu.devel@gmail.com> + kvm@vger.kernel.org <kvm@vger.kernel.org> + atishp@atishpatra.org <atishp@atishpatra.org> + farosas@linux.ibm.com <farosas@linux.ibm.com> + david@redhat.com <david@redhat.com> + Yao + Yuan <yuan.yao@intel.com> + mpe@ellerman.id.au <mpe@ellerman.id.au> + alexandru.elisei@arm.com <alexandru.elisei@arm.com> + linux-s390@vger.kernel.org <linux-s390@vger.kernel.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + tglx@linutronix.de <tglx@linutronix.de> + Yamahata + Isaku <isaku.yamahata@intel.com> + kvmarm@lists.linux.dev <kvmarm@lists.linux.dev> + james.morse@arm.com <james.morse@arm.com> + kvm-riscv@lists.infradead.org <kvm-riscv@lists.infradead.org> + suzuki.poulose@arm.com <suzuki.poulose@arm.com> + linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + linux-mips@vger.kernel.org <linux-mips@vger.kernel.org> + Gao + Chao <chao.gao@intel.com> + oliver.upton@linux.dev <oliver.upton@linux.dev> + kvmarm@lists.cs.columbia.edu <kvmarm@lists.cs.columbia.edu> + " linux-riscv@lists.infradead.org <linux-riscv@lists.infradead.org>\0" "\00:1\0" "b\0" "On Tue, Nov 15, 2022, Sean Christopherson wrote:\n" @@ -14,9 +54,9 @@ "> > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote:\n" "> > > > @@ -9283,7 +9283,13 @@ static int\n" "> > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops)\n" - "> > > > ?\tint cpu = smp_processor_id();\n" - "> > > > ?\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" - "> > > > ?\n" + "> > > > \302\240\tint cpu = smp_processor_id();\n" + "> > > > \302\240\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" + "> > > > \302\240\n" "> > > > -\tWARN_ON(!irqs_disabled());\n" "> > > > +\t/*\n" "> > > > +\t * Compatibility checks are done when loading KVM and when enabling\n" @@ -26,7 +66,7 @@ "> > > > +\t * an offline CPU.\n" "> > > > +\t */\n" "> > > > +\tWARN_ON(!irqs_disabled() && cpu_active(cpu));\n" - "> > > > ?\n" + "> > > > \302\240\n" "> > > \n" "> > > Also, the logic of:\n" "> > > \n" @@ -39,7 +79,7 @@ "> > > the IRQ is indeed disabled.\n" "> > > \n" "> > > But this doesn't make sense anymore after we move to ONLINE section, in which\n" - "> > > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON()\n" + "> > > IRQ has already been enabled (see start_secondary()).\302\240 IIUC the WARN_ON()\n" "> > > doesn't get exploded is purely because there's an additional cpu_active(cpu)\n" "> > > check.\n" "> > > \n" @@ -71,4 +111,4 @@ "CR4 checks in the hardware enabling case. Don't think that changes the WARN, but\n" other patches in this series need tweaks. -c67bb9c4c96b5cf3a102852060b726b41832970df39de25aa858e77fe9d0c9fe +e276cae3592b680a3464abb13bd124953976ad9a4b568549b94b9327e28e3ca6
diff --git a/a/1.txt b/N3/1.txt index 4a2bf30..7fe5b04 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -3,9 +3,9 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote: > > > > @@ -9283,7 +9283,13 @@ static int > > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops) -> > > > ? int cpu = smp_processor_id(); -> > > > ? struct cpuinfo_x86 *c = &cpu_data(cpu); -> > > > ? +> > > > int cpu = smp_processor_id(); +> > > > struct cpuinfo_x86 *c = &cpu_data(cpu); +> > > > > > > > - WARN_ON(!irqs_disabled()); > > > > + /* > > > > + * Compatibility checks are done when loading KVM and when enabling @@ -15,7 +15,7 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > > > + * an offline CPU. > > > > + */ > > > > + WARN_ON(!irqs_disabled() && cpu_active(cpu)); -> > > > ? +> > > > > > > > > > Also, the logic of: > > > @@ -28,7 +28,7 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > > the IRQ is indeed disabled. > > > > > > But this doesn't make sense anymore after we move to ONLINE section, in which -> > > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON() +> > > IRQ has already been enabled (see start_secondary()). IIUC the WARN_ON() > > > doesn't get exploded is purely because there's an additional cpu_active(cpu) > > > check. > > > @@ -59,3 +59,8 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: Grr, but not routing through this helper is flawed in that KVM doesn't do the CR4 checks in the hardware enabling case. Don't think that changes the WARN, but other patches in this series need tweaks. + +_______________________________________________ +linux-riscv mailing list +linux-riscv@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-riscv diff --git a/a/content_digest b/N3/content_digest index 2a65fc8..b1cda57 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -4,9 +4,49 @@ "ref\0b198fe971cecd301f0c7c66028cfd71dd7ba7e62.camel@intel.com\0" "ref\0Y3PzhANShVlTXVg1@google.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" + "Subject\0Re: [PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" "Date\0Tue, 15 Nov 2022 20:21:00 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Huang" + " Kai <kai.huang@intel.com>\0" + "Cc\0farman@linux.ibm.com <farman@linux.ibm.com>" + frankja@linux.ibm.com <frankja@linux.ibm.com> + mjrosato@linux.ibm.com <mjrosato@linux.ibm.com> + vkuznets@redhat.com <vkuznets@redhat.com> + chenhuacai@kernel.org <chenhuacai@kernel.org> + aou@eecs.berkeley.edu <aou@eecs.berkeley.edu> + palmer@dabbelt.com <palmer@dabbelt.com> + paul.walmsley@sifive.com <paul.walmsley@sifive.com> + maz@kernel.org <maz@kernel.org> + anup@brainfault.org <anup@brainfault.org> + imbrenda@linux.ibm.com <imbrenda@linux.ibm.com> + pbonzini@redhat.com <pbonzini@redhat.com> + borntraeger@linux.ibm.com <borntraeger@linux.ibm.com> + aleksandar.qemu.devel@gmail.com <aleksandar.qemu.devel@gmail.com> + kvm@vger.kernel.org <kvm@vger.kernel.org> + atishp@atishpatra.org <atishp@atishpatra.org> + farosas@linux.ibm.com <farosas@linux.ibm.com> + david@redhat.com <david@redhat.com> + Yao + Yuan <yuan.yao@intel.com> + mpe@ellerman.id.au <mpe@ellerman.id.au> + alexandru.elisei@arm.com <alexandru.elisei@arm.com> + linux-s390@vger.kernel.org <linux-s390@vger.kernel.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + tglx@linutronix.de <tglx@linutronix.de> + Yamahata + Isaku <isaku.yamahata@intel.com> + kvmarm@lists.linux.dev <kvmarm@lists.linux.dev> + james.morse@arm.com <james.morse@arm.com> + kvm-riscv@lists.infradead.org <kvm-riscv@lists.infradead.org> + suzuki.poulose@arm.com <suzuki.poulose@arm.com> + linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + linux-mips@vger.kernel.org <linux-mips@vger.kernel.org> + Gao + Chao <chao.gao@intel.com> + oliver.upton@linux.dev <oliver.upton@linux.dev> + kvmarm@lists.cs.columbia.edu <kvmarm@lists.cs.columbia.edu> + " linux-riscv@lists.infradead.org <linux-riscv@lists.infradead.org>\0" "\00:1\0" "b\0" "On Tue, Nov 15, 2022, Sean Christopherson wrote:\n" @@ -14,9 +54,9 @@ "> > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote:\n" "> > > > @@ -9283,7 +9283,13 @@ static int\n" "> > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops)\n" - "> > > > ?\tint cpu = smp_processor_id();\n" - "> > > > ?\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" - "> > > > ?\n" + "> > > > \302\240\tint cpu = smp_processor_id();\n" + "> > > > \302\240\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" + "> > > > \302\240\n" "> > > > -\tWARN_ON(!irqs_disabled());\n" "> > > > +\t/*\n" "> > > > +\t * Compatibility checks are done when loading KVM and when enabling\n" @@ -26,7 +66,7 @@ "> > > > +\t * an offline CPU.\n" "> > > > +\t */\n" "> > > > +\tWARN_ON(!irqs_disabled() && cpu_active(cpu));\n" - "> > > > ?\n" + "> > > > \302\240\n" "> > > \n" "> > > Also, the logic of:\n" "> > > \n" @@ -39,7 +79,7 @@ "> > > the IRQ is indeed disabled.\n" "> > > \n" "> > > But this doesn't make sense anymore after we move to ONLINE section, in which\n" - "> > > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON()\n" + "> > > IRQ has already been enabled (see start_secondary()).\302\240 IIUC the WARN_ON()\n" "> > > doesn't get exploded is purely because there's an additional cpu_active(cpu)\n" "> > > check.\n" "> > > \n" @@ -69,6 +109,11 @@ "\n" "Grr, but not routing through this helper is flawed in that KVM doesn't do the\n" "CR4 checks in the hardware enabling case. Don't think that changes the WARN, but\n" - other patches in this series need tweaks. + "other patches in this series need tweaks.\n" + "\n" + "_______________________________________________\n" + "linux-riscv mailing list\n" + "linux-riscv@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-riscv -c67bb9c4c96b5cf3a102852060b726b41832970df39de25aa858e77fe9d0c9fe +4216f25bfa0beb959548f2bf6763ed5035748aa7cf30983205f2ff6c5302ab6e
diff --git a/a/1.txt b/N4/1.txt index 4a2bf30..53e4299 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -3,9 +3,9 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote: > > > > @@ -9283,7 +9283,13 @@ static int > > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops) -> > > > ? int cpu = smp_processor_id(); -> > > > ? struct cpuinfo_x86 *c = &cpu_data(cpu); -> > > > ? +> > > > int cpu = smp_processor_id(); +> > > > struct cpuinfo_x86 *c = &cpu_data(cpu); +> > > > > > > > - WARN_ON(!irqs_disabled()); > > > > + /* > > > > + * Compatibility checks are done when loading KVM and when enabling @@ -15,7 +15,7 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > > > + * an offline CPU. > > > > + */ > > > > + WARN_ON(!irqs_disabled() && cpu_active(cpu)); -> > > > ? +> > > > > > > > > > Also, the logic of: > > > @@ -28,7 +28,7 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > > the IRQ is indeed disabled. > > > > > > But this doesn't make sense anymore after we move to ONLINE section, in which -> > > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON() +> > > IRQ has already been enabled (see start_secondary()). IIUC the WARN_ON() > > > doesn't get exploded is purely because there's an additional cpu_active(cpu) > > > check. > > > diff --git a/a/content_digest b/N4/content_digest index 2a65fc8..f5de49e 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -4,9 +4,48 @@ "ref\0b198fe971cecd301f0c7c66028cfd71dd7ba7e62.camel@intel.com\0" "ref\0Y3PzhANShVlTXVg1@google.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" + "Subject\0Re: [PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" "Date\0Tue, 15 Nov 2022 20:21:00 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Huang" + " Kai <kai.huang@intel.com>\0" + "Cc\0mjrosato@linux.ibm.com <mjrosato@linux.ibm.com>" + david@redhat.com <david@redhat.com> + Yao + Yuan <yuan.yao@intel.com> + paul.walmsley@sifive.com <paul.walmsley@sifive.com> + linux-mips@vger.kernel.org <linux-mips@vger.kernel.org> + linux-riscv@lists.infradead.org <linux-riscv@lists.infradead.org> + imbrenda@linux.ibm.com <imbrenda@linux.ibm.com> + kvmarm@lists.cs.columbia.edu <kvmarm@lists.cs.columbia.edu> + linux-s390@vger.kernel.org <linux-s390@vger.kernel.org> + frankja@linux.ibm.com <frankja@linux.ibm.com> + maz@kernel.org <maz@kernel.org> + chenhuacai@kernel.org <chenhuacai@kernel.org> + aleksandar.qemu.devel@gmail.com <aleksandar.qemu.devel@gmail.com> + james.morse@arm.com <james.morse@arm.com> + borntraeger@linux.ibm.com <borntraeger@linux.ibm.com> + Gao + Chao <chao.gao@intel.com> + farman@linux.ibm.com <farman@linux.ibm.com> + aou@eecs.berkeley.edu <aou@eecs.berkeley.edu> + suzuki.poulose@arm.com <suzuki.poulose@arm.com> + kvm@vger.kernel.org <kvm@vg er.kernel.org> + atishp@atishpatra.org <atishp@atishpatra.org> + kvmarm@lists.linux.dev <kvmarm@lists.linux.dev> + tglx@linutronix.de <tglx@linutronix.de> + alexandru.elisei@arm.com <alexandru.elisei@arm.com> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + Yamahata + Isaku <isaku.yamahata@intel.com> + farosas@linux.ibm.com <farosas@linux.ibm.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + oliver.upton@linux.dev <oliver.upton@linux.dev> + palmer@dabbelt.com <palmer@dabbelt.com> + kvm-riscv@lists.infradead.org <kvm-riscv@lists.infradead.org> + anup@brainfault.org <anup@brainfault.org> + pbonzini@redhat.com <pbonzini@redhat.com> + vkuznets@redhat.com <vkuznets@redhat.com> + " linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On Tue, Nov 15, 2022, Sean Christopherson wrote:\n" @@ -14,9 +53,9 @@ "> > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote:\n" "> > > > @@ -9283,7 +9283,13 @@ static int\n" "> > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops)\n" - "> > > > ?\tint cpu = smp_processor_id();\n" - "> > > > ?\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" - "> > > > ?\n" + "> > > > \302\240\tint cpu = smp_processor_id();\n" + "> > > > \302\240\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" + "> > > > \302\240\n" "> > > > -\tWARN_ON(!irqs_disabled());\n" "> > > > +\t/*\n" "> > > > +\t * Compatibility checks are done when loading KVM and when enabling\n" @@ -26,7 +65,7 @@ "> > > > +\t * an offline CPU.\n" "> > > > +\t */\n" "> > > > +\tWARN_ON(!irqs_disabled() && cpu_active(cpu));\n" - "> > > > ?\n" + "> > > > \302\240\n" "> > > \n" "> > > Also, the logic of:\n" "> > > \n" @@ -39,7 +78,7 @@ "> > > the IRQ is indeed disabled.\n" "> > > \n" "> > > But this doesn't make sense anymore after we move to ONLINE section, in which\n" - "> > > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON()\n" + "> > > IRQ has already been enabled (see start_secondary()).\302\240 IIUC the WARN_ON()\n" "> > > doesn't get exploded is purely because there's an additional cpu_active(cpu)\n" "> > > check.\n" "> > > \n" @@ -71,4 +110,4 @@ "CR4 checks in the hardware enabling case. Don't think that changes the WARN, but\n" other patches in this series need tweaks. -c67bb9c4c96b5cf3a102852060b726b41832970df39de25aa858e77fe9d0c9fe +3916d7f7e43c72f7389ec1fc6a8d359e9026ede3c68d43a549dea0434813a5bc
diff --git a/a/1.txt b/N5/1.txt index 4a2bf30..fa28e63 100644 --- a/a/1.txt +++ b/N5/1.txt @@ -3,9 +3,9 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote: > > > > @@ -9283,7 +9283,13 @@ static int > > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops) -> > > > ? int cpu = smp_processor_id(); -> > > > ? struct cpuinfo_x86 *c = &cpu_data(cpu); -> > > > ? +> > > > int cpu = smp_processor_id(); +> > > > struct cpuinfo_x86 *c = &cpu_data(cpu); +> > > > > > > > - WARN_ON(!irqs_disabled()); > > > > + /* > > > > + * Compatibility checks are done when loading KVM and when enabling @@ -15,7 +15,7 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > > > + * an offline CPU. > > > > + */ > > > > + WARN_ON(!irqs_disabled() && cpu_active(cpu)); -> > > > ? +> > > > > > > > > > Also, the logic of: > > > @@ -28,7 +28,7 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: > > > the IRQ is indeed disabled. > > > > > > But this doesn't make sense anymore after we move to ONLINE section, in which -> > > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON() +> > > IRQ has already been enabled (see start_secondary()). IIUC the WARN_ON() > > > doesn't get exploded is purely because there's an additional cpu_active(cpu) > > > check. > > > @@ -59,3 +59,8 @@ On Tue, Nov 15, 2022, Sean Christopherson wrote: Grr, but not routing through this helper is flawed in that KVM doesn't do the CR4 checks in the hardware enabling case. Don't think that changes the WARN, but other patches in this series need tweaks. + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N5/content_digest index 2a65fc8..05d58fe 100644 --- a/a/content_digest +++ b/N5/content_digest @@ -4,9 +4,49 @@ "ref\0b198fe971cecd301f0c7c66028cfd71dd7ba7e62.camel@intel.com\0" "ref\0Y3PzhANShVlTXVg1@google.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" + "Subject\0Re: [PATCH 38/44] KVM: Disable CPU hotplug during hardware enabling\0" "Date\0Tue, 15 Nov 2022 20:21:00 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Huang" + " Kai <kai.huang@intel.com>\0" + "Cc\0farman@linux.ibm.com <farman@linux.ibm.com>" + frankja@linux.ibm.com <frankja@linux.ibm.com> + mjrosato@linux.ibm.com <mjrosato@linux.ibm.com> + vkuznets@redhat.com <vkuznets@redhat.com> + chenhuacai@kernel.org <chenhuacai@kernel.org> + aou@eecs.berkeley.edu <aou@eecs.berkeley.edu> + palmer@dabbelt.com <palmer@dabbelt.com> + paul.walmsley@sifive.com <paul.walmsley@sifive.com> + maz@kernel.org <maz@kernel.org> + anup@brainfault.org <anup@brainfault.org> + imbrenda@linux.ibm.com <imbrenda@linux.ibm.com> + pbonzini@redhat.com <pbonzini@redhat.com> + borntraeger@linux.ibm.com <borntraeger@linux.ibm.com> + aleksandar.qemu.devel@gmail.com <aleksandar.qemu.devel@gmail.com> + kvm@vger.kernel.org <kvm@vger.kernel.org> + atishp@atishpatra.org <atishp@atishpatra.org> + farosas@linux.ibm.com <farosas@linux.ibm.com> + david@redhat.com <david@redhat.com> + Yao + Yuan <yuan.yao@intel.com> + mpe@ellerman.id.au <mpe@ellerman.id.au> + alexandru.elisei@arm.com <alexandru.elisei@arm.com> + linux-s390@vger.kernel.org <linux-s390@vger.kernel.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + tglx@linutronix.de <tglx@linutronix.de> + Yamahata + Isaku <isaku.yamahata@intel.com> + kvmarm@lists.linux.dev <kvmarm@lists.linux.dev> + james.morse@arm.com <james.morse@arm.com> + kvm-riscv@lists.infradead.org <kvm-riscv@lists.infradead.org> + suzuki.poulose@arm.com <suzuki.poulose@arm.com> + linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + linux-mips@vger.kernel.org <linux-mips@vger.kernel.org> + Gao + Chao <chao.gao@intel.com> + oliver.upton@linux.dev <oliver.upton@linux.dev> + kvmarm@lists.cs.columbia.edu <kvmarm@lists.cs.columbia.edu> + " linux-riscv@lists.infradead.org <linux-riscv@lists.infradead.org>\0" "\00:1\0" "b\0" "On Tue, Nov 15, 2022, Sean Christopherson wrote:\n" @@ -14,9 +54,9 @@ "> > On Thu, 2022-11-10 at 01:33 +0000, Huang, Kai wrote:\n" "> > > > @@ -9283,7 +9283,13 @@ static int\n" "> > > > kvm_x86_check_processor_compatibility(struct kvm_x86_init_ops *ops)\n" - "> > > > ?\tint cpu = smp_processor_id();\n" - "> > > > ?\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" - "> > > > ?\n" + "> > > > \302\240\tint cpu = smp_processor_id();\n" + "> > > > \302\240\tstruct cpuinfo_x86 *c = &cpu_data(cpu);\n" + "> > > > \302\240\n" "> > > > -\tWARN_ON(!irqs_disabled());\n" "> > > > +\t/*\n" "> > > > +\t * Compatibility checks are done when loading KVM and when enabling\n" @@ -26,7 +66,7 @@ "> > > > +\t * an offline CPU.\n" "> > > > +\t */\n" "> > > > +\tWARN_ON(!irqs_disabled() && cpu_active(cpu));\n" - "> > > > ?\n" + "> > > > \302\240\n" "> > > \n" "> > > Also, the logic of:\n" "> > > \n" @@ -39,7 +79,7 @@ "> > > the IRQ is indeed disabled.\n" "> > > \n" "> > > But this doesn't make sense anymore after we move to ONLINE section, in which\n" - "> > > IRQ has already been enabled (see start_secondary()).? IIUC the WARN_ON()\n" + "> > > IRQ has already been enabled (see start_secondary()).\302\240 IIUC the WARN_ON()\n" "> > > doesn't get exploded is purely because there's an additional cpu_active(cpu)\n" "> > > check.\n" "> > > \n" @@ -69,6 +109,11 @@ "\n" "Grr, but not routing through this helper is flawed in that KVM doesn't do the\n" "CR4 checks in the hardware enabling case. Don't think that changes the WARN, but\n" - other patches in this series need tweaks. + "other patches in this series need tweaks.\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -c67bb9c4c96b5cf3a102852060b726b41832970df39de25aa858e77fe9d0c9fe +71dc567825dbac18ccebfd0f048e8a1d620b2cc9f1b81e774af5c19b87fb6497
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.