From: Andrew Lunn <andrew@lunn.ch>
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev
Subject: Re: [PATCH v4 1/2] net: page_pool: export page_pool_stats definition
Date: Tue, 15 Nov 2022 18:12:02 +0100 [thread overview]
Message-ID: <Y3PIYg+VsuBxq5cW@lunn.ch> (raw)
In-Reply-To: <20221115155744.193789-2-shenwei.wang@nxp.com>
On Tue, Nov 15, 2022 at 09:57:43AM -0600, Shenwei Wang wrote:
> The definition of the 'struct page_pool_stats' is required even when
> the CONFIG_PAGE_POOL_STATS is not defined. Otherwise, it is required
> the drivers to handle the case of CONFIG_PAGE_POOL_STATS undefined.
I agree the API is broken, but i think there is a better fix.
There should be a stub of page_pool_get_stats() for when
CONFIG_PAGE_POOL_STATS is disabled.
Nothing actually dereferences struct page_pool_stats when you have
this stub. So it might be enough to simply have
struct page_pool_stats{
};
Andrew
next prev parent reply other threads:[~2022-11-15 17:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 15:57 [PATCH v4 0/2] net: fec: add xdp and page pool statistics Shenwei Wang
2022-11-15 15:57 ` [PATCH v4 1/2] net: page_pool: export page_pool_stats definition Shenwei Wang
2022-11-15 17:12 ` Andrew Lunn [this message]
2022-11-15 17:18 ` [EXT] " Shenwei Wang
2022-11-15 17:43 ` Andrew Lunn
2022-11-15 17:52 ` Shenwei Wang
2022-11-15 15:57 ` [PATCH v4 2/2] net: fec: add xdp and page pool statistics Shenwei Wang
2022-11-15 17:28 ` Andrew Lunn
2022-11-15 17:53 ` [EXT] " Shenwei Wang
2022-11-15 17:57 ` [PATCH v4 0/2] " Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3PIYg+VsuBxq5cW@lunn.ch \
--to=andrew@lunn.ch \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=imx@lists.linux.dev \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.