From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E9DA7C for ; Wed, 16 Nov 2022 01:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=yFmAK950q45cj8aoIbkBUEry3On2mPcjgESz/yzDyYE=; b=tB/JO8Oqb+80yOuMZjJ1ej2CRs NNR2Jj7ECGDSJrFQFkZvokN8l6AqhTZVabEQhevH9BeH8Y1kqK3UDJlfmxH858OjGc5yces0BZw9A V40XbF0ZOeX41t+/BWNNZvhNBu5++7hA6ioMsxEKzSGV03/y9yCWkl45bdDJb2dQGcbU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ov7OG-002W6v-Mj; Wed, 16 Nov 2022 02:39:00 +0100 Date: Wed, 16 Nov 2022 02:39:00 +0100 From: Andrew Lunn To: Corentin Labbe Cc: broonie@kernel.org, calvin.johnson@oss.nxp.com, davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk, pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v4 0/3] arm64: add ethernet to orange pi 3 Message-ID: References: <20221115073603.3425396-1-clabbe@baylibre.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115073603.3425396-1-clabbe@baylibre.com> > But this way could have some problem, a netdev driver could handle > already its PHY (like dwmac-sun8i already do) and so both phy-core and > the netdev will use both. > It is why phy-supply was renamed in ephy-supply in patch #3. A MAC driver will put its DT properties in the MAC node. A PHY will put its DT properties in the PHY node of the MDIO bus. Since they are in different locations, they can use the same name. So please keep with phy-supply. Please also update Documentation/devicetree/bindings/net/ethernet-phy.yaml with these new properties. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 500C3C433FE for ; Wed, 16 Nov 2022 01:43:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9D3rONRFexHFiengEKB5iI3dApZcUicnBUe3AgUP2U4=; b=TdZ0YjeM0PIVzq f7peNhuyyE9ry4oxGujOkxbbGf6+7urwLLSmzMRo8gVpYBg1a3vWZkQtVzhXZJyQ6lizMCssrumuq SpZoRaV2/oxIyRnnAdLqCw3k5Ffvl2mmTOXb4p/wUDfZzP1dDf1Ibo71eppMdYSAABcN790ChSZAz G3QA6P9n/38GlzO6vEC78ID9SaTO6oBsdu2aLIeENTF3o/dMM5jIUJVS2Ec9HE2lW23Y5N72QwfOl 0XClnkWPlA6mBZlih6RCnqUDsHrGl8JIaGv4KFVf1/dHVGWv6OBTQV5A9Z+EaWcVW5ZQOzVn9ht87 hMXG1+HsasoxlMqn0dnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov7Pp-00GCHr-Fc; Wed, 16 Nov 2022 01:40:37 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov7Pm-00GCHT-FI for linux-arm-kernel@lists.infradead.org; Wed, 16 Nov 2022 01:40:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=yFmAK950q45cj8aoIbkBUEry3On2mPcjgESz/yzDyYE=; b=tB/JO8Oqb+80yOuMZjJ1ej2CRs NNR2Jj7ECGDSJrFQFkZvokN8l6AqhTZVabEQhevH9BeH8Y1kqK3UDJlfmxH858OjGc5yces0BZw9A V40XbF0ZOeX41t+/BWNNZvhNBu5++7hA6ioMsxEKzSGV03/y9yCWkl45bdDJb2dQGcbU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ov7OG-002W6v-Mj; Wed, 16 Nov 2022 02:39:00 +0100 Date: Wed, 16 Nov 2022 02:39:00 +0100 From: Andrew Lunn To: Corentin Labbe Cc: broonie@kernel.org, calvin.johnson@oss.nxp.com, davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk, pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v4 0/3] arm64: add ethernet to orange pi 3 Message-ID: References: <20221115073603.3425396-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221115073603.3425396-1-clabbe@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_174034_530527_8ACC51DC X-CRM114-Status: UNSURE ( 9.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > But this way could have some problem, a netdev driver could handle > already its PHY (like dwmac-sun8i already do) and so both phy-core and > the netdev will use both. > It is why phy-supply was renamed in ephy-supply in patch #3. A MAC driver will put its DT properties in the MAC node. A PHY will put its DT properties in the PHY node of the MDIO bus. Since they are in different locations, they can use the same name. So please keep with phy-supply. Please also update Documentation/devicetree/bindings/net/ethernet-phy.yaml with these new properties. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel