From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
mm-commits@vger.kernel.org, suleiman@google.com,
ngupta@vflare.org, keescook+coverity-bot@chromium.org,
keescook@chromium.org, senozhatsky@chromium.org
Subject: Re: + zram-introduce-recompress-sysfs-knob-fix-2.patch added to mm-unstable branch
Date: Wed, 16 Nov 2022 10:09:17 +0900 [thread overview]
Message-ID: <Y3Q4PQ7nyI1F4LuP@google.com> (raw)
In-Reply-To: <Y3QZmY9KyJWEDv5v@google.com>
On (22/11/15 14:58), Minchan Kim wrote:
> > --- a/drivers/block/zram/zram_drv.c~zram-introduce-recompress-sysfs-knob-fix-2
> > +++ a/drivers/block/zram/zram_drv.c
> > @@ -1689,6 +1689,7 @@ static int zram_recompress(struct zram *
> > * Iterate the secondary comp algorithms list (in order of priority)
> > * and try to recompress the page.
> > */
> > + prio_max = min(prio_max, ZRAM_MAX_COMPS);
> > for (; prio < prio_max; prio++) {
> > if (!zram->comps[prio])
> > continue;
> > _
>
> Hi Andrew,
>
> Please drop this patch. It makes reviewer think "oh, zram_recompress
> pass the higher prio_max value than the one zram allowed by somehow
> so we need to get the min value here", which is not true once review
> read code again/again and scratch head and then post patch to remove
> the unncessary line. I prefer reviewer happier.
I don't disagree. Let's drop it.
prev parent reply other threads:[~2022-11-16 1:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 0:42 + zram-introduce-recompress-sysfs-knob-fix-2.patch added to mm-unstable branch Andrew Morton
2022-11-15 22:58 ` Minchan Kim
2022-11-16 1:09 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3Q4PQ7nyI1F4LuP@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=keescook+coverity-bot@chromium.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=suleiman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.