From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 377757C for ; Wed, 16 Nov 2022 01:58:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=gDPOfgCfsDpi156C3e6FefCsf6pqUQQ8FpNTQBrsuqU=; b=1pWmLNiV2HEPMd/seMrvyU9Oyy rX/HE2DM+RqCT73cBUybTRcZnPaHO4j1QXB1yPd+IPFy7/fW5Qv3aStSr6ugUTqSIqSC5ZES42jNw ynjhN/u4twv7TpTZzjyPC2EhzLfcC9DUTdRTaG0shKEp0xqbhDxjmJulcHThQpcsSPWE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ov7gw-002WDH-FG; Wed, 16 Nov 2022 02:58:18 +0100 Date: Wed, 16 Nov 2022 02:58:18 +0100 From: Andrew Lunn To: Corentin Labbe Cc: broonie@kernel.org, calvin.johnson@oss.nxp.com, davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk, pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v4 2/3] phy: handle optional regulator for PHY Message-ID: References: <20221115073603.3425396-1-clabbe@baylibre.com> <20221115073603.3425396-3-clabbe@baylibre.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221115073603.3425396-3-clabbe@baylibre.com> > + reg_cnt = of_regulator_bulk_get_all(&bus->dev, nchild, &consumers); This allocates memory for consumers? I don't see it being freed. I think you need to add to phy_remove. Plus the error patch should also free it. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FDF5C433FE for ; Wed, 16 Nov 2022 02:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vs1WPHLfV0LdNMA4wIRYjJ25LLs+ArI+rcCNKBTiF7s=; b=EjjafJnV6EbHS6 XWk1stGEJkcGSMz+ZixeJCAgChm5peYuvpKKWSZlbC7YsThecVZlOQKeLOcYcSoPecLMkCUHKI/ZM MoOJY3EcvtSurGlGjNzdBKdw7oOlEuo/+BMET0swCfj0ELqJYg8voYOeSNyZmWRjXLAPQmsWtRh/Z wCiV6MM/JdPQzWySe+8PZ6Yz3ETGLFki6tZQIv3Vof6a+Yp6lu0wTJJoKyYWJ7GhQGGV0IZoUuRBU YGLxainr/rfYDyn5goQ8vpZBItxlpaDaqOXySGrh4mWlPSriMHvaycKcEBoTx+Hwanv6ET/5iga/G fIVwiQI4ohpqDg0AwWfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov7hZ-00GNhA-7D; Wed, 16 Nov 2022 01:58:57 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov7hW-00GNgG-NF for linux-arm-kernel@lists.infradead.org; Wed, 16 Nov 2022 01:58:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=gDPOfgCfsDpi156C3e6FefCsf6pqUQQ8FpNTQBrsuqU=; b=1pWmLNiV2HEPMd/seMrvyU9Oyy rX/HE2DM+RqCT73cBUybTRcZnPaHO4j1QXB1yPd+IPFy7/fW5Qv3aStSr6ugUTqSIqSC5ZES42jNw ynjhN/u4twv7TpTZzjyPC2EhzLfcC9DUTdRTaG0shKEp0xqbhDxjmJulcHThQpcsSPWE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ov7gw-002WDH-FG; Wed, 16 Nov 2022 02:58:18 +0100 Date: Wed, 16 Nov 2022 02:58:18 +0100 From: Andrew Lunn To: Corentin Labbe Cc: broonie@kernel.org, calvin.johnson@oss.nxp.com, davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk, pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v4 2/3] phy: handle optional regulator for PHY Message-ID: References: <20221115073603.3425396-1-clabbe@baylibre.com> <20221115073603.3425396-3-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221115073603.3425396-3-clabbe@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_175854_772573_DD900A23 X-CRM114-Status: UNSURE ( 7.10 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > + reg_cnt = of_regulator_bulk_get_all(&bus->dev, nchild, &consumers); This allocates memory for consumers? I don't see it being freed. I think you need to add to phy_remove. Plus the error patch should also free it. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel