From: Oliver Upton <oliver.upton@linux.dev>
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2] KVM: arm64: Don't acquire RCU read lock for exclusive table walks
Date: Wed, 16 Nov 2022 07:27:27 +0000 [thread overview]
Message-ID: <Y3SQ3wogsVUEu1Qe@google.com> (raw)
In-Reply-To: <868rkbppdq.wl-maz@kernel.org>
On Wed, Nov 16, 2022 at 03:08:49AM +0000, Marc Zyngier wrote:
> I'm not crazy about this sort of parameters. I think it would make a
> lot more sense to pass a pointer to the walker structure and do the
> flag check inside the helper.
>
> That way, we avoid extra churn if/when we need extra state or
> bookkeeping around the walk.
Sure, let's go that way instead. v3 on the way lol :)
--
Thanks,
Oliver
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oliver.upton@linux.dev>
To: Marc Zyngier <maz@kernel.org>
Cc: James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
kvmarm@lists.linux.dev,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM: arm64: Don't acquire RCU read lock for exclusive table walks
Date: Wed, 16 Nov 2022 07:27:27 +0000 [thread overview]
Message-ID: <Y3SQ3wogsVUEu1Qe@google.com> (raw)
Message-ID: <20221116072727.8C5N7D8y3uM53xo-CvnAInr-a2Ra9qghvgurRvy9smI@z> (raw)
In-Reply-To: <868rkbppdq.wl-maz@kernel.org>
On Wed, Nov 16, 2022 at 03:08:49AM +0000, Marc Zyngier wrote:
> I'm not crazy about this sort of parameters. I think it would make a
> lot more sense to pass a pointer to the walker structure and do the
> flag check inside the helper.
>
> That way, we avoid extra churn if/when we need extra state or
> bookkeeping around the walk.
Sure, let's go that way instead. v3 on the way lol :)
--
Thanks,
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oliver.upton@linux.dev>
To: Marc Zyngier <maz@kernel.org>
Cc: James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
kvmarm@lists.linux.dev,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM: arm64: Don't acquire RCU read lock for exclusive table walks
Date: Wed, 16 Nov 2022 07:27:27 +0000 [thread overview]
Message-ID: <Y3SQ3wogsVUEu1Qe@google.com> (raw)
In-Reply-To: <868rkbppdq.wl-maz@kernel.org>
On Wed, Nov 16, 2022 at 03:08:49AM +0000, Marc Zyngier wrote:
> I'm not crazy about this sort of parameters. I think it would make a
> lot more sense to pass a pointer to the walker structure and do the
> flag check inside the helper.
>
> That way, we avoid extra churn if/when we need extra state or
> bookkeeping around the walk.
Sure, let's go that way instead. v3 on the way lol :)
--
Thanks,
Oliver
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-16 7:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 22:55 [PATCH v2] KVM: arm64: Don't acquire RCU read lock for exclusive table walks Oliver Upton
2022-11-15 22:55 ` Oliver Upton
2022-11-15 22:55 ` Oliver Upton
2022-11-16 3:08 ` Marc Zyngier
2022-11-16 3:08 ` Marc Zyngier
2022-11-16 3:08 ` Marc Zyngier
2022-11-16 7:27 ` Oliver Upton [this message]
2022-11-16 7:27 ` Oliver Upton
2022-11-16 7:27 ` Oliver Upton
2022-11-16 8:14 ` Oliver Upton
2022-11-16 8:14 ` Oliver Upton
2022-11-16 8:14 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3SQ3wogsVUEu1Qe@google.com \
--to=oliver.upton@linux.dev \
--cc=catalin.marinas@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maz@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.