From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Brian Masney <bmasney@redhat.com>,
Marijn Suijten <marijn.suijten@somainline.org>
Subject: Re: [PATCH v1 1/1] gpiolib: Unify access to the device properties
Date: Wed, 16 Nov 2022 16:41:28 +0200 [thread overview]
Message-ID: <Y3T2mN1inwsYZWLW@smile.fi.intel.com> (raw)
In-Reply-To: <20221116141728.72491-1-andriy.shevchenko@linux.intel.com>
On Wed, Nov 16, 2022 at 04:17:28PM +0200, Andy Shevchenko wrote:
> Some of the functions are using struct fwnode_handle, some struct device
> pointer. In the GPIO library the firmware node of the GPIO device is the
> same as GPIO node of the GPIO chip. Due to this fact we may use former
> to access properties everywhere in the code.
Citing myself from another thread to the topic:
Nevertheless, for of_gpiochip_add()/of_gpiochip_remove() and
of_mm_gpiochip_add_data() I still left use of fwnode, because it feels
the right thing to do: we are taking reference on the input data in
such cases.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-16 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 14:17 [PATCH v1 1/1] gpiolib: Unify access to the device properties Andy Shevchenko
2022-11-16 14:41 ` Andy Shevchenko [this message]
2022-11-17 15:54 ` Brian Masney
2022-11-20 19:16 ` Marijn Suijten
2022-11-21 8:27 ` Andy Shevchenko
2022-11-25 18:30 ` Andy Shevchenko
2022-11-28 18:01 ` Bartosz Golaszewski
2022-11-28 18:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3T2mN1inwsYZWLW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bmasney@redhat.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.