From: Andrew Lunn <andrew@lunn.ch>
To: Alexandru Tachici <alexandru.tachici@analog.com>
Cc: linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
steve.glendinning@shawell.net, UNGLinuxDriver@microchip.com,
andre.edich@microchip.com, linux-usb@vger.kernel.org
Subject: Re: [net v2 1/1] net: usb: smsc95xx: fix external PHY reset
Date: Wed, 16 Nov 2022 14:46:11 +0100 [thread overview]
Message-ID: <Y3Tpo6wo2ytMRpXf@lunn.ch> (raw)
In-Reply-To: <20221115114434.9991-2-alexandru.tachici@analog.com>
On Tue, Nov 15, 2022 at 01:44:34PM +0200, Alexandru Tachici wrote:
> An external PHY needs settling time after power up or reset.
> In the bind() function an mdio bus is registered. If at this point
> the external PHY is still initialising, no valid PHY ID will be
> read and on phy_find_first() the bind() function will fail.
>
> If an external PHY is present, wait the maximum time specified
> in 802.3 45.2.7.1.1.
>
> Fixes: 05b35e7eb9a1 ("smsc95xx: add phylib support")
> Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
Thanks for making Russell suggested change.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-11-16 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 11:44 [net v2 0/1] net: usb: smsc95xx: fix external PHY reset Alexandru Tachici
2022-11-15 11:44 ` [net v2 1/1] " Alexandru Tachici
2022-11-16 13:46 ` Andrew Lunn [this message]
2022-11-17 9:50 ` [net v2 0/1] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3Tpo6wo2ytMRpXf@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandru.tachici@analog.com \
--cc=andre.edich@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.