From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F360FC4332F for ; Wed, 16 Nov 2022 13:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zwL0SMNrQuhXqN1E9zp9jzleWUHG7tFMw8jYPA374c0=; b=pny2GgS7uR2Imy qXDKrRtwrAZP4u47WJim7pMAg8CO4TEAJR9sTmTjSv3a5QRQG2PTLxKlx3TfGfSrK2cbYy9UbqZGi PpsF6LYleGfI3Kr4lJgJzC1LGzDVnQauytv6imPK30xXJs4e3HW0t9VSJLaRhdJHMJmIvDH9JhS4u 3Yyi6WUmKYceyYm6XBQEk3kpb/IGvFQAKQyRrMWWvMO1Wik91U2JwY3yp25QQv2641mg8odLBNvGl jVMWvjw7Di89bbIXIkLdFYB0V385bWw9aARk9IVcFtxEd7xUHVPTTAAOBT2NWMnnvbWAu2qLL/KQB /1aRQNMtvaFRRlS5JEuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovIuj-004KlT-QS; Wed, 16 Nov 2022 13:57:17 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovIuf-004Kim-SN for linux-arm-kernel@lists.infradead.org; Wed, 16 Nov 2022 13:57:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4B357B81D93; Wed, 16 Nov 2022 13:57:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0582C433C1; Wed, 16 Nov 2022 13:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668607029; bh=icU4I7RIgRLNY1cWYT1aruWSL+8MqM+CeYHqkxj7G4M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mfcdaHIoG5bad1XTgqtegKoMoni3gJ7rGv0tAdPMtGnmpeFXcdmD95qMfH0WVHlIv 2dL/Yn+4DdsISc9XdDN8loUYubDD4IYeHGwvB/gOoGgEW+8FYaOwAf4m8kFFsrNWoq lib7U6lPDPNE+YkVP2EJJs7dpT++WsUSD9WXJsfU//6Eijw5SIoKjrXtPxI+BOnwAh +u2UP1CrpYQsM+iNXtOgvfO9Y4NCP06dR20DqflU49xk0LpmqOSX2RD4LCkILfTonu Ju7zqNJbta95pi4ejC+XhnmPESECVhFZ7VKy93eD+Vd1dWvQRQ5X7lHqydydBCMNPu tj2RHppy2+jHA== Date: Wed, 16 Nov 2022 13:57:04 +0000 From: Lee Jones To: Liu Ying Cc: Rob Herring , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Subject: Re: [PATCH RESEND] mfd: Add Freescale i.MX8qxp Control and Status Registers (CSR) module driver Message-ID: References: <20221017075702.4182846-1-victor.liu@nxp.com> <4dfb7699c33974a682d798071c85b431b87e5432.camel@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221116_055714_249552_E98B9F81 X-CRM114-Status: GOOD ( 48.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxNiBOb3YgMjAyMiwgTGl1IFlpbmcgd3JvdGU6Cgo+IE9uIFR1ZSwgMjAyMi0xMS0x NSBhdCAwNzozMyAtMDYwMCwgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gPiBPbiBNb24sIE5vdiAxNCwg MjAyMiBhdCAxMToyMiBQTSBMaXUgWWluZyA8dmljdG9yLmxpdUBueHAuY29tPiB3cm90ZToKPiA+ ID4gT24gTW9uLCAyMDIyLTExLTE0IGF0IDE0OjU0IC0wNjAwLCBSb2IgSGVycmluZyB3cm90ZToK PiA+ID4gPiBPbiBNb24sIE5vdiA3LCAyMDIyIGF0IDk6NTggUE0gTGl1IFlpbmcgPHZpY3Rvci5s aXVAbnhwLmNvbT4gd3JvdGU6Cj4gPiA+ID4gPiBIaSBMZWUsCj4gPiA+ID4gPiAKPiA+ID4gPiA+ IE9uIE1vbiwgMjAyMi0xMS0wNyBhdCAwOTowNSArMDAwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4g PiA+ID4gPiBPbiBXZWQsIDAyIE5vdiAyMDIyLCBMaXUgWWluZyB3cm90ZToKPiA+ID4gPiA+ID4g Cj4gPiA+ID4gPiA+ID4gSGkgTGVlLAo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IE9uIFR1 ZSwgMjAyMi0xMS0wMSBhdCAxMzo1MyArMDgwMCwgTGl1IFlpbmcgd3JvdGU6Cj4gPiA+ID4gPiA+ ID4gPiBIaSBMZWUsCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+IE9uIE1vbiwgMjAy Mi0xMC0zMSBhdCAxNTo0MCArMDAwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4g PiBPbiBNb24sIDE3IE9jdCAyMDIyLCBMaXUgWWluZyB3cm90ZToKPiA+ID4gPiA+ID4gPiA+ID4g Cj4gPiAKPiA+IFsuLi5dCj4gPiAKPiA+ID4gPiA+ID4gPiA+ID4gPiArICAgICByZXQgPSBkZXZt X29mX3BsYXRmb3JtX3BvcHVsYXRlKCZwZGV2LT5kZXYpOwo+ID4gPiA+ID4gPiA+ID4gPiAKPiA+ ID4gPiA+ID4gPiA+ID4gVGhlIHVzZSBvZiB0aGlzIEFQSSBkb2VzIG5vdCBjb25zdGl0dXRlIGEg TUZELgo+ID4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+ID4gUGxlYXNlIHVzZSAic2lt cGxlLW1mZCIgaW5zdGVhZC4KPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gc2ltcGxl LW1mZCBkZXZpY2VzIGhhdmUgIk9OTFlfQlVTIiBzZXQgaW4gc2ltcGxlLXBtLWJ1cy5jLCBzbyB0 aGUKPiA+ID4gPiA+ID4gPiA+IHNpbXBsZS1wbS1idXMgZHJpdmVyIHdvdWxkIG5vdCBwb3B1bGF0 ZSBjaGlsZCBkZXZpY2VzIG9mIHNpbXBsZS1tZmQKPiA+ID4gPiA+ID4gPiA+IGRldmljZXMuCj4g PiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBSaWdodCwgc2ltcGxlLXBtLWJ1cyB3aWxsIG5vdCBwb3B1 bGF0ZSBjaGlsZCBkZXZpY2VzLCBiZWNhdXNlOgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBzaW1wbGUt cG0tYnVzLmMgbWF5IHBvcHVsYXRlIGNoaWxkIGRldmljZXMgb2Ygc2ltcGxlLXBtLWJ1cyBkZXZp Y2VzCj4gPiA+ID4gPiBiZWNhdXNlICJPTkxZX0JVUyIgaXMgX25vdF8gc2V0IGZvciBzaW1wbGUt cG0tYnVzIGRldmljZXMuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IHNpbXBsZS1wbS1idXMuYyB3b3Vs ZCBfbm90XyBwb3B1bGF0ZSBjaGlsZCBkZXZpY2VzIG9mIHNpbXBsZS1tZmQKPiA+ID4gPiA+IGRl dmljZXMgYmVjYXVzZSAiT05MWV9CVVMiIGlzIHNldCBmb3Igc2ltcGxlLW1mZCBkZXZpY2VzLgo+ ID4gPiA+ID4gCj4gPiA+ID4gPiA+ICAgLyoKPiA+ID4gPiA+ID4gICAgKiBUaGVzZSBhcmUgdHJh bnNwYXJlbnQgYnVzIGRldmljZXMgKG5vdCBzaW1wbGUtcG0tYnVzIG1hdGNoZXMpIHRoYXQKPiA+ ID4gPiA+ID4gICAgKiBoYXZlIHRoZWlyIGNoaWxkIG5vZGVzIHBvcHVsYXRlZCBhdXRvbWF0aWNh bGx5LiAgU28sIGRvbid0IG5lZWQgdG8KPiA+ID4gPiA+ID4gICAgKiBkbyBhbnl0aGluZyBtb3Jl LiBXZSBvbmx5IG1hdGNoIHdpdGggdGhlIGRldmljZSBpZiB0aGlzIGRyaXZlciBpcwo+ID4gPiA+ ID4gPiAgICAqIHRoZSBtb3N0IHNwZWNpZmljIG1hdGNoIGJlY2F1c2Ugd2UgZG9uJ3Qgd2FudCB0 byBpbmNvcnJlY3RseSBiaW5kIHRvCj4gPiA+ID4gPiA+ICAgICogYSBkZXZpY2UgdGhhdCBoYXMg YSBtb3JlIHNwZWNpZmljIGRyaXZlci4KPiA+ID4gPiA+ID4gICAgKi8KPiA+ID4gPiA+ID4gCj4g PiA+ID4gPiA+IFNvICJzaW1wbGUtbWZkIiBtdXN0IGJlIHBvcHVsYXRlZCBlbHNld2hlcmUgaS5l LiBkcml2ZXJzL29mL3BsYXRmb3JtLmMuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IElmIHNpbXBsZS1t ZmQgZGV2aWNlIGlzIGEgY2hpbGQgZGV2aWNlIG9mIG9uZSBkZXZpY2UgbGlzdGVkIGluCj4gPiA+ ID4gPiBvZl9kZWZhdWx0X2J1c19tYXRjaF90YWJsZVtdLCB0aGVuIGl0IG1heSBiZSBwb3B1bGF0 ZWQgYnkKPiA+ID4gPiA+IGRyaXZlcnMvb2YvcGxhdGZvcm0uYy4gIEJ1dCwgaW4gbXkgY2FzZSwg c2ltcGxlLW1mZCBkZXZpY2UgaXMgYSBjaGlsZAo+ID4gPiA+ID4gZGV2aWNlIG9mIHNpbXBsZS1w bS1idXMgZGV2aWNlKG5vdCBsaXN0ZWQgaW4gdGhhdCB0YWJsZSksIHNvIGl0IHdpbGwKPiA+ID4g PiA+IG5vdCBiZSBwb3B1bGF0ZWQgYnkgZHJpdmVycy9vZi9wbGF0Zm9ybS5jLiAgSW5zdGVhZCwK PiA+ID4gPiA+IGRyaXZlcnMvYnVzL3NpbXBsZS1wbS1idXMuYyB3b3VsZCBwb3B1bGF0ZSB0aGUg c2ltcGxlLW1mZCBkZXZpY2UuCj4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+IEFsc28sIHRoZSBz aW1wbGUtcG0tYnVzIGRyaXZlciB3b3VsZCBub3QgZW5hYmxlIHJ1bnRpbWUKPiA+ID4gPiA+ID4g PiA+IHBvd2VyIG1hbmFnZW1lbnQgZm9yIHNpbXBsZS1tZmQgZGV2aWNlcyBkdWUgdG8gIk9OTFlf QlVTIiwgd2hpY2gKPiA+ID4gPiA+ID4gPiA+IG1lYW5zIGl0IHdvdWxkIG5vdCBwcm9wYWdhdGUg cG93ZXIgbWFuYWdlbWVudCBvcGVyYXRpb25zIGZyb20gY2hpbGQKPiA+ID4gPiA+ID4gPiA+IGRl dmljZXMgb2Ygc2ltcGxlLW1mZCBkZXZpY2VzIHRvIHBhcmVudCBkZXZpY2VzIG9mIHNpbXBsZS1t ZmQKPiA+ID4gPiA+ID4gPiA+IGRldmljZXMuICBUaGF0J3Mgd2h5IGEgZGVkaWNhdGVkIGZzbC1p bXg4cXhwLWNzciBkcml2ZXIgaXMgbmVlZGVkLgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gVGhp cyBpcyBtb3JlIG9mIGFuIGlzc3VlLgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gV2h5IGNhbid0 IHRoaXMgZGV2aWNlIHVzZSAic2ltcGxlLXBtLWJ1cyIgdG8gaGF2ZSBzdXBwb3J0IGZvciBib3Ro Cj4gPiA+ID4gPiA+IGF1dG8tcmVnaXN0cmF0aW9uIEFORCBSdW50aW1lIFBNPwo+ID4gPiA+ID4g Cj4gPiA+ID4gPiBJZiBJIGNoYW5nZSB0aGUgY29tcGF0aWJsZSBzdHJpbmcgb2YgdGhlIENTUiBt b2R1bGUgZnJvbQo+ID4gPiA+ID4gImZzbCxpbXg4cXhwLW1pcGktbHZkcy1jc3IiLCAic3lzY29u IiwgInNpbXBsZS1tZmQiCj4gPiA+ID4gPiB0bwo+ID4gPiA+ID4gImZzbCxpbXg4cXhwLW1pcGkt bHZkcy1jc3IiLCAic3lzY29uIiwgInNpbXBsZS1wbS1idXMiLAo+ID4gPiA+ID4gYWxsIGRldmlj ZXMgSSdtIGludGVyZXN0ZWQgaW4gYXJlIHBvcHVsYXRlZCBhbmQgYWxsIHJlbGV2YW50IGRyaXZl cnMKPiA+ID4gPiA+IGNhbiBwcm9iZS4gIEJ1dCwgdGhpcyBjaGFuZ2UgbWFrZXMgJ21ha2UgZHRf YmluZGluZ19jaGVjaycgZm9yIHRoZQo+ID4gPiA+ID4gZXhpc3RpbmcgZnNsLGlteDhxeHAtY3Ny LnlhbWwgZmFpbDoKPiA+ID4gPiAKPiA+ID4gPiBBcyAnc2ltcGxlLWJ1cycgaXMgZm9yIE1NSU8g ZGV2aWNlcywgc28gaXMgJ3NpbXBsZS1wbS1idXMnIHdpdGggdGhlCj4gPiA+ID4gYWRkaXRpb24g b2YgUE0gY2FwYWJpbGl0aWVzLiBUaGF0IG1lYW5zIHlvdSBoYXZlIHJlZ2lzdGVycyBkZWZpbmVk Cj4gPiA+ID4gKHJlZyksIGJ1dCB5b3UgZG9uJ3QuCj4gPiA+ID4gCj4gPiA+ID4gRWl0aGVyIHlv dSBoYXZlIGEgYmxvY2sgd2l0aCBtaXhlZCBmdW5jdGlvbnMgb3IgeW91IGhhdmUgc2VwYXJhdGUK PiA+ID4gPiBibG9ja3MuIElmIHRoZSByZWdpc3RlciBzcGFjZSBpcyBhbGwgbWl4ZWQgdG9nZXRo ZXIsIHRoZW4gaXQgaXMgdGhlCj4gPiA+ID4gZm9ybWVyIGFuZCBhbiBNRkQuIERvbid0IGJlIGRl c2lnbmluZyB5b3VyIGJpbmRpbmcgYmFzZWQgb24gTGludXgKPiA+ID4gPiBiZWhhdmlvci4KPiA+ ID4gCj4gPiA+IFRoYW5rcyBmb3IgY2xhcmlmeWluZyBob3cgdG8gZGlmZmVyZXRpYXRlIE1GRCBh bmQgJ3NpbXBsZS1idXMnLydzaW1wbGUtCj4gPiA+IHBtLWJ1cycuICBJIHdvdWxkIHNheSB0aGUg cmVnaXN0ZXIgc3BhY2Ugb2YgdGhlIENTUiBtb2R1bGUgaXMgbWl4ZWQKPiA+ID4gdG9nZXRoZXIs IGUuZy4sIExWRFMgUEhZIGNoaWxkIGRldmljZSBoYXMgYSByZWdpc3RlciBvZmZzZXQgMHgwMCwK PiA+ID4gUFhMMkRQSSBjaGlsZCBkZXZpY2UgaGFzIGEgcmVnaXN0ZXIgb2Zmc2V0IDB4NDAgYW5k IExEQiBjaGlsZCBkZXZpY2UKPiA+ID4gaGFzIHJlZ2lzdGVyIG9mZnNldHMgMHgyMCBhbmQgMHhl MCBpbiBpLk1YOHF4cCBNSVBJIERTSS9MVkRTIGNvbWJvCj4gPiA+IHN1YnN5c3RlbSBDU1IgbW9k dWxlIHJlZ2lzdGVyIHNwYWNlLiAgU28sIGl0IGFwcGVhcnMgdG8gYmUgYSBNRkQuCj4gPiA+IAo+ ID4gPiBMZWUsIHdoYXQgZG8geW91IHRoaW5rPyAgSWYgaXQgaXMgaW5kZWVkIGFuIE1GRCwgYSBu ZXcgTUZEIGRyaXZlciBmb3IKPiA+ID4gdGhlIENTUiBtb2R1bGUgaXMgbmVlZGVkIHRoZW4uCj4g PiAKPiA+IFRoZXJlIGFscmVhZHkgZXhpc3RzIGEgZHJpdmVyIHdoaWNoIGRvZXMgd2hhdCB5b3Ug bmVlZCwgc28gd2h5IGNyZWF0ZQo+ID4gYSAybmQgb25lPyBKdXN0IGFkZCB0aGUgImZzbCxpbXg4 cXhwLW1pcGktbHZkcy1jc3IiIGNvbXBhdGlibGUgdG8gdGhlCj4gPiBzaW1wbGUtcG0tYnVzIG1h dGNoIHRhYmxlIGFuZCBkb24ndCBzZXQgT05MWV9CVVMuIElzbid0IHRoYXQgZW5vdWdoPwo+IAo+ IEFkZGluZyAiZnNsLGlteDhxeHAtbWlwaS1sdmRzLWNzciIgYW5kICJmc2wsaW14OHFtLWx2ZHMt Y3NyIiBjb21wYXRpYmxlCj4gc3RyaW5ncyB0byB0aGUgc2ltcGxlLXBtLWJ1cyBtYXRjaCB0YWJs ZSBkb2VzIHdvcmssIGJ1dCBpdCB0ZW5kcyB0bwo+IG1ha2UgcGVvcGxlIHRoaW5rIHRoZSBDU1Ig bW9kdWxlIGlzIGEgYnVzIGluc3RlYWQgb2YgYSBNRkQuCgpNRkRzIGRvbid0IGV4aXN0LiAgVGhl eSdyZSBhIGZpZ21lbnQgb2Ygb3VyIGltYWdpbmF0aW9uLgoKSWYgeW91IHdhbnQgUE0gZW5hYmxl ZCBhbmQgd2lzaCBmb3IgeW91ciBjaGlsZCBkZXZpY2VzIHRvIGJlCmF1dG8tbWFnaWNhbGx5IHJl Z2lzdGVyZWQgZm9yIHlvdSwgc2ltcGxlLXBtLWJ1cyBpcyB3aGF0IHlvdSBuZWVkLgoKPiBJdCdz IGtpbmthCj4gc3RyYWlnaHRmb3J3YXJkIGlmIGEgTUZEIGRldmljZSBkcml2ZXIgbGl2ZXMgaW4g ZHJpdmVycy9tZmQgZGlyZWN0b3J5Lgo+IEhvd2V2ZXIsIHNpbmNlICJzaW1wbGUtbWZkIiBjb21w YXRpYmxlIGlzIGFsc28gaW4gdGhhdCBtYXRjaCB0YWJsZSwgSQo+IHdvdWxkIGFkZCB0aGUgQ1NS IG1vZHVsZSdzIGNvbXBhdGlibGUgc3RyaW5ncyB0byB0aGF0IG1hdGNoIHRhYmxlIGlmIG5vCj4g b2JqZWN0aW9ucy4KCkZpbmUgYnkgbWUgaWYgaXQgc2F2ZXMgYXV0aG9yaW5nIGEgcG9pbnRsZXNz IGRyaXZlci4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D441EC433FE for ; Wed, 16 Nov 2022 14:02:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233733AbiKPOCZ (ORCPT ); Wed, 16 Nov 2022 09:02:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233143AbiKPOAS (ORCPT ); Wed, 16 Nov 2022 09:00:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECB70209AE for ; Wed, 16 Nov 2022 05:57:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8944E61E1C for ; Wed, 16 Nov 2022 13:57:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0582C433C1; Wed, 16 Nov 2022 13:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668607029; bh=icU4I7RIgRLNY1cWYT1aruWSL+8MqM+CeYHqkxj7G4M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mfcdaHIoG5bad1XTgqtegKoMoni3gJ7rGv0tAdPMtGnmpeFXcdmD95qMfH0WVHlIv 2dL/Yn+4DdsISc9XdDN8loUYubDD4IYeHGwvB/gOoGgEW+8FYaOwAf4m8kFFsrNWoq lib7U6lPDPNE+YkVP2EJJs7dpT++WsUSD9WXJsfU//6Eijw5SIoKjrXtPxI+BOnwAh +u2UP1CrpYQsM+iNXtOgvfO9Y4NCP06dR20DqflU49xk0LpmqOSX2RD4LCkILfTonu Ju7zqNJbta95pi4ejC+XhnmPESECVhFZ7VKy93eD+Vd1dWvQRQ5X7lHqydydBCMNPu tj2RHppy2+jHA== Date: Wed, 16 Nov 2022 13:57:04 +0000 From: Lee Jones To: Liu Ying Cc: Rob Herring , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Subject: Re: [PATCH RESEND] mfd: Add Freescale i.MX8qxp Control and Status Registers (CSR) module driver Message-ID: References: <20221017075702.4182846-1-victor.liu@nxp.com> <4dfb7699c33974a682d798071c85b431b87e5432.camel@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Nov 2022, Liu Ying wrote: > On Tue, 2022-11-15 at 07:33 -0600, Rob Herring wrote: > > On Mon, Nov 14, 2022 at 11:22 PM Liu Ying wrote: > > > On Mon, 2022-11-14 at 14:54 -0600, Rob Herring wrote: > > > > On Mon, Nov 7, 2022 at 9:58 PM Liu Ying wrote: > > > > > Hi Lee, > > > > > > > > > > On Mon, 2022-11-07 at 09:05 +0000, Lee Jones wrote: > > > > > > On Wed, 02 Nov 2022, Liu Ying wrote: > > > > > > > > > > > > > Hi Lee, > > > > > > > > > > > > > > On Tue, 2022-11-01 at 13:53 +0800, Liu Ying wrote: > > > > > > > > Hi Lee, > > > > > > > > > > > > > > > > On Mon, 2022-10-31 at 15:40 +0000, Lee Jones wrote: > > > > > > > > > On Mon, 17 Oct 2022, Liu Ying wrote: > > > > > > > > > > > > > [...] > > > > > > > > > > > > + ret = devm_of_platform_populate(&pdev->dev); > > > > > > > > > > > > > > > > > > The use of this API does not constitute a MFD. > > > > > > > > > > > > > > > > > > Please use "simple-mfd" instead. > > > > > > > > > > > > > > > > simple-mfd devices have "ONLY_BUS" set in simple-pm-bus.c, so the > > > > > > > > simple-pm-bus driver would not populate child devices of simple-mfd > > > > > > > > devices. > > > > > > > > > > > > Right, simple-pm-bus will not populate child devices, because: > > > > > > > > > > simple-pm-bus.c may populate child devices of simple-pm-bus devices > > > > > because "ONLY_BUS" is _not_ set for simple-pm-bus devices. > > > > > > > > > > simple-pm-bus.c would _not_ populate child devices of simple-mfd > > > > > devices because "ONLY_BUS" is set for simple-mfd devices. > > > > > > > > > > > /* > > > > > > * These are transparent bus devices (not simple-pm-bus matches) that > > > > > > * have their child nodes populated automatically. So, don't need to > > > > > > * do anything more. We only match with the device if this driver is > > > > > > * the most specific match because we don't want to incorrectly bind to > > > > > > * a device that has a more specific driver. > > > > > > */ > > > > > > > > > > > > So "simple-mfd" must be populated elsewhere i.e. drivers/of/platform.c. > > > > > > > > > > If simple-mfd device is a child device of one device listed in > > > > > of_default_bus_match_table[], then it may be populated by > > > > > drivers/of/platform.c. But, in my case, simple-mfd device is a child > > > > > device of simple-pm-bus device(not listed in that table), so it will > > > > > not be populated by drivers/of/platform.c. Instead, > > > > > drivers/bus/simple-pm-bus.c would populate the simple-mfd device. > > > > > > > > > > > > > Also, the simple-pm-bus driver would not enable runtime > > > > > > > > power management for simple-mfd devices due to "ONLY_BUS", which > > > > > > > > means it would not propagate power management operations from child > > > > > > > > devices of simple-mfd devices to parent devices of simple-mfd > > > > > > > > devices. That's why a dedicated fsl-imx8qxp-csr driver is needed. > > > > > > > > > > > > This is more of an issue. > > > > > > > > > > > > Why can't this device use "simple-pm-bus" to have support for both > > > > > > auto-registration AND Runtime PM? > > > > > > > > > > If I change the compatible string of the CSR module from > > > > > "fsl,imx8qxp-mipi-lvds-csr", "syscon", "simple-mfd" > > > > > to > > > > > "fsl,imx8qxp-mipi-lvds-csr", "syscon", "simple-pm-bus", > > > > > all devices I'm interested in are populated and all relevant drivers > > > > > can probe. But, this change makes 'make dt_binding_check' for the > > > > > existing fsl,imx8qxp-csr.yaml fail: > > > > > > > > As 'simple-bus' is for MMIO devices, so is 'simple-pm-bus' with the > > > > addition of PM capabilities. That means you have registers defined > > > > (reg), but you don't. > > > > > > > > Either you have a block with mixed functions or you have separate > > > > blocks. If the register space is all mixed together, then it is the > > > > former and an MFD. Don't be designing your binding based on Linux > > > > behavior. > > > > > > Thanks for clarifying how to differetiate MFD and 'simple-bus'/'simple- > > > pm-bus'. I would say the register space of the CSR module is mixed > > > together, e.g., LVDS PHY child device has a register offset 0x00, > > > PXL2DPI child device has a register offset 0x40 and LDB child device > > > has register offsets 0x20 and 0xe0 in i.MX8qxp MIPI DSI/LVDS combo > > > subsystem CSR module register space. So, it appears to be a MFD. > > > > > > Lee, what do you think? If it is indeed an MFD, a new MFD driver for > > > the CSR module is needed then. > > > > There already exists a driver which does what you need, so why create > > a 2nd one? Just add the "fsl,imx8qxp-mipi-lvds-csr" compatible to the > > simple-pm-bus match table and don't set ONLY_BUS. Isn't that enough? > > Adding "fsl,imx8qxp-mipi-lvds-csr" and "fsl,imx8qm-lvds-csr" compatible > strings to the simple-pm-bus match table does work, but it tends to > make people think the CSR module is a bus instead of a MFD. MFDs don't exist. They're a figment of our imagination. If you want PM enabled and wish for your child devices to be auto-magically registered for you, simple-pm-bus is what you need. > It's kinka > straightforward if a MFD device driver lives in drivers/mfd directory. > However, since "simple-mfd" compatible is also in that match table, I > would add the CSR module's compatible strings to that match table if no > objections. Fine by me if it saves authoring a pointless driver. -- Lee Jones [李琼斯]