From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>,
Namjae Jeon <linkinjeon@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>, Jan Kara <jack@suse.com>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
Dave Kleikamp <shaggy@kernel.org>,
Bob Copeland <me@bobcopeland.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
jfs-discussion@lists.sourceforge.net,
linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org
Subject: Re: [PATCH 2/9] ext2: remove ->writepage
Date: Wed, 16 Nov 2022 08:14:15 -0800 [thread overview]
Message-ID: <Y3UMV2mB5BkMM5PY@infradead.org> (raw)
In-Reply-To: <20221114104927.k5x4i4uanxskfs6m@quack3>
On Mon, Nov 14, 2022 at 11:49:27AM +0100, Jan Kara wrote:
> On Sun 13-11-22 17:28:55, Christoph Hellwig wrote:
> > ->writepage is a very inefficient method to write back data, and only
> > used through write_cache_pages or a a fallback when no ->migrate_folio
> > method is present.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Looks good! Feel free to add:
The testbot found a problem with this:
ext2_commit_chunk calls write_one_page for the IS_DIRSYNC case,
and write_one_page calls ->writepage.
So I think I need to drop this one for now (none of the other
file systems calls write_one_page). And then think what best
to do about write_one_page/write_one_folio. I suspect just
passing a writepage pointer to them might make most sense,
as they are only used by a few file systems, and the calling
convention with the locked page doesn't lend itself to using
->writepages.
next prev parent reply other threads:[~2022-11-16 16:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 16:28 start removing writepage instances Christoph Hellwig
2022-11-13 16:28 ` [PATCH 1/9] extfat: remove ->writepage Christoph Hellwig
2022-11-14 11:07 ` Namjae Jeon
2022-11-13 16:28 ` [PATCH 2/9] ext2: " Christoph Hellwig
2022-11-14 10:49 ` Jan Kara
2022-11-16 16:14 ` Christoph Hellwig [this message]
2022-11-16 18:20 ` [PATCH 2/9] ext2: remove ->writepageo Jan Kara
2022-11-17 6:31 ` Christoph Hellwig
2022-11-21 10:07 ` Jan Kara
2022-11-13 16:28 ` [PATCH 3/9] fat: remove ->writepage Christoph Hellwig
2022-11-13 16:28 ` [PATCH 4/9] hfs: " Christoph Hellwig
2023-12-14 19:01 ` Matthew Wilcox
2023-12-15 4:59 ` Christoph Hellwig
2022-11-13 16:28 ` [PATCH 5/9] hfsplus: " Christoph Hellwig
2022-11-13 16:28 ` [PATCH 6/9] hpfs: " Christoph Hellwig
2022-11-13 16:29 ` [PATCH 7/9] jfs: " Christoph Hellwig
2022-11-14 14:29 ` Dave Kleikamp
2022-11-13 16:29 ` [PATCH 8/9] omfs: " Christoph Hellwig
2022-11-15 2:34 ` Bob Copeland
2022-11-13 16:29 ` [PATCH 9/9] udf: " Christoph Hellwig
2022-11-14 10:52 ` Jan Kara
2022-11-14 20:29 ` start removing writepage instances Johannes Weiner
2022-11-16 18:39 ` Ritesh Harjani (IBM)
2022-11-17 21:41 ` David Howells
2022-12-02 10:22 ` Christoph Hellwig
2022-11-17 21:39 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3UMV2mB5BkMM5PY@infradead.org \
--to=hch@infradead.org \
--cc=hch@lst.de \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linkinjeon@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-karma-devel@lists.sourceforge.net \
--cc=linux-mm@kvack.org \
--cc=me@bobcopeland.com \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=shaggy@kernel.org \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.