From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Prashant Laddha <prladdha@cisco.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] fixp-arith: do not require users to include bug.h
Date: Wed, 16 Nov 2022 15:54:02 -0800 [thread overview]
Message-ID: <Y3V4Gt3OVR1BQ2/W@google.com> (raw)
In-Reply-To: <Y3SgVdVey9legtX+@dc75zzyyyyyyyyyyyyydt-3.rev.dnainternet.fi>
On Wed, Nov 16, 2022 at 10:33:25AM +0200, Matti Vaittinen wrote:
> The fixp_sin32_rad()() contains a call to BUG_ON(). If users of
> fixp-arith.h have not included the bug.h prior including the fixp-arith.h
> the compiler will not find the BUG_ON. Thus every user of fixp-arith.h
> must also include bug.h (or roll own variant of BUG_ON()).
>
> Include bug.h from fixp-arith.h so every user of fixp-arith.h does not
> need to include the bug.h prior inclusion of fixp-arith.h
>
> Fixes: 559addc25b00 ("[media] fixp-arith: replace sin/cos table by a better precision one")
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2022-11-16 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 8:33 [PATCH RESEND] fixp-arith: do not require users to include bug.h Matti Vaittinen
2022-11-16 23:54 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3V4Gt3OVR1BQ2/W@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mchehab@kernel.org \
--cc=prladdha@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.