From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D3A7C4321E for ; Thu, 17 Nov 2022 00:44:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233958AbiKQAoR (ORCPT ); Wed, 16 Nov 2022 19:44:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233963AbiKQAoQ (ORCPT ); Wed, 16 Nov 2022 19:44:16 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1C802B622; Wed, 16 Nov 2022 16:44:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 71B77B81F6A; Thu, 17 Nov 2022 00:44:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D214C433C1; Thu, 17 Nov 2022 00:44:01 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="N4yvuS4q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1668645839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o11kryBEJKQUBcciv1YGNpGcl9GzU1jQr08TEiO/WZo=; b=N4yvuS4qyMfxtARqyPHRBhk1SEXxz/3WJew88lI6NMO4+fa/MCaJBZuB/2QrKCXtuhKI0R o+j7S1e3eQB22ynfMfsCp3AmUWUXzjYsWW7wUl/69cBI5Z/naX7VjRMFejW8Owc2sNFQI3 bMKj7v4gh+/iKlR/7cv7MrrI9ssFAS8= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 39d4929e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 17 Nov 2022 00:43:58 +0000 (UTC) Date: Thu, 17 Nov 2022 01:43:54 +0100 From: "Jason A. Donenfeld" To: Kees Cook Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, Greg Kroah-Hartman , Jakub Kicinski , Russell King , Catalin Marinas , Thomas Bogendoerfer , Heiko Carstens , Herbert Xu , Christoph =?utf-8?Q?B=C3=B6hmwalder?= , Jani Nikula , Jason Gunthorpe , Sakari Ailus , "Martin K . Petersen" , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Richard Weinberger , "Darrick J . Wong" , SeongJae Park , Thomas Gleixner , Andrew Morton , Michael Ellerman , Helge Deller , netdev@vger.kernel.org, linux-crypto@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mmc@vger.kernel.org, linux-parisc@vger.kernel.org, ydroneaud@opteya.com Subject: Re: [PATCH v2 3/3] treewide: use get_random_u32_between() when possible Message-ID: References: <20221114164558.1180362-1-Jason@zx2c4.com> <20221114164558.1180362-4-Jason@zx2c4.com> <202211161436.A45AD719A@keescook> <202211161628.164F47F@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202211161628.164F47F@keescook> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Nov 16, 2022 at 04:31:18PM -0800, Kees Cook wrote: > On Thu, Nov 17, 2022 at 01:03:14AM +0100, Jason A. Donenfeld wrote: > > On Thu, Nov 17, 2022 at 12:55:47AM +0100, Jason A. Donenfeld wrote: > > > 2) What to call it: > > > - between I still like, because it mirrors "I'm thinking of a number > > > between 1 and 10 and..." that everybody knows, > > > - inclusive I guess works, but it's not a preposition, > > > - bikeshed color #3? > > > > - between > > - ranged > > - spanning > > > > https://www.thefreedictionary.com/List-of-prepositions.htm > > - amid > > > > Sigh, names. > > I think "inclusive" is best. I find it not very descriptive of what the function does. Is there one you like second best? Or are you convinced they're all much much much worse than "inclusive" that they shouldn't be considered? Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 120FAC4332F for ; Thu, 17 Nov 2022 00:45:04 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NCLmH00d7z3dtv for ; Thu, 17 Nov 2022 11:45:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=zx2c4.com header.i=@zx2c4.com header.a=rsa-sha256 header.s=20210105 header.b=N4yvuS4q; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=srs0=dvcg=3r=zx2c4.com=jason@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=zx2c4.com header.i=@zx2c4.com header.a=rsa-sha256 header.s=20210105 header.b=N4yvuS4q; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NCLlG48mZz30Ky for ; Thu, 17 Nov 2022 11:44:10 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6B0EDB81F5C; Thu, 17 Nov 2022 00:44:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D214C433C1; Thu, 17 Nov 2022 00:44:01 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="N4yvuS4q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1668645839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o11kryBEJKQUBcciv1YGNpGcl9GzU1jQr08TEiO/WZo=; b=N4yvuS4qyMfxtARqyPHRBhk1SEXxz/3WJew88lI6NMO4+fa/MCaJBZuB/2QrKCXtuhKI0R o+j7S1e3eQB22ynfMfsCp3AmUWUXzjYsWW7wUl/69cBI5Z/naX7VjRMFejW8Owc2sNFQI3 bMKj7v4gh+/iKlR/7cv7MrrI9ssFAS8= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 39d4929e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 17 Nov 2022 00:43:58 +0000 (UTC) Date: Thu, 17 Nov 2022 01:43:54 +0100 From: "Jason A. Donenfeld" To: Kees Cook Subject: Re: [PATCH v2 3/3] treewide: use get_random_u32_between() when possible Message-ID: References: <20221114164558.1180362-1-Jason@zx2c4.com> <20221114164558.1180362-4-Jason@zx2c4.com> <202211161436.A45AD719A@keescook> <202211161628.164F47F@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202211161628.164F47F@keescook> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Darrick J . Wong" , patches@lists.linux.dev, netdev@vger.kernel.org, Andreas Dilger , ydroneaud@opteya.com, Herbert Xu , Richard Weinberger , Helge Deller , Russell King , Jason Gunthorpe , Catalin Marinas , Jakub Kicinski , linux-mips@vger.kernel.org, linux-media@vger.kernel.org, Heiko Carstens , Jani Nikula , linux-block@vger.kernel.org, SeongJae Park , loongarch@lists.linux.dev, Jaegeuk Kim , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Theodore Ts'o , linux-parisc@vger.kernel.org, "Martin K . Petersen" , Greg Kroah-Hartman , linux-mmc@vger.kernel.org, linux-kerne l@vger.kernel.org, Christoph =?utf-8?Q?B=C3=B6hmwalder?= , linux-crypto@vger.kernel.org, Sakari Ailus , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Nov 16, 2022 at 04:31:18PM -0800, Kees Cook wrote: > On Thu, Nov 17, 2022 at 01:03:14AM +0100, Jason A. Donenfeld wrote: > > On Thu, Nov 17, 2022 at 12:55:47AM +0100, Jason A. Donenfeld wrote: > > > 2) What to call it: > > > - between I still like, because it mirrors "I'm thinking of a number > > > between 1 and 10 and..." that everybody knows, > > > - inclusive I guess works, but it's not a preposition, > > > - bikeshed color #3? > > > > - between > > - ranged > > - spanning > > > > https://www.thefreedictionary.com/List-of-prepositions.htm > > - amid > > > > Sigh, names. > > I think "inclusive" is best. I find it not very descriptive of what the function does. Is there one you like second best? Or are you convinced they're all much much much worse than "inclusive" that they shouldn't be considered? Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DC2AC433FE for ; Thu, 17 Nov 2022 00:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U7VQG9RWbDIv9S7U05yO9AX5v8jGO9sbIiYQMMgMlw8=; b=K5KlBF1vfCWcOp baBl1JdfQnRCSnpUimiBTCKkqkUgEptEYHS7xuSB0gt8Uo1O/IHGDyiBTVgw+/ko8tjJ5oT9tc7Kl 4NzoRU7B5+yDdMw0R56RShzW79TFsx3MODcObVkApViFcKNBw4qHxcyR9qdw6evp6QkgR0tYxjDL7 s8lZeNTq5m8tqy7KC3oLgUMdqPU/CvAMq6ISnLC/+hw+xlByYZ3hY43it06nEp0fJaLuGgOWs5KsY sQSzjlBd1dC4eE0s2L9T+/OwU5lTkVt7JxukORaLbNJYwuawztdUs0BukOb8Khkbtz1Fy5/pH6oGh LlwbMTs8IjT8KipjnsWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovT0m-009E3u-0E; Thu, 17 Nov 2022 00:44:12 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovT0i-009E3B-I6 for linux-arm-kernel@lists.infradead.org; Thu, 17 Nov 2022 00:44:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6B0EDB81F5C; Thu, 17 Nov 2022 00:44:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D214C433C1; Thu, 17 Nov 2022 00:44:01 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="N4yvuS4q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1668645839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o11kryBEJKQUBcciv1YGNpGcl9GzU1jQr08TEiO/WZo=; b=N4yvuS4qyMfxtARqyPHRBhk1SEXxz/3WJew88lI6NMO4+fa/MCaJBZuB/2QrKCXtuhKI0R o+j7S1e3eQB22ynfMfsCp3AmUWUXzjYsWW7wUl/69cBI5Z/naX7VjRMFejW8Owc2sNFQI3 bMKj7v4gh+/iKlR/7cv7MrrI9ssFAS8= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 39d4929e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 17 Nov 2022 00:43:58 +0000 (UTC) Date: Thu, 17 Nov 2022 01:43:54 +0100 From: "Jason A. Donenfeld" To: Kees Cook Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, Greg Kroah-Hartman , Jakub Kicinski , Russell King , Catalin Marinas , Thomas Bogendoerfer , Heiko Carstens , Herbert Xu , Christoph =?utf-8?Q?B=C3=B6hmwalder?= , Jani Nikula , Jason Gunthorpe , Sakari Ailus , "Martin K . Petersen" , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Richard Weinberger , "Darrick J . Wong" , SeongJae Park , Thomas Gleixner , Andrew Morton , Michael Ellerman , Helge Deller , netdev@vger.kernel.org, linux-crypto@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mmc@vger.kernel.org, linux-parisc@vger.kernel.org, ydroneaud@opteya.com Subject: Re: [PATCH v2 3/3] treewide: use get_random_u32_between() when possible Message-ID: References: <20221114164558.1180362-1-Jason@zx2c4.com> <20221114164558.1180362-4-Jason@zx2c4.com> <202211161436.A45AD719A@keescook> <202211161628.164F47F@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202211161628.164F47F@keescook> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221116_164408_820174_BD4B1745 X-CRM114-Status: GOOD ( 17.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 16, 2022 at 04:31:18PM -0800, Kees Cook wrote: > On Thu, Nov 17, 2022 at 01:03:14AM +0100, Jason A. Donenfeld wrote: > > On Thu, Nov 17, 2022 at 12:55:47AM +0100, Jason A. Donenfeld wrote: > > > 2) What to call it: > > > - between I still like, because it mirrors "I'm thinking of a number > > > between 1 and 10 and..." that everybody knows, > > > - inclusive I guess works, but it's not a preposition, > > > - bikeshed color #3? > > > > - between > > - ranged > > - spanning > > > > https://www.thefreedictionary.com/List-of-prepositions.htm > > - amid > > > > Sigh, names. > > I think "inclusive" is best. I find it not very descriptive of what the function does. Is there one you like second best? Or are you convinced they're all much much much worse than "inclusive" that they shouldn't be considered? Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel