From: Klaus Jensen <its@irrelevant.dk>
To: Joel Granados <j.granados@samsung.com>
Cc: k.jensen@samsung.com, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v2 3/3] nvme: Add physical writes/reads from OCP log
Date: Thu, 17 Nov 2022 07:36:15 +0100 [thread overview]
Message-ID: <Y3XWX0Xx//40pidS@cormorant.local> (raw)
In-Reply-To: <20221116161921.2bym6wtu6xmkanzo@localhost>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
On Nov 16 17:19, Joel Granados wrote:
> On Tue, Nov 15, 2022 at 12:26:17PM +0100, Klaus Jensen wrote:
> > On Nov 14 14:50, Joel Granados wrote:
> > >
> > > +static uint16_t nvme_vendor_specific_log(uint8_t lid, NvmeCtrl *n, uint8_t rae,
> > > + uint32_t buf_len, uint64_t off,
> > > + NvmeRequest *req)
> >
> > `NvmeCtrl *n` must be first parameter.
> Any reason why this is the case? I'll change it in my code, but would be
> nice to understand the reason.
>
No other reason than consistency with existing code.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-11-17 6:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221114135426eucas1p271a54e44af5a53a45a7393ed34585ee0@eucas1p2.samsung.com>
2022-11-14 13:50 ` [PATCH v2 0/3] Add OCP extended log to nvme QEMU Joel Granados
2022-11-14 13:50 ` [PATCH v2 1/3] nvme: Move adjustment of data_units{read,written} Joel Granados
2022-11-15 11:09 ` Klaus Jensen
2022-11-14 13:50 ` [PATCH v2 2/3] nvme: Add ocp to the subsys Joel Granados
2022-11-15 11:11 ` Klaus Jensen
2022-11-16 15:02 ` Joel Granados
2022-11-14 13:50 ` [PATCH v2 3/3] nvme: Add physical writes/reads from OCP log Joel Granados
2022-11-15 11:26 ` Klaus Jensen
2022-11-16 16:19 ` Joel Granados
2022-11-17 6:36 ` Klaus Jensen [this message]
2022-12-23 7:39 ` [PATCH v2 0/3] Add OCP extended log to nvme QEMU Christoph Hellwig
2023-01-04 14:43 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3XWX0Xx//40pidS@cormorant.local \
--to=its@irrelevant.dk \
--cc=j.granados@samsung.com \
--cc=k.jensen@samsung.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.