From: Hangbin Liu <liuhangbin@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
netdev@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH (repost) net-next] sched: add extack for tfilter_notify
Date: Thu, 17 Nov 2022 16:42:09 +0800 [thread overview]
Message-ID: <Y3Xz4W0WotfLoaaC@Laptop-X1> (raw)
In-Reply-To: <CAM0EoMk_LdcSLAeQ8kLTaWNDXFe7HgBcOxZpDPtk68+TdER-Zg@mail.gmail.com>
On Tue, Nov 15, 2022 at 11:26:54AM -0500, Jamal Hadi Salim wrote:
> Ok, I think i get what Jakub meant by "internal / netlink level attributes" now.
> i.e the problem is there is a namespace collision for attributes between
> the global NLMSG_ERROR and service local. It is more tricky than i thought.
> How were you thinking of storing the extack info into the message?
Not sure, I will have a try first. FYI, Next week I will be in vacation.
So there would be some delay on this...
> Note: I wouldnt touch netlink_ack() - maybe write a separate helper for events.
Hmm, OK, I will try not touch netlink_ack().
Thanks
Hangbin
next prev parent reply other threads:[~2022-11-17 8:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 3:35 [PATCH (repost) net-next] sched: add extack for tfilter_notify Hangbin Liu
2022-10-01 2:03 ` Jakub Kicinski
2022-10-01 18:39 ` Cong Wang
2022-10-01 20:39 ` Marcelo Ricardo Leitner
2022-10-02 15:27 ` Jamal Hadi Salim
2022-10-26 9:58 ` Hangbin Liu
2022-11-02 1:26 ` Hangbin Liu
2022-11-02 15:33 ` Jamal Hadi Salim
2022-11-02 23:36 ` Jakub Kicinski
2022-11-04 2:39 ` Hangbin Liu
2022-11-08 9:11 ` Hangbin Liu
2022-11-08 18:55 ` Jakub Kicinski
2022-11-09 11:53 ` Hangbin Liu
2022-11-10 1:52 ` Jamal Hadi Salim
2022-11-10 2:20 ` Jakub Kicinski
2022-11-10 6:29 ` Hangbin Liu
2022-11-10 17:12 ` Jakub Kicinski
2022-11-10 14:27 ` Jamal Hadi Salim
2022-11-10 17:27 ` Jakub Kicinski
2022-11-15 3:07 ` Hangbin Liu
2022-11-15 4:51 ` Jakub Kicinski
2022-11-15 12:42 ` Jamal Hadi Salim
2022-11-15 12:44 ` Hangbin Liu
2022-11-15 13:13 ` Jamal Hadi Salim
2022-11-15 13:57 ` Hangbin Liu
2022-11-15 16:26 ` Jamal Hadi Salim
2022-11-17 8:42 ` Hangbin Liu [this message]
2022-11-29 8:07 ` Hangbin Liu
2022-11-29 15:43 ` Jakub Kicinski
2022-11-30 8:44 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3Xz4W0WotfLoaaC@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.