From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Anastasia Belova <abelova@astralinux.ru>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Jiasheng Jiang <jiasheng@iscas.ac.cn>,
Teppei Kamijou <teppei.kamijou.yb@renesas.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>,
Chris Ball <cjb@laptop.org>, "open list:MULTIMEDIA CARD (MMC),
SECURE DIGITAL (SD) AND..." <linux-mmc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] mmc: sh_mmcif: Add check for NULL for host->chan_yx and host->chan_rx in sh_mmcif_end_cmd
Date: Thu, 17 Nov 2022 14:50:38 +0100 [thread overview]
Message-ID: <Y3Y8LvvaOQ/n7pg9@ninjato> (raw)
In-Reply-To: <20221117123007.13071-1-abelova@astralinux.ru>
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
On Thu, Nov 17, 2022 at 03:30:07PM +0300, Anastasia Belova wrote:
> Without these checks NULL-pointer may be dereferenced in
> sh_mmcif_end_cmd parameters inside if (data->flags & MMC_DATA_READ).
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
Is there a code path actually triggering it? I wonder because it seems
to me the check for valid channels is already done a little above when
DMA is started. And I'd assume once DMA has been started we can take for
granted that we have a valid channel when unmapping. But maybe I am
missing some error codepath?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-11-17 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 12:30 [PATCH] mmc: sh_mmcif: Add check for NULL for host->chan_yx and host->chan_rx in sh_mmcif_end_cmd Anastasia Belova
2022-11-17 13:50 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3Y8LvvaOQ/n7pg9@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=abelova@astralinux.ru \
--cc=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=geert+renesas@glider.be \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=shinya.kuribayashi.px@renesas.com \
--cc=teppei.kamijou.yb@renesas.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.