From: Lee Jones <lee@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] Input: max8997 - Convert to modern way to get a reference to a PWM
Date: Thu, 17 Nov 2022 10:13:27 +0000 [thread overview]
Message-ID: <Y3YJR4hIRdDacrkh@google.com> (raw)
In-Reply-To: <20221117073543.3790449-1-u.kleine-koenig@pengutronix.de>
On Thu, 17 Nov 2022, Uwe Kleine-König wrote:
> pwm_request() isn't recommended to be used any more because it relies on
> global IDs for the PWM which comes with different difficulties.
>
> The new way to do things is to find the right PWM using a reference from
> the platform device. (This can be created either using a device-tree
> or a platform lookup table, see e.g. commit 5a4412d4a82f ("ARM: pxa:
> tavorevb: Use PWM lookup table") how to do this.)
>
> There are no in-tree users, so there are no other code locations that need
> adaption.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/input/misc/max8997_haptic.c | 7 +++----
> include/linux/mfd/max8997.h | 3 ---
Acked-by: Lee Jones <lee@kernel.org>
> 2 files changed, 3 insertions(+), 7 deletions(-)
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-11-17 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 7:35 [PATCH] Input: max8997 - Convert to modern way to get a reference to a PWM Uwe Kleine-König
2022-11-17 10:13 ` Lee Jones [this message]
2022-11-18 6:18 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3YJR4hIRdDacrkh@google.com \
--to=lee@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.