From: asmadeus@codewreck.org
To: GUO Zihua <guozihua@huawei.com>
Cc: ericvh@gmail.com, lucho@ionkov.net, linux_oss@crudebyte.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, v9fs-developer@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: [PATCH 0/3 v2] 9p: Fix write overflow in p9_read_work
Date: Thu, 17 Nov 2022 19:49:28 +0900 [thread overview]
Message-ID: <Y3YRuHnkULT1Ti3l@codewreck.org> (raw)
In-Reply-To: <20221117091159.31533-1-guozihua@huawei.com>
GUO Zihua wrote on Thu, Nov 17, 2022 at 05:11:56PM +0800:
> This patchset fixes the write overflow issue in p9_read_work. As well as
> some follow up cleanups.
Thanks for this v2.
Comments below
> GUO Zihua (3):
> 9p: Fix write overflow in p9_read_work
> 9p: Remove redundent checks for message size against msize.
This has 'Fixes: 3da2e34b64cd ("9p: Fix write overflow in
p9_read_work")' but that commit isn't applied yet, so the commit hash
only exists in your tree -- I will get a different hash when I apply the
patch (because it'll contain my name as committer, date changed etc)
I don't think it really makes sense to separate these two patches, I'll
squash them together on my side.
> 9p: Use P9_HDRSZ for header size
This makes sense to keep separate, I'll just drop the 'fixes' tag for
the same reason as above
I'll do the squash & test tomorrow, you don't need to resend.
I will tell you when I push to next so you can check you're happy with
my version.
--
Dominique
next prev parent reply other threads:[~2022-11-17 10:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 9:11 [PATCH 0/3 v2] 9p: Fix write overflow in p9_read_work GUO Zihua
2022-11-17 9:11 ` [PATCH 1/3 " GUO Zihua
2022-11-17 9:11 ` [PATCH 2/3 v2] 9p: Remove redundent checks for message size against msize GUO Zihua
2022-11-17 9:11 ` [PATCH 3/3 v2] 9p: Use P9_HDRSZ for header size GUO Zihua
2022-11-17 10:49 ` asmadeus [this message]
2022-11-17 10:54 ` [PATCH 0/3 v2] 9p: Fix write overflow in p9_read_work Guozihua (Scott)
2022-11-17 13:33 ` Christian Schoenebeck
2022-11-18 4:59 ` asmadeus
2022-11-18 10:18 ` Guozihua (Scott)
2022-11-18 13:57 ` asmadeus
2022-11-18 15:34 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3YRuHnkULT1Ti3l@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericvh@gmail.com \
--cc=guozihua@huawei.com \
--cc=kuba@kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.