Re: [PATCH RFC v2 2/3] pinconf-generic: clarify pull up and pull down config values

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, Nov 17, 2022 at 11:53:55AM +0000, Niyas Sait wrote:
> Sorry for the newbie issues. Somehow I missed the space vs tab issue on that
> patch.

No problem.

> I will send a patch to fix the two issues.

One more newbie thing you should address in your replies is stop top-posting.

> On 17/11/2022 10:39, Andy Shevchenko wrote:
> > On Thu, Nov 17, 2022 at 12:37:44PM +0200, Andy Shevchenko wrote:
> > > On Thu, Nov 17, 2022 at 10:30:37AM +0100, Linus Walleij wrote:
> > > > On Tue, Nov 15, 2022 at 6:54 PM Niyas Sait <niyas.sait@linaro.org> wrote:
> > > > 
> > > > > PIN_CONFIG_BIAS_PULL_DOWN and PIN_CONFIG_BIAS_PULL_UP values can
> > > > > be custom or an SI unit such as ohms
> > > > > 
> > > > > Signed-off-by: Niyas Sait <niyas.sait@linaro.org>
> > > > 
> > > > This patch is good as-is so I just applied it. No need to resend with
> > > > the ACPI series.
> > > 
> > > Is it? I think it's visible that it has TAB vs. space issue...
> > 
> > To be more clear, the "such as ohms" have been indented with spaces, while
> > everything else with TABs. On top of that I would use proper capitalization
> > for unit, i.e. Ohms. But the latter is minor.

-- 
With Best Regards,
Andy Shevchenko