From: Dan Carpenter <error27@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Daniel Machon <daniel.machon@microchip.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: microchip: sparx5: prevent uninitialized variable
Date: Thu, 17 Nov 2022 18:29:28 +0300 [thread overview]
Message-ID: <Y3ZTWIas5BSxwyg8@kadam> (raw)
In-Reply-To: <519cbacf20b10909ee362e0bcc9aa87cbb7137f3.camel@redhat.com>
On Thu, Nov 17, 2022 at 04:03:07PM +0100, Paolo Abeni wrote:
> Hello,
>
> On Tue, 2022-11-15 at 16:14 +0300, Dan Carpenter wrote:
> > Smatch complains that:
> >
> > drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c:112
> > sparx5_dcb_apptrust_validate() error: uninitialized symbol 'match'.
> >
> > This would only happen if the:
> >
> > if (sparx5_dcb_apptrust_policies[i].nselectors != nselectors)
> >
> > condition is always true (they are not equal). The "nselectors"
> > variable comes from dcbnl_ieee_set() and it is a number between 0-256.
> > This seems like a probably a real bug.
> >
> > Fixes: 23f8382cd95d ("net: microchip: sparx5: add support for apptrust")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> checkpatch complains about the From/SoB mismatch -
> 'Dan Carpenter <error27@gmail.com>' vs 'Dan Carpenter
> <dan.carpenter@oracle.com>'
>
> Could you please send a v2 addressing that?
Oops. Sorry. Resent.
regards,
dan carpenter
prev parent reply other threads:[~2022-11-17 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 13:14 [PATCH net-next] net: microchip: sparx5: prevent uninitialized variable Dan Carpenter
2022-11-16 7:09 ` Daniel.Machon
2022-11-17 15:03 ` Paolo Abeni
2022-11-17 15:29 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3ZTWIas5BSxwyg8@kadam \
--to=error27@gmail.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.