From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 267AFC4332F for ; Thu, 17 Nov 2022 20:39:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240452AbiKQUjW (ORCPT ); Thu, 17 Nov 2022 15:39:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240402AbiKQUjR (ORCPT ); Thu, 17 Nov 2022 15:39:17 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6ADE8CB97 for ; Thu, 17 Nov 2022 12:39:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=q3yu0qYDt1QjL+h7m5DHpsVVuZF/axUTSk6QNL2WIcU=; b=UTnT1wiDx+eXiA+9eLVANPPzVU yQgZF1gtVnD6lAe69nBK744nz5PpADl90qS216OYajsPBffup73SxNkRgWnMpz6xwSo+EqngA8SKg uGwn2u6jiXGgfJCcOBiEu/tJOodFrXtVyw0oQy2L9MrwFOPt1FmTIk6iVMPZ3zSEjjU0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ovlfD-002jBD-4y; Thu, 17 Nov 2022 21:39:11 +0100 Date: Thu, 17 Nov 2022 21:39:11 +0100 From: Andrew Lunn To: Gerhard Engleder Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, edumazet@google.com, pabeni@redhat.com Subject: Re: [PATCH net-next 2/4] tsnep: Fix rotten packets Message-ID: References: <20221117201440.21183-1-gerhard@engleder-embedded.com> <20221117201440.21183-3-gerhard@engleder-embedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221117201440.21183-3-gerhard@engleder-embedded.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Nov 17, 2022 at 09:14:38PM +0100, Gerhard Engleder wrote: > If PTP synchronisation is done every second, then sporadic the interval > is higher than one second: > > ptp4l[696.582]: master offset -17 s2 freq -1891 path delay 573 > ptp4l[697.582]: master offset -22 s2 freq -1901 path delay 573 > ptp4l[699.368]: master offset -1 s2 freq -1887 path delay 573 > ^^^^^^^ Should be 698.582! > > This problem is caused by rotten packets, which are received after > polling but before interrupts are enabled again. Is this a hardware bug? At the end of the interrupt coalescence period, should it not check the queue and fire an interrupt? Andrew