From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED31FC433FE for ; Fri, 18 Nov 2022 00:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xdT+lfXtxUSnYj/JzxBeoVKtLm75OFDcqJUBQ8YurMw=; b=Et0AVHmZEA7EBY iZ3qYb3wM7pIvDMKu1RzICFisImUd+aP8dJsMbKnxzFqF7dB0V5ndu6Nqm8YDrB8/q77kcmR3cPVr SJHMEnDqEkr8ICeh7ID04RS/5La6RXm6hmOkwx9s1gA9qzChiDpBYV6ArmGljeTqmV3Qw4TAWkQ+T m5QHBXW1SuuQUfLwpiVVGIqNFTlVdVW6lvgtENeXwxrUI62u4oGZtQvAc5oVEWeV44Sy83T+t4pn/ RiKlLWOuhoXou6+4cjM2ZQHv8qlMjxTt3dt5+8DwtBE87nGqwebMgauXHAcHpcXNrWgfIs2UjacsA fQrNWysI6Y3y4xyazXhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovpDv-000tut-Dn; Fri, 18 Nov 2022 00:27:15 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovpDt-000tuP-Lg for linux-arm-kernel@lists.infradead.org; Fri, 18 Nov 2022 00:27:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=AFV+7ApdCBOIGMsVLFPQM1I3SArzUFkwUjMk4P2eK8w=; b=X6077zp2pInx/2693TTYUli8jc K1IozKW9lf//AlSauzYixSYibR+yER5K2jUKT2bTBxo/z/UjY4j+bvuYpepGqSpbnHxVQpu3OvnVb co/aL/GMA5ywbNuKLFioh+8JWZwAE3MqHB1+Nyq4vlI4oUd/oN3/LtBXudyoi5eHBoIs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ovpDr-002kI9-Lp; Fri, 18 Nov 2022 01:27:11 +0100 Date: Fri, 18 Nov 2022 01:27:11 +0100 From: Andrew Lunn To: Tim Harvey Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Heiner Kallweit , Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski Subject: Re: [PATCH 0/3] add dt configuration for dp83867 led modes Message-ID: References: <20221118001548.635752-1-tharvey@gateworks.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221118001548.635752-1-tharvey@gateworks.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_162713_725260_A7EBCB67 X-CRM114-Status: GOOD ( 10.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 17, 2022 at 04:15:45PM -0800, Tim Harvey wrote: > This series adds a dt-prop ti,led-modes to configure dp83867 PHY led > modes, adds the code to implement it, and updates some board dt files > to use the new property. Sorry, but NACK. We need PHY leds to be controlled via /sys/class/leds. Everybody keeps trying to add there own way to configure these things, rather than have just one uniform way which all PHYs share. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F0DBC4332F for ; Fri, 18 Nov 2022 00:27:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232330AbiKRA1Q (ORCPT ); Thu, 17 Nov 2022 19:27:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbiKRA1P (ORCPT ); Thu, 17 Nov 2022 19:27:15 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 748CD6BDC4; Thu, 17 Nov 2022 16:27:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=AFV+7ApdCBOIGMsVLFPQM1I3SArzUFkwUjMk4P2eK8w=; b=X6077zp2pInx/2693TTYUli8jc K1IozKW9lf//AlSauzYixSYibR+yER5K2jUKT2bTBxo/z/UjY4j+bvuYpepGqSpbnHxVQpu3OvnVb co/aL/GMA5ywbNuKLFioh+8JWZwAE3MqHB1+Nyq4vlI4oUd/oN3/LtBXudyoi5eHBoIs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ovpDr-002kI9-Lp; Fri, 18 Nov 2022 01:27:11 +0100 Date: Fri, 18 Nov 2022 01:27:11 +0100 From: Andrew Lunn To: Tim Harvey Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Heiner Kallweit , Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski Subject: Re: [PATCH 0/3] add dt configuration for dp83867 led modes Message-ID: References: <20221118001548.635752-1-tharvey@gateworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221118001548.635752-1-tharvey@gateworks.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Nov 17, 2022 at 04:15:45PM -0800, Tim Harvey wrote: > This series adds a dt-prop ti,led-modes to configure dp83867 PHY led > modes, adds the code to implement it, and updates some board dt files > to use the new property. Sorry, but NACK. We need PHY leds to be controlled via /sys/class/leds. Everybody keeps trying to add there own way to configure these things, rather than have just one uniform way which all PHYs share. Andrew