From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ferry Toth <ftoth@exalondelft.nl>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Sean Anderson <sean.anderson@seco.com>,
Liu Shixin <liushixin2@huawei.com>, Ferry Toth <fntoth@gmail.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v3 1/2] usb: ulpi: defer ulpi_register on ulpi_read_id timeout
Date: Fri, 18 Nov 2022 12:31:49 +0200 [thread overview]
Message-ID: <Y3dfFX0P9n2lndCL@smile.fi.intel.com> (raw)
In-Reply-To: <20221117205411.11489-2-ftoth@exalondelft.nl>
On Thu, Nov 17, 2022 at 09:54:10PM +0100, Ferry Toth wrote:
> Since commit 0f010171
> Dual Role support on Intel Merrifield platform broke due to rearranging
> the call to dwc3_get_extcon().
Not sure why format is broken, you may add into your ~/.gitconfig
[core]
abbrev = 12
[alias]
one = show -s --pretty='format:%h (\"%s\")'
and run
git one 0f010171
with the result
0f0101719138 ("usb: dwc3: Don't switch OTG -> peripheral if extcon is present")
> It appears to be caused by ulpi_read_id() on the first test write failing
> with -ETIMEDOUT. Currently ulpi_read_id() expects to discover the phy via
> DT when the test write fails and returns 0 in that case even if DT does not
> provide the phy. As a result usb probe completes without phy.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-18 10:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 20:54 [PATCH v3 0/2] usb: dwc3: core: defer probe on ulpi_read_id timeout Ferry Toth
2022-11-17 20:54 ` [PATCH v3 1/2] usb: ulpi: defer ulpi_register " Ferry Toth
2022-11-18 10:31 ` Andy Shevchenko [this message]
2022-11-17 20:54 ` [PATCH v3 2/2] usb: dwc3: core: defer probe " Ferry Toth
2022-11-17 20:54 ` kernel test robot
2022-11-18 2:11 ` Thinh Nguyen
2022-11-18 12:29 ` Ferry Toth
2022-11-18 19:49 ` Thinh Nguyen
2022-11-18 10:32 ` [PATCH v3 0/2] " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3dfFX0P9n2lndCL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andrew.smirnov@gmail.com \
--cc=fntoth@gmail.com \
--cc=ftoth@exalondelft.nl \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liushixin2@huawei.com \
--cc=sean.anderson@seco.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.