All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: sfr@canb.auug.org.au
Cc: "José Expósito" <jose.exposito89@gmail.com>,
	dri-devel@lists.freedesktop.org
Subject: [bug report] Merge branch 'for-linux-next' of git://anongit.freedesktop.org/drm/drm-misc
Date: Fri, 18 Nov 2022 14:17:34 +0300	[thread overview]
Message-ID: <Y3dpzq5o3j/iZn4Q@kili> (raw)

Hello Stephen Rothwell,

The patch 23b727d76bda: "Merge branch 'for-linux-next' of
git://anongit.freedesktop.org/drm/drm-misc" from Nov 17, 2022, leads
to the following Smatch static checker warning:

	drivers/gpu/drm/vc4/vc4_hdmi.c:351 vc4_hdmi_reset_link()
	error: uninitialized symbol 'vc4_hdmi'.

drivers/gpu/drm/vc4/vc4_hdmi.c
    346 
    347         crtc_state = crtc->state;
    348         if (!crtc_state->active)
    349                 return 0;
    350 
--> 351         mutex_lock(&vc4_hdmi->mutex);
                           ^^^^^^^^^
This locking

    352 
    353         vc4_hdmi = connector_to_vc4_hdmi(connector);
                ^^^^^^^^^^
needs to be done after this assignment.  But this is only in linux-next
so presumably it's a temporary thing.

    354         if (!vc4_hdmi_supports_scrambling(vc4_hdmi)) {
    355                 mutex_unlock(&vc4_hdmi->mutex);
    356                 return 0;
    357         }
    358 
    359         scrambling_needed = vc4_hdmi_mode_needs_scrambling(&vc4_hdmi->saved_adjusted_mode,
    360                                                            vc4_hdmi->output_bpc,

regards,
dan carpenter

             reply	other threads:[~2022-11-18 11:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 11:17 Dan Carpenter [this message]
2022-11-19 12:21 ` [bug report] Merge branch 'for-linux-next' of git://anongit.freedesktop.org/drm/drm-misc José Expósito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3dpzq5o3j/iZn4Q@kili \
    --to=error27@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jose.exposito89@gmail.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.