From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C49C433FE for ; Fri, 18 Nov 2022 12:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235025AbiKRMwz (ORCPT ); Fri, 18 Nov 2022 07:52:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbiKRMwy (ORCPT ); Fri, 18 Nov 2022 07:52:54 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6F37A1AF09; Fri, 18 Nov 2022 04:52:51 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C0373807E; Fri, 18 Nov 2022 12:42:44 +0000 (UTC) Date: Fri, 18 Nov 2022 14:52:49 +0200 From: Tony Lindgren To: Maxim Korotkov Cc: Haojian Zhuang , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] pinctrl: single: fix potential NULL dereference Message-ID: References: <20221118104332.943-1-korotkov.maxim.s@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221118104332.943-1-korotkov.maxim.s@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org * Maxim Korotkov [221118 10:33]: > Added checking of pointer "function" in pcs_set_mux(). > pinmux_generic_get_function() can return NULL and the pointer > "function" was dereferenced without checking against NULL. Reviewed-by: Tony Lindgren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEB41C4332F for ; Fri, 18 Nov 2022 12:53:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jhbeQDXvJQaicZ73RYT2XFTEVabH/rw7m5ZoBVdQ1hk=; b=CmlU2OTqqipXmg o/bIObIfg+lN93y5P2ewr+Juh3NBQdLqt9l/dm43ipUdDEitpBGKUMKQUdJmi2l8L+sdJTtB4uNgy eF7b3J+8D4X4bZgKuccfWlNQobHEfOLX7C0zIsnE1bzh8ghOdkzYyVg4h6a6VsQxOpJ1TX/RbXOC3 ET3H/YpYNtkQC5z4q2j+WMJXMR2X2JD+od5lwlZI5lYjNJbD8eQubDrkFSw6hZUn4BnulZ/Nou8l+ ubVOVjr31cv1HOOFcVPNkLxmHyf+R3FnwEO4F7iYHlwZZoiATT3TAeByMWkHd6cHHlfW66z4AjiFR dtTRVpON519Pu3w9nTmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow0rZ-003zYI-Gv; Fri, 18 Nov 2022 12:52:57 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow0rX-003zXJ-5c for linux-arm-kernel@lists.infradead.org; Fri, 18 Nov 2022 12:52:56 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C0373807E; Fri, 18 Nov 2022 12:42:44 +0000 (UTC) Date: Fri, 18 Nov 2022 14:52:49 +0200 From: Tony Lindgren To: Maxim Korotkov Cc: Haojian Zhuang , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] pinctrl: single: fix potential NULL dereference Message-ID: References: <20221118104332.943-1-korotkov.maxim.s@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221118104332.943-1-korotkov.maxim.s@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_045255_263984_89FD7877 X-CRM114-Status: UNSURE ( 6.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Maxim Korotkov [221118 10:33]: > Added checking of pointer "function" in pcs_set_mux(). > pinmux_generic_get_function() can return NULL and the pointer > "function" was dereferenced without checking against NULL. Reviewed-by: Tony Lindgren _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel