From: Andrew Lunn <andrew@lunn.ch>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] net: davicom: dm9000: switch to using gpiod API
Date: Fri, 18 Nov 2022 18:50:54 +0100 [thread overview]
Message-ID: <Y3fF/mCUVepTfTi+@lunn.ch> (raw)
In-Reply-To: <Y3ernUQfdWMBtO9z@google.com>
> > Why is that 1 magically turned into a 0?
>
> Because gpiod uses logical states (think active/inactive), not absolute
> ones. Here we are deasserting the reset line.
This is the same question/answer you had with me. Maybe it is worth
putting this into the commit message for other patches in your series
to prevent this question/answer again and again.
Andrew
next prev parent reply other threads:[~2022-11-18 17:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 20:49 [PATCH 1/3] net: davicom: dm9000: switch to using gpiod API Dmitry Torokhov
2022-09-06 20:49 ` [PATCH 2/3] net: ks8851: " Dmitry Torokhov
2022-09-07 21:46 ` Linus Walleij
2022-09-06 20:49 ` [PATCH 3/3] net: phy: spi_ks8895: " Dmitry Torokhov
2022-09-07 21:47 ` Linus Walleij
2022-09-07 21:45 ` [PATCH 1/3] net: davicom: dm9000: " Linus Walleij
2022-09-08 12:06 ` Andrew Lunn
2022-09-15 9:58 ` Paolo Abeni
2022-09-15 10:10 ` patchwork-bot+netdevbpf
2022-11-18 15:33 ` Paul Cercueil
2022-11-18 15:58 ` Dmitry Torokhov
2022-11-18 16:26 ` Paul Cercueil
2022-11-18 16:30 ` Dmitry Torokhov
2022-11-18 17:50 ` Andrew Lunn [this message]
2022-11-18 17:55 ` Dmitry Torokhov
2022-11-21 13:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3fF/mCUVepTfTi+@lunn.ch \
--to=andrew@lunn.ch \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.