From: Joerg Roedel <joro@8bytes.org>
To: Kim Phillips <kim.phillips@amd.com>
Cc: iommu@lists.linux.dev, robin.murphy@arm.com,
suravee.suthikulpanit@amd.com, vasant.hegde@amd.com,
Mike Day <michael.day@amd.com>,
linux-acpi@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iommu/amd: Fix ill-formed ivrs_ioapic, ivrs_hpet and ivrs_acpihid options
Date: Sat, 19 Nov 2022 10:06:48 +0100 [thread overview]
Message-ID: <Y3icqMJ6Oaut6uBC@8bytes.org> (raw)
In-Reply-To: <20220919155638.391481-2-kim.phillips@amd.com>
On Mon, Sep 19, 2022 at 10:56:38AM -0500, Kim Phillips wrote:
> Currently, these options cause the following libkmod error:
>
> libkmod: ERROR ../libkmod/libkmod-config.c:489 kcmdline_parse_result: \
> Ignoring bad option on kernel command line while parsing module \
> name: 'ivrs_xxxx[XX:XX'
>
> Fix by introducing a new parameter format for these options and
> throw a warning for the deprecated format.
>
> Users are still allowed to omit the PCI Segment if zero.
>
> Adding a Link: to the reason why we're modding the syntax parsing
> in the driver and not in libkmod.
>
> Fixes: ca3bf5d47cec ("iommu/amd: Introduces ivrs_acpihid kernel parameter")
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/linux-modules/20200310082308.14318-2-lucas.demarchi@intel.com/
> Reported-by: Kim Phillips <kim.phillips@amd.com>
> Co-developed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Signed-off-by: Kim Phillips <kim.phillips@amd.com>
Applied, thanks.
next prev parent reply other threads:[~2022-11-19 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 15:56 [PATCH v2 1/2] iommu/amd: Fix ivrs_acpihid cmdline parsing code Kim Phillips
2022-09-19 15:56 ` [PATCH v2 2/2] iommu/amd: Fix ill-formed ivrs_ioapic, ivrs_hpet and ivrs_acpihid options Kim Phillips
2022-11-19 9:06 ` Joerg Roedel [this message]
2022-11-10 16:38 ` [PATCH v2 1/2] iommu/amd: Fix ivrs_acpihid cmdline parsing code Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3icqMJ6Oaut6uBC@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux.dev \
--cc=kim.phillips@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=michael.day@amd.com \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.