From: Colin Foster <colin.foster@in-advantage.com>
To: Jamie Bainbridge <jamie.bainbridge@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Subject: Kernel build failure from d9282e48c6088
Date: Sat, 19 Nov 2022 14:28:34 -0800 [thread overview]
Message-ID: <Y3lYkqBhw1eK6dth@euler> (raw)
Just a heads up, commit d9282e48c6088 ("tcp: Add listening address to
SYN flood message") breaks if CONFIG_IPV6 isn't enabled.
A simple change from an if() to a macro and I'm on my merry way. Not
sure if you want anything more than that.
In file included from ./include/asm-generic/bug.h:22,
from ./arch/arm/include/asm/bug.h:60,
from ./include/linux/bug.h:5,
from ./include/linux/mmdebug.h:5,
from ./include/linux/mm.h:6,
from net/ipv4/tcp_input.c:67:
net/ipv4/tcp_input.c: In function ‘tcp_syn_flood_action’:
./include/net/sock.h:387:37: error: ‘const struct sock_common’ has no member named ‘skc_v6_rcv_saddr’; did you mean ‘skc_rcv_saddr’?
387 | #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
| ^~~~~~~~~~~~~~~~
./include/linux/printk.h:429:19: note: in definition of macro ‘printk_index_wrap’
429 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
./include/linux/printk.h:530:2: note: in expansion of macro ‘printk’
530 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~
./include/linux/net.h:272:3: note: in expansion of macro ‘pr_info’
272 | function(__VA_ARGS__); \
| ^~~~~~~~
./include/linux/net.h:288:2: note: in expansion of macro ‘net_ratelimited_function’
288 | net_ratelimited_function(pr_info, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~~~
./include/linux/net.h:288:43: note: in expansion of macro ‘sk_v6_rcv_saddr’
288 | net_ratelimited_function(pr_info, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~
net/ipv4/tcp_input.c:6847:4: note: in expansion of macro ‘net_info_ratelimited’
6847 | net_info_ratelimited("%s: Possible SYN flooding on port [%pI6c]:%u. %s.\n",
| ^~~~~~~~~~~~~~~~~~~~
CC net/ipv4/icmp.o
make[3]: *** [scripts/Makefile.build:250: net/ipv4/tcp_input.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [scripts/Makefile.build:500: net/ipv4] Error 2
make[1]: *** [scripts/Makefile.build:500: net] Error 2
make: *** [Makefile:1992: .] Error 2
next reply other threads:[~2022-11-19 22:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 22:28 Colin Foster [this message]
2022-11-20 0:17 ` Kernel build failure from d9282e48c6088 Jamie Bainbridge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3lYkqBhw1eK6dth@euler \
--to=colin.foster@in-advantage.com \
--cc=edumazet@google.com \
--cc=jamie.bainbridge@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.