Re: [PATCH] net: dm9051: Fix missing dev_kfree_skb() in dm9051_loop_rx()

[Maciej Fijalkowski <maciej.fijalkowski@intel.com>]

On Mon, Nov 21, 2022 at 04:32:26AM +0100, Yuan Can wrote:
> The dm9051_loop_rx() returns without release skb when dm9051_stop_mrcmd()
> returns error, free the skb to avoid this leak.
> 
> Fixes: 2dc95a4d30ed ("net: Add dm9051 driver")
> Signed-off-by: Yuan Can <yuancan@huawei.com>
> ---
>  drivers/net/ethernet/davicom/dm9051.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

> 
> diff --git a/drivers/net/ethernet/davicom/dm9051.c b/drivers/net/ethernet/davicom/dm9051.c
> index a523ddda7609..de7105a84747 100644
> --- a/drivers/net/ethernet/davicom/dm9051.c
> +++ b/drivers/net/ethernet/davicom/dm9051.c
> @@ -798,8 +798,10 @@ static int dm9051_loop_rx(struct board_info *db)
>  		}
>  
>  		ret = dm9051_stop_mrcmd(db);
> -		if (ret)
> +		if (ret) {
> +			dev_kfree_skb(skb);
>  			return ret;
> +		}
>  
>  		skb->protocol = eth_type_trans(skb, db->ndev);
>  		if (db->ndev->features & NETIF_F_RXCSUM)
> -- 
> 2.17.1
>