From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF6D7C433FE for ; Mon, 21 Nov 2022 14:59:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbiKUO7F (ORCPT ); Mon, 21 Nov 2022 09:59:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232196AbiKUO5g (ORCPT ); Mon, 21 Nov 2022 09:57:36 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0BE81D14FD; Mon, 21 Nov 2022 06:48:32 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1B95D80A7; Mon, 21 Nov 2022 14:38:19 +0000 (UTC) Date: Mon, 21 Nov 2022 16:48:29 +0200 From: Tony Lindgren To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Thierry Reding , Krzysztof Kozlowski , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: References: <20221121115525.36362-1-tony@atomide.com> <20221121144000.7weeyfbbulltfxmd@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221121144000.7weeyfbbulltfxmd@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Uwe Kleine-König [221121 14:30]: > On Mon, Nov 21, 2022 at 01:55:24PM +0200, Tony Lindgren wrote: > > Let's allow node numbering in decimal format too. > > > > Simple human-readable increments/IDs are usually decimal, hex is only for > > addresses as noted by Krzysztof Kozlowski . > > > > Cc: Thierry Reding > > Cc: Uwe Kleine-König > > Suggested-by: Krzysztof Kozlowski > > Signed-off-by: Tony Lindgren > > --- > > Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml > > --- a/Documentation/devicetree/bindings/pwm/pwm.yaml > > +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml > > @@ -13,7 +13,7 @@ select: false > > > > properties: > > $nodename: > > - pattern: "^pwm(@.*|-[0-9a-f])*$" > > + pattern: "^pwm(@.*|-([0-9a-f]|1[0-5]))*$" > > I wonder why you don't make this: > > + pattern: "^pwm(@.*|-[0-9a-f]*)$" Hmm but I think this would also pass for node names like pwm-a-foo? I just used the following to look for similar examples FYI: $ find Documentation/devicetree/bindings/ -name \*.yaml | \ xargs grep pattern: | grep '1\[0-' > Is there a use case to match > > pwm-1-2-3-4-5 I don't think so. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7703AC4332F for ; Mon, 21 Nov 2022 15:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9EEykMOE4VDw2G1xvEYfHOgA3x3oiA17dBO176zinVY=; b=rNRgd5AIkQUrLA PsqlW3hbmteTe9jX3RFNE5ZmClF6td/Qk60YQ2RS6t8hpXowcTlP6NJBTFIG6XvrLAKRvfVjK4pCO FWjylxEvPAnivKLIgkVsc8qedMuBiZjT2VdVnoZWYtLSlBYiPoD8bfg7BzKeyTYMILcuI/ceoXAGb YcO0bxl84ehHQDmv/Zqi7MF+WSrvI72HE1VPRrPdEmw0SYyUrwUg/zrtc9XvF/15QEEEQyyNMa4Ij IA7V3OLFHarKcCl5QS6kI2bZgjZmwgYl1lML5xG3Mrf5UM5Z2VN+rpwP4HdmFi1jCG1rEcYW91ZQh V/HpF41iuH0b4aI5Mf7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ox8Uy-00F3PH-UI; Mon, 21 Nov 2022 15:14:17 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ox867-00EpiO-5r for linux-arm-kernel@lists.infradead.org; Mon, 21 Nov 2022 14:48:37 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1B95D80A7; Mon, 21 Nov 2022 14:38:19 +0000 (UTC) Date: Mon, 21 Nov 2022 16:48:29 +0200 From: Tony Lindgren To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Thierry Reding , Krzysztof Kozlowski , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: References: <20221121115525.36362-1-tony@atomide.com> <20221121144000.7weeyfbbulltfxmd@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221121144000.7weeyfbbulltfxmd@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_064835_299988_A29B9D4A X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiBbMjIx MTIxIDE0OjMwXToKPiBPbiBNb24sIE5vdiAyMSwgMjAyMiBhdCAwMTo1NToyNFBNICswMjAwLCBU b255IExpbmRncmVuIHdyb3RlOgo+ID4gTGV0J3MgYWxsb3cgbm9kZSBudW1iZXJpbmcgaW4gZGVj aW1hbCBmb3JtYXQgdG9vLgo+ID4gCj4gPiBTaW1wbGUgaHVtYW4tcmVhZGFibGUgaW5jcmVtZW50 cy9JRHMgYXJlIHVzdWFsbHkgZGVjaW1hbCwgaGV4IGlzIG9ubHkgZm9yCj4gPiBhZGRyZXNzZXMg YXMgbm90ZWQgYnkgS3J6eXN6dG9mIEtvemxvd3NraSA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5h cm8ub3JnPi4KPiA+IAo+ID4gQ2M6IFRoaWVycnkgUmVkaW5nIDx0aGllcnJ5LnJlZGluZ0BnbWFp bC5jb20+Cj4gPiBDYzogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRy b25peC5kZT4KPiA+IFN1Z2dlc3RlZC1ieTogS3J6eXN6dG9mIEtvemxvd3NraSA8a3J6eXN6dG9m Lmtvemxvd3NraUBsaW5hcm8ub3JnPgo+ID4gU2lnbmVkLW9mZi1ieTogVG9ueSBMaW5kZ3JlbiA8 dG9ueUBhdG9taWRlLmNvbT4KPiA+IC0tLQo+ID4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9wd20vcHdtLnlhbWwgfCAyICstCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvcHdtL3B3bS55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL3B3bS9wd20ueWFtbAo+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL3B3bS9wd20ueWFtbAo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL3B3bS9wd20ueWFtbAo+ID4gQEAgLTEzLDcgKzEzLDcgQEAgc2VsZWN0OiBm YWxzZQo+ID4gIAo+ID4gIHByb3BlcnRpZXM6Cj4gPiAgICAkbm9kZW5hbWU6Cj4gPiAtICAgIHBh dHRlcm46ICJecHdtKEAuKnwtWzAtOWEtZl0pKiQiCj4gPiArICAgIHBhdHRlcm46ICJecHdtKEAu KnwtKFswLTlhLWZdfDFbMC01XSkpKiQiCj4gCj4gSSB3b25kZXIgd2h5IHlvdSBkb24ndCBtYWtl IHRoaXM6Cj4gCj4gKyAgICBwYXR0ZXJuOiAiXnB3bShALip8LVswLTlhLWZdKikkIgoKSG1tIGJ1 dCBJIHRoaW5rIHRoaXMgd291bGQgYWxzbyBwYXNzIGZvciBub2RlIG5hbWVzIGxpa2UgcHdtLWEt Zm9vPwoKSSBqdXN0IHVzZWQgdGhlIGZvbGxvd2luZyB0byBsb29rIGZvciBzaW1pbGFyIGV4YW1w bGVzIEZZSToKCiQgZmluZCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvIC1uYW1l IFwqLnlhbWwgfCBcCgl4YXJncyBncmVwIHBhdHRlcm46IHwgZ3JlcCAnMVxbMC0nCgo+IElzIHRo ZXJlIGEgdXNlIGNhc2UgdG8gbWF0Y2gKPiAKPiAJcHdtLTEtMi0zLTQtNQoKSSBkb24ndCB0aGlu ayBzby4KClJlZ2FyZHMsCgpUb255CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=