From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Nhat Pham <nphamcs@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, minchan@kernel.org,
ngupta@vflare.org, sjenning@redhat.com, ddstreet@ieee.org,
vitaly.wool@konsulko.com
Subject: Re: [PATCH v6 6/6] zsmalloc: Implement writeback mechanism for zsmalloc
Date: Tue, 22 Nov 2022 16:19:13 +0900 [thread overview]
Message-ID: <Y3x38acHBZkWQbL7@google.com> (raw)
In-Reply-To: <Y3x109XxGY02Y7Vp@cmpxchg.org>
On (22/11/22 02:10), Johannes Weiner wrote:
> > Yes. "What if it would continue". Would it make sense to not
> > break on EAGAIN?
> >
> > while (total < pages) {
> > ret = zs_reclaim_page(pool);
> > if (ret == -EAGAIN)
> > continue;
> > if (ret < 0)
> > break;
> > total++;
> > }
> >
> > Then we don't need retry loop in zs_reclaim_page().
>
> But that's an indefinite busy-loop?
That would mean that all lru pages constantly have locked objects
and we can only make partial progress.
> I don't see what the problem with limited retrying in
> zs_reclaim_page() is. It's robust and has worked for years.
No problem with it, just asking.
next prev parent reply other threads:[~2022-11-22 7:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 0:15 [PATCH v6 0/6] Implement writeback for zsmalloc Nhat Pham
2022-11-19 0:15 ` [PATCH v6 1/6] zswap: fix writeback lock ordering " Nhat Pham
2022-11-22 1:43 ` Sergey Senozhatsky
2022-11-19 0:15 ` [PATCH v6 2/6] zpool: clean out dead code Nhat Pham
2022-11-22 1:46 ` Sergey Senozhatsky
2022-11-19 0:15 ` [PATCH v6 3/6] zsmalloc: Consolidate zs_pool's migrate_lock and size_class's locks Nhat Pham
2022-11-19 0:15 ` [PATCH v6 4/6] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Nhat Pham
2022-11-19 16:38 ` Johannes Weiner
2022-11-19 17:34 ` Minchan Kim
2022-11-22 1:52 ` Sergey Senozhatsky
2022-11-22 17:42 ` Johannes Weiner
2022-11-23 3:50 ` Sergey Senozhatsky
2022-11-23 8:02 ` Yosry Ahmed
2022-11-23 8:11 ` Yosry Ahmed
2022-11-23 16:30 ` Johannes Weiner
2022-11-24 3:29 ` Sergey Senozhatsky
2022-11-24 3:21 ` Sergey Senozhatsky
2022-11-23 3:58 ` Sergey Senozhatsky
2022-11-19 0:15 ` [PATCH v6 5/6] zsmalloc: Add zpool_ops field to zs_pool to store evict handlers Nhat Pham
2022-11-19 16:39 ` Johannes Weiner
2022-11-22 1:11 ` Sergey Senozhatsky
2022-11-19 0:15 ` [PATCH v6 6/6] zsmalloc: Implement writeback mechanism for zsmalloc Nhat Pham
2022-11-19 16:45 ` Johannes Weiner
2022-11-19 17:35 ` Minchan Kim
2022-11-22 1:40 ` Sergey Senozhatsky
2022-11-22 2:00 ` Sergey Senozhatsky
2022-11-22 2:15 ` Sergey Senozhatsky
2022-11-22 3:12 ` Johannes Weiner
2022-11-22 3:42 ` Sergey Senozhatsky
2022-11-22 6:09 ` Johannes Weiner
2022-11-22 6:35 ` Sergey Senozhatsky
2022-11-22 7:10 ` Johannes Weiner
2022-11-22 7:19 ` Sergey Senozhatsky [this message]
2022-11-22 6:37 ` Sergey Senozhatsky
2022-11-23 16:30 ` Nhat Pham
2022-11-23 17:27 ` Johannes Weiner
2022-11-23 17:18 ` Johannes Weiner
2022-11-21 19:29 ` [PATCH v6 0/6] Implement writeback " Nhat Pham
2022-11-23 19:26 ` Nhat Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3x38acHBZkWQbL7@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=nphamcs@gmail.com \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.