From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34C4EC4332F for ; Tue, 22 Nov 2022 04:44:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229515AbiKVEoA (ORCPT ); Mon, 21 Nov 2022 23:44:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbiKVEn6 (ORCPT ); Mon, 21 Nov 2022 23:43:58 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 62BE026ACA; Mon, 21 Nov 2022 20:43:57 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 0C07780A7; Tue, 22 Nov 2022 04:33:43 +0000 (UTC) Date: Tue, 22 Nov 2022 06:43:55 +0200 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Thierry Reding , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: References: <20221121115525.36362-1-tony@atomide.com> <20221121144000.7weeyfbbulltfxmd@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Krzysztof Kozlowski [221121 16:05]: > On 21/11/2022 15:48, Tony Lindgren wrote: > > * Uwe Kleine-König [221121 14:30]: > >> On Mon, Nov 21, 2022 at 01:55:24PM +0200, Tony Lindgren wrote: > >>> Let's allow node numbering in decimal format too. > >>> > >>> Simple human-readable increments/IDs are usually decimal, hex is only for > >>> addresses as noted by Krzysztof Kozlowski . > >>> > >>> Cc: Thierry Reding > >>> Cc: Uwe Kleine-König > >>> Suggested-by: Krzysztof Kozlowski > >>> Signed-off-by: Tony Lindgren > >>> --- > >>> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml > >>> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml > >>> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml > >>> @@ -13,7 +13,7 @@ select: false > >>> > >>> properties: > >>> $nodename: > >>> - pattern: "^pwm(@.*|-[0-9a-f])*$" > >>> + pattern: "^pwm(@.*|-([0-9a-f]|1[0-5]))*$" > >> > >> I wonder why you don't make this: > >> > >> + pattern: "^pwm(@.*|-[0-9a-f]*)$" > > Yes, the '*' should be within (). Sorry I guess I don't follow. So for what type of naming is the second '*' actually needed here, or is it needed at all? We only want to match the following: pwm@1234 pwm-0 ... pwm-f And now also: pwm-0 ... pwm-15 Is there yet another format I'm missing? > > Hmm but I think this would also pass for node names like pwm-a-foo? > > > > No, how? Because of the second extra '*' there :) Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BB7EC4332F for ; Tue, 22 Nov 2022 04:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qihh8L7s2Jm+vWxJDFrNVtTke3JRZQLM8emhYfxq1pg=; b=mFrDBukddt56dJ z6F0TTN4haztcmY4QhDyvi1ypY3sVEl+8OAE8AlDJTg5d45K6zepuL+AopXj8G8b9kPUhb3BLnQMY G1VmyolrpnGpcj92FhtPVPq10+Z9QyT4sWhHBOGA6aVqyEPC7ctuhNfUThrl256UGpGMpRJVJGcDr EPqFYW2usAywjg1VhPaX4Q/UMJw6xfqkE0adY8vfXPDEVLQCs0Z9VPflrluFZh5BJTTUM9R4dqHaM UsUD0eGeDmbb/yd6blk1of9mB6KJZY04/YMU0O2sDRCEDr/z51Pvo2MSmIhUORMmr6qjDDYbiqRej JFVbQZpaa+PnwXFhezmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxL8c-003qJU-MV; Tue, 22 Nov 2022 04:44:02 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxL8a-003qEw-0G for linux-arm-kernel@lists.infradead.org; Tue, 22 Nov 2022 04:44:01 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 0C07780A7; Tue, 22 Nov 2022 04:33:43 +0000 (UTC) Date: Tue, 22 Nov 2022 06:43:55 +0200 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Thierry Reding , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: References: <20221121115525.36362-1-tony@atomide.com> <20221121144000.7weeyfbbulltfxmd@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_204400_111032_534CC20E X-CRM114-Status: GOOD ( 18.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBLcnp5c3p0b2YgS296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+IFsy MjExMjEgMTY6MDVdOgo+IE9uIDIxLzExLzIwMjIgMTU6NDgsIFRvbnkgTGluZGdyZW4gd3JvdGU6 Cj4gPiAqIFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+ IFsyMjExMjEgMTQ6MzBdOgo+ID4+IE9uIE1vbiwgTm92IDIxLCAyMDIyIGF0IDAxOjU1OjI0UE0g KzAyMDAsIFRvbnkgTGluZGdyZW4gd3JvdGU6Cj4gPj4+IExldCdzIGFsbG93IG5vZGUgbnVtYmVy aW5nIGluIGRlY2ltYWwgZm9ybWF0IHRvby4KPiA+Pj4KPiA+Pj4gU2ltcGxlIGh1bWFuLXJlYWRh YmxlIGluY3JlbWVudHMvSURzIGFyZSB1c3VhbGx5IGRlY2ltYWwsIGhleCBpcyBvbmx5IGZvcgo+ ID4+PiBhZGRyZXNzZXMgYXMgbm90ZWQgYnkgS3J6eXN6dG9mIEtvemxvd3NraSA8a3J6eXN6dG9m Lmtvemxvd3NraUBsaW5hcm8ub3JnPi4KPiA+Pj4KPiA+Pj4gQ2M6IFRoaWVycnkgUmVkaW5nIDx0 aGllcnJ5LnJlZGluZ0BnbWFpbC5jb20+Cj4gPj4+IENjOiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5r bGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+ID4+PiBTdWdnZXN0ZWQtYnk6IEtyenlzenRv ZiBLb3psb3dza2kgPGtyenlzenRvZi5rb3psb3dza2lAbGluYXJvLm9yZz4KPiA+Pj4gU2lnbmVk LW9mZi1ieTogVG9ueSBMaW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNvbT4KPiA+Pj4gLS0tCj4gPj4+ ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcHdtL3B3bS55YW1sIHwgMiArLQo+ ID4+PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPj4+ Cj4gPj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcHdt L3B3bS55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3B3bS9wd20ueWFt bAo+ID4+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcHdtL3B3bS55 YW1sCj4gPj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wd20vcHdt LnlhbWwKPiA+Pj4gQEAgLTEzLDcgKzEzLDcgQEAgc2VsZWN0OiBmYWxzZQo+ID4+PiAgCj4gPj4+ ICBwcm9wZXJ0aWVzOgo+ID4+PiAgICAkbm9kZW5hbWU6Cj4gPj4+IC0gICAgcGF0dGVybjogIl5w d20oQC4qfC1bMC05YS1mXSkqJCIKPiA+Pj4gKyAgICBwYXR0ZXJuOiAiXnB3bShALip8LShbMC05 YS1mXXwxWzAtNV0pKSokIgo+ID4+Cj4gPj4gSSB3b25kZXIgd2h5IHlvdSBkb24ndCBtYWtlIHRo aXM6Cj4gPj4KPiA+PiArICAgIHBhdHRlcm46ICJecHdtKEAuKnwtWzAtOWEtZl0qKSQiCj4gCj4g WWVzLCB0aGUgJyonIHNob3VsZCBiZSB3aXRoaW4gKCkuCgpTb3JyeSBJIGd1ZXNzIEkgZG9uJ3Qg Zm9sbG93LiBTbyBmb3Igd2hhdCB0eXBlIG9mIG5hbWluZyBpcyB0aGUgc2Vjb25kICcqJwphY3R1 YWxseSBuZWVkZWQgaGVyZSwgb3IgaXMgaXQgbmVlZGVkIGF0IGFsbD8KCldlIG9ubHkgd2FudCB0 byBtYXRjaCB0aGUgZm9sbG93aW5nOgoKcHdtQDEyMzQKCnB3bS0wCi4uLgpwd20tZgoKQW5kIG5v dyBhbHNvOgoKcHdtLTAKLi4uCnB3bS0xNQoKSXMgdGhlcmUgeWV0IGFub3RoZXIgZm9ybWF0IEkn bSBtaXNzaW5nPwoKPiA+IEhtbSBidXQgSSB0aGluayB0aGlzIHdvdWxkIGFsc28gcGFzcyBmb3Ig bm9kZSBuYW1lcyBsaWtlIHB3bS1hLWZvbz8KPiA+IAo+IAo+IE5vLCBob3c/CgpCZWNhdXNlIG9m IHRoZSBzZWNvbmQgZXh0cmEgJyonIHRoZXJlIDopCgpSZWdhcmRzLAoKVG9ueQoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=