Re: [Intel-wired-lan] [PATCH] igb: Allocate MSI-X vector when testing

From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yuri Benditovich <yuri.benditovich@daynix.com>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Yan Vugenfirer <yan@daynix.com>,
	intel-wired-lan@lists.osuosl.org,
	no To-header on input <"; "@osuosl.org>,
	Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH] igb: Allocate MSI-X vector when testing
Date: Tue, 22 Nov 2022 13:15:49 +0100	[thread overview]
Message-ID: <Y3y9dbBUYi5j3Qre@boxer> (raw)
In-Reply-To: <20221122121312.57741-1-akihiko.odaki@daynix.com>

On Tue, Nov 22, 2022 at 09:13:12PM +0900, Akihiko Odaki wrote:
> Allocate MSI-X vector when testing interrupts, otherwise the tests will
> not work.

Hi,

can you say a bit more about why current code was broken? And also what is
the current result of that ethtool test?

Also this is a fix, please provide Fixes: tag and route it to net tree.

> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index e5f3e7680dc6..ff911af16a4b 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -1413,6 +1413,8 @@ static int igb_intr_test(struct igb_adapter *adapter, u64 *data)
>  			*data = 1;
>  			return -1;
>  		}
> +		wr32(E1000_IVAR_MISC, E1000_IVAR_VALID << 8);
> +		wr32(E1000_EIMS, BIT(0));
>  	} else if (adapter->flags & IGB_FLAG_HAS_MSI) {
>  		shared_int = false;
>  		if (request_irq(irq,
> -- 
> 2.38.1
> 
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan