From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F75C4332F for ; Tue, 22 Nov 2022 08:11:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232154AbiKVILR (ORCPT ); Tue, 22 Nov 2022 03:11:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231934AbiKVILQ (ORCPT ); Tue, 22 Nov 2022 03:11:16 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9CE3C3F04B; Tue, 22 Nov 2022 00:11:15 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 399978061; Tue, 22 Nov 2022 08:01:01 +0000 (UTC) Date: Tue, 22 Nov 2022 10:11:13 +0200 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Thierry Reding , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: References: <20221121115525.36362-1-tony@atomide.com> <20221121144000.7weeyfbbulltfxmd@pengutronix.de> <8c37d6a6-497c-f761-1e27-1ef5b3e64250@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8c37d6a6-497c-f761-1e27-1ef5b3e64250@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Krzysztof Kozlowski [221122 07:26]: > On 22/11/2022 05:43, Tony Lindgren wrote: > > * Krzysztof Kozlowski [221121 16:05]: > >> On 21/11/2022 15:48, Tony Lindgren wrote: > >>> * Uwe Kleine-König [221121 14:30]: > >>>> On Mon, Nov 21, 2022 at 01:55:24PM +0200, Tony Lindgren wrote: > >>>>> Let's allow node numbering in decimal format too. > >>>>> > >>>>> Simple human-readable increments/IDs are usually decimal, hex is only for > >>>>> addresses as noted by Krzysztof Kozlowski . > >>>>> > >>>>> Cc: Thierry Reding > >>>>> Cc: Uwe Kleine-König > >>>>> Suggested-by: Krzysztof Kozlowski > >>>>> Signed-off-by: Tony Lindgren > >>>>> --- > >>>>> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- > >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml > >>>>> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml > >>>>> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml > >>>>> @@ -13,7 +13,7 @@ select: false > >>>>> > >>>>> properties: > >>>>> $nodename: > >>>>> - pattern: "^pwm(@.*|-[0-9a-f])*$" > >>>>> + pattern: "^pwm(@.*|-([0-9a-f]|1[0-5]))*$" > >>>> > >>>> I wonder why you don't make this: > >>>> > >>>> + pattern: "^pwm(@.*|-[0-9a-f]*)$" > >> > >> Yes, the '*' should be within (). > > > > Sorry I guess I don't follow. So for what type of naming is the second '*' > > actually needed here, or is it needed at all? > > > > We only want to match the following: > > > > pwm@1234 > > > > pwm-0 > > ... > > pwm-f > > > > And now also: > > > > pwm-0 > > ... > > pwm-15 > > > > Is there yet another format I'm missing? > > > >>> Hmm but I think this would also pass for node names like pwm-a-foo? > >>> > >> > >> No, how? > > > > Because of the second extra '*' there :) > > It cannot multiple dashes... Sorry I'm still confused.. Care to specify what match do you want to use here and why? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7605C4332F for ; Tue, 22 Nov 2022 08:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KRjz1hGBG819RoKWgizguqXGT+DyfLvZ8r8uQz0pjF8=; b=u28ZxBgWZ6uooN /g61pZcqz7OTCBiS++ykJC8WGMrdUhn+x0vzdZJNcd2jTp5ERW99e3aF5q5dBSb52NprLuJ05LUNU j7Y8D9VrqnxRZ8PSUh4pQTeTWR+Th9hl7HitytWbs2NzIhsHww86bNVTxZUO86B9mwoblUIWkGc2V BluUku0hV1GPdzp5Pl25Rf4OMpe/M6sp4nwkz5CEVezhmcN51xvgnDwKyXGnuMXC1I8BN0uxr7AdH aRpDl9qvLKecV/RPVNjv7Gx5WfrAjzgUW0CjtY6uU0ZrNQYHIvZUZOoMiFzyH84XDkhG/OhI5GU1H fYiFUtmVpzQzYIAAlXOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxONC-0066UD-Ly; Tue, 22 Nov 2022 08:11:18 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxONA-0066TD-2D for linux-arm-kernel@lists.infradead.org; Tue, 22 Nov 2022 08:11:17 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 399978061; Tue, 22 Nov 2022 08:01:01 +0000 (UTC) Date: Tue, 22 Nov 2022 10:11:13 +0200 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Thierry Reding , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: References: <20221121115525.36362-1-tony@atomide.com> <20221121144000.7weeyfbbulltfxmd@pengutronix.de> <8c37d6a6-497c-f761-1e27-1ef5b3e64250@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8c37d6a6-497c-f761-1e27-1ef5b3e64250@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_001116_179766_4ACDAD0C X-CRM114-Status: GOOD ( 22.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBLcnp5c3p0b2YgS296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+IFsy MjExMjIgMDc6MjZdOgo+IE9uIDIyLzExLzIwMjIgMDU6NDMsIFRvbnkgTGluZGdyZW4gd3JvdGU6 Cj4gPiAqIEtyenlzenRvZiBLb3psb3dza2kgPGtyenlzenRvZi5rb3psb3dza2lAbGluYXJvLm9y Zz4gWzIyMTEyMSAxNjowNV06Cj4gPj4gT24gMjEvMTEvMjAyMiAxNTo0OCwgVG9ueSBMaW5kZ3Jl biB3cm90ZToKPiA+Pj4gKiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1 dHJvbml4LmRlPiBbMjIxMTIxIDE0OjMwXToKPiA+Pj4+IE9uIE1vbiwgTm92IDIxLCAyMDIyIGF0 IDAxOjU1OjI0UE0gKzAyMDAsIFRvbnkgTGluZGdyZW4gd3JvdGU6Cj4gPj4+Pj4gTGV0J3MgYWxs b3cgbm9kZSBudW1iZXJpbmcgaW4gZGVjaW1hbCBmb3JtYXQgdG9vLgo+ID4+Pj4+Cj4gPj4+Pj4g U2ltcGxlIGh1bWFuLXJlYWRhYmxlIGluY3JlbWVudHMvSURzIGFyZSB1c3VhbGx5IGRlY2ltYWws IGhleCBpcyBvbmx5IGZvcgo+ID4+Pj4+IGFkZHJlc3NlcyBhcyBub3RlZCBieSBLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+Lgo+ID4+Pj4+Cj4gPj4+ Pj4gQ2M6IFRoaWVycnkgUmVkaW5nIDx0aGllcnJ5LnJlZGluZ0BnbWFpbC5jb20+Cj4gPj4+Pj4g Q2M6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+Cj4g Pj4+Pj4gU3VnZ2VzdGVkLWJ5OiBLcnp5c3p0b2YgS296bG93c2tpIDxrcnp5c3p0b2Yua296bG93 c2tpQGxpbmFyby5vcmc+Cj4gPj4+Pj4gU2lnbmVkLW9mZi1ieTogVG9ueSBMaW5kZ3JlbiA8dG9u eUBhdG9taWRlLmNvbT4KPiA+Pj4+PiAtLS0KPiA+Pj4+PiAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL3B3bS9wd20ueWFtbCB8IDIgKy0KPiA+Pj4+PiAgMSBmaWxlIGNoYW5nZWQs IDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPj4+Pj4KPiA+Pj4+PiBkaWZmIC0tZ2l0 IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3B3bS9wd20ueWFtbCBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wd20vcHdtLnlhbWwKPiA+Pj4+PiAtLS0gYS9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcHdtL3B3bS55YW1sCj4gPj4+Pj4gKysr IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3B3bS9wd20ueWFtbAo+ID4+Pj4+ IEBAIC0xMyw3ICsxMyw3IEBAIHNlbGVjdDogZmFsc2UKPiA+Pj4+PiAgCj4gPj4+Pj4gIHByb3Bl cnRpZXM6Cj4gPj4+Pj4gICAgJG5vZGVuYW1lOgo+ID4+Pj4+IC0gICAgcGF0dGVybjogIl5wd20o QC4qfC1bMC05YS1mXSkqJCIKPiA+Pj4+PiArICAgIHBhdHRlcm46ICJecHdtKEAuKnwtKFswLTlh LWZdfDFbMC01XSkpKiQiCj4gPj4+Pgo+ID4+Pj4gSSB3b25kZXIgd2h5IHlvdSBkb24ndCBtYWtl IHRoaXM6Cj4gPj4+Pgo+ID4+Pj4gKyAgICBwYXR0ZXJuOiAiXnB3bShALip8LVswLTlhLWZdKikk Igo+ID4+Cj4gPj4gWWVzLCB0aGUgJyonIHNob3VsZCBiZSB3aXRoaW4gKCkuCj4gPiAKPiA+IFNv cnJ5IEkgZ3Vlc3MgSSBkb24ndCBmb2xsb3cuIFNvIGZvciB3aGF0IHR5cGUgb2YgbmFtaW5nIGlz IHRoZSBzZWNvbmQgJyonCj4gPiBhY3R1YWxseSBuZWVkZWQgaGVyZSwgb3IgaXMgaXQgbmVlZGVk IGF0IGFsbD8KPiA+IAo+ID4gV2Ugb25seSB3YW50IHRvIG1hdGNoIHRoZSBmb2xsb3dpbmc6Cj4g PiAKPiA+IHB3bUAxMjM0Cj4gPiAKPiA+IHB3bS0wCj4gPiAuLi4KPiA+IHB3bS1mCj4gPiAKPiA+ IEFuZCBub3cgYWxzbzoKPiA+IAo+ID4gcHdtLTAKPiA+IC4uLgo+ID4gcHdtLTE1Cj4gPiAKPiA+ IElzIHRoZXJlIHlldCBhbm90aGVyIGZvcm1hdCBJJ20gbWlzc2luZz8KPiA+IAo+ID4+PiBIbW0g YnV0IEkgdGhpbmsgdGhpcyB3b3VsZCBhbHNvIHBhc3MgZm9yIG5vZGUgbmFtZXMgbGlrZSBwd20t YS1mb28/Cj4gPj4+Cj4gPj4KPiA+PiBObywgaG93Pwo+ID4gCj4gPiBCZWNhdXNlIG9mIHRoZSBz ZWNvbmQgZXh0cmEgJyonIHRoZXJlIDopCj4gCj4gSXQgY2Fubm90IG11bHRpcGxlIGRhc2hlcy4u LgoKU29ycnkgSSdtIHN0aWxsIGNvbmZ1c2VkLi4gQ2FyZSB0byBzcGVjaWZ5IHdoYXQgbWF0Y2gg ZG8geW91IHdhbnQgdG8KdXNlIGhlcmUgYW5kIHdoeT8KClJlZ2FyZHMsCgpUb255CgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==