From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EB85C43217 for ; Tue, 22 Nov 2022 10:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232809AbiKVKnK (ORCPT ); Tue, 22 Nov 2022 05:43:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232378AbiKVKmk (ORCPT ); Tue, 22 Nov 2022 05:42:40 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 21A2E5FAA; Tue, 22 Nov 2022 02:37:28 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 20AEF8061; Tue, 22 Nov 2022 10:27:14 +0000 (UTC) Date: Tue, 22 Nov 2022 12:37:26 +0200 From: Tony Lindgren To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Thierry Reding , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: References: <20221121115525.36362-1-tony@atomide.com> <20221121144000.7weeyfbbulltfxmd@pengutronix.de> <20221122093650.oouke2utlkvdd7r6@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221122093650.oouke2utlkvdd7r6@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Uwe Kleine-König [221122 09:26]: > On Tue, Nov 22, 2022 at 06:43:55AM +0200, Tony Lindgren wrote: > > * Krzysztof Kozlowski [221121 16:05]: > > > On 21/11/2022 15:48, Tony Lindgren wrote: > > > > * Uwe Kleine-König [221121 14:30]: > > > >> On Mon, Nov 21, 2022 at 01:55:24PM +0200, Tony Lindgren wrote: > > > >>> Let's allow node numbering in decimal format too. > > > >>> > > > >>> Simple human-readable increments/IDs are usually decimal, hex is only for > > > >>> addresses as noted by Krzysztof Kozlowski . > > > >>> > > > >>> Cc: Thierry Reding > > > >>> Cc: Uwe Kleine-König > > > >>> Suggested-by: Krzysztof Kozlowski > > > >>> Signed-off-by: Tony Lindgren > > > >>> --- > > > >>> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- > > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > > >>> > > > >>> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml > > > >>> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml > > > >>> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml > > > >>> @@ -13,7 +13,7 @@ select: false > > > >>> > > > >>> properties: > > > >>> $nodename: > > > >>> - pattern: "^pwm(@.*|-[0-9a-f])*$" > > > >>> + pattern: "^pwm(@.*|-([0-9a-f]|1[0-5]))*$" > > > >> > > > >> I wonder why you don't make this: > > > >> > > > >> + pattern: "^pwm(@.*|-[0-9a-f]*)$" > > > > > > Yes, the '*' should be within (). > > > > Sorry I guess I don't follow. So for what type of naming is the second '*' > > actually needed here, or is it needed at all? > > > > We only want to match the following: > > > > pwm@1234 > > > > pwm-0 > > ... > > pwm-f > > > > And now also: > > > > pwm-0 > > ... > > pwm-15 > > > > Is there yet another format I'm missing? > > I think there is a misunderstanding about the type of pattern here. Do > we talk about a shell pattern where "[0-9a-f]*" matches a name starting > with a hex digit followed by any number of any caracter, or is it a > regexp where the * means "any number of the preceding pattern", so > effectively a word consisting of only hex digits. > > The .* part makes me think we're talking about a regexp, so the old > pattern ("^pwm(@.*|-[0-9a-f])*$") means that > > pwm-1-2-3-4 > > is allowed but > > pwm-10 > > isn't. And I think what we want is: > > "^pwm(@.*|-[0-9a-f]*)$" Heh so this fails for just node name pwm: pwm: $nodename:0: 'pwm' does not match '^pwm(@.*|-[0-9a-f]*)$' Maybe that's why the second '..)*$' was there originally for? And adding it back there fixes pwm but allows pwm-1-2-3.. > (or maybe better "^pwm(@.+|-[0-9a-f]+)$" ?) And this too fails for just pwm node name. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 076DAC4332F for ; Tue, 22 Nov 2022 10:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vw7LMlHmTl4qmLkNSGyiKMCImeXqHmy4JlFnwSinxmI=; b=crc9SW5ti3E76W 3/ZcQX8d5Iu/AlP/iIw2YqfpM7uAYCxdJA5elU6u37ZEaMm6i32YlHuKl1h4ZsoMwXONS9q9ODJdW VWfqGkL++Hfx9tFnrPdWLgadlk7eg9v+YrMGB0unQhPavbuiMrxBQzVdHYHNMsT5kVVcGYS4VyCcz hKTwkRtXLj8mQb8OwI/hz4wdPn0AzT7FXIP2MpNjCCVM0U6sdUMvEgT9mf23zHuC7lNM1H8DigmJk a/t9z/5A/mQkC7qQE0Dq+2pPycTADXVLj6lwgTK3o+cAKGFJnNIlKJuxgb+jImeeWuHmm2PS6wvBh +iJ85KxnJlT6yUJOWbKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxQek-007w1y-Va; Tue, 22 Nov 2022 10:37:35 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxQeh-007w0B-C0 for linux-arm-kernel@lists.infradead.org; Tue, 22 Nov 2022 10:37:32 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 20AEF8061; Tue, 22 Nov 2022 10:27:14 +0000 (UTC) Date: Tue, 22 Nov 2022 12:37:26 +0200 From: Tony Lindgren To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Thierry Reding , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: References: <20221121115525.36362-1-tony@atomide.com> <20221121144000.7weeyfbbulltfxmd@pengutronix.de> <20221122093650.oouke2utlkvdd7r6@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221122093650.oouke2utlkvdd7r6@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_023731_485502_86E14979 X-CRM114-Status: GOOD ( 29.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiBbMjIx MTIyIDA5OjI2XToKPiBPbiBUdWUsIE5vdiAyMiwgMjAyMiBhdCAwNjo0Mzo1NUFNICswMjAwLCBU b255IExpbmRncmVuIHdyb3RlOgo+ID4gKiBLcnp5c3p0b2YgS296bG93c2tpIDxrcnp5c3p0b2Yu a296bG93c2tpQGxpbmFyby5vcmc+IFsyMjExMjEgMTY6MDVdOgo+ID4gPiBPbiAyMS8xMS8yMDIy IDE1OjQ4LCBUb255IExpbmRncmVuIHdyb3RlOgo+ID4gPiA+ICogVXdlIEtsZWluZS1Lw7ZuaWcg PHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZT4gWzIyMTEyMSAxNDozMF06Cj4gPiA+ID4+ IE9uIE1vbiwgTm92IDIxLCAyMDIyIGF0IDAxOjU1OjI0UE0gKzAyMDAsIFRvbnkgTGluZGdyZW4g d3JvdGU6Cj4gPiA+ID4+PiBMZXQncyBhbGxvdyBub2RlIG51bWJlcmluZyBpbiBkZWNpbWFsIGZv cm1hdCB0b28uCj4gPiA+ID4+Pgo+ID4gPiA+Pj4gU2ltcGxlIGh1bWFuLXJlYWRhYmxlIGluY3Jl bWVudHMvSURzIGFyZSB1c3VhbGx5IGRlY2ltYWwsIGhleCBpcyBvbmx5IGZvcgo+ID4gPiA+Pj4g YWRkcmVzc2VzIGFzIG5vdGVkIGJ5IEtyenlzenRvZiBLb3psb3dza2kgPGtyenlzenRvZi5rb3ps b3dza2lAbGluYXJvLm9yZz4uCj4gPiA+ID4+Pgo+ID4gPiA+Pj4gQ2M6IFRoaWVycnkgUmVkaW5n IDx0aGllcnJ5LnJlZGluZ0BnbWFpbC5jb20+Cj4gPiA+ID4+PiBDYzogVXdlIEtsZWluZS1Lw7Zu aWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZT4KPiA+ID4gPj4+IFN1Z2dlc3RlZC1i eTogS3J6eXN6dG9mIEtvemxvd3NraSA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPgo+ ID4gPiA+Pj4gU2lnbmVkLW9mZi1ieTogVG9ueSBMaW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNvbT4K PiA+ID4gPj4+IC0tLQo+ID4gPiA+Pj4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9wd20vcHdtLnlhbWwgfCAyICstCj4gPiA+ID4+PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+ID4+Pgo+ID4gPiA+Pj4gZGlmZiAtLWdpdCBhL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wd20vcHdtLnlhbWwgYi9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcHdtL3B3bS55YW1sCj4gPiA+ID4+PiAtLS0gYS9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcHdtL3B3bS55YW1sCj4gPiA+ID4+PiArKysg Yi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcHdtL3B3bS55YW1sCj4gPiA+ID4+ PiBAQCAtMTMsNyArMTMsNyBAQCBzZWxlY3Q6IGZhbHNlCj4gPiA+ID4+PiAgCj4gPiA+ID4+PiAg cHJvcGVydGllczoKPiA+ID4gPj4+ICAgICRub2RlbmFtZToKPiA+ID4gPj4+IC0gICAgcGF0dGVy bjogIl5wd20oQC4qfC1bMC05YS1mXSkqJCIKPiA+ID4gPj4+ICsgICAgcGF0dGVybjogIl5wd20o QC4qfC0oWzAtOWEtZl18MVswLTVdKSkqJCIKPiA+ID4gPj4KPiA+ID4gPj4gSSB3b25kZXIgd2h5 IHlvdSBkb24ndCBtYWtlIHRoaXM6Cj4gPiA+ID4+Cj4gPiA+ID4+ICsgICAgcGF0dGVybjogIl5w d20oQC4qfC1bMC05YS1mXSopJCIKPiA+ID4gCj4gPiA+IFllcywgdGhlICcqJyBzaG91bGQgYmUg d2l0aGluICgpLgo+ID4gCj4gPiBTb3JyeSBJIGd1ZXNzIEkgZG9uJ3QgZm9sbG93LiBTbyBmb3Ig d2hhdCB0eXBlIG9mIG5hbWluZyBpcyB0aGUgc2Vjb25kICcqJwo+ID4gYWN0dWFsbHkgbmVlZGVk IGhlcmUsIG9yIGlzIGl0IG5lZWRlZCBhdCBhbGw/Cj4gPiAKPiA+IFdlIG9ubHkgd2FudCB0byBt YXRjaCB0aGUgZm9sbG93aW5nOgo+ID4gCj4gPiBwd21AMTIzNAo+ID4gCj4gPiBwd20tMAo+ID4g Li4uCj4gPiBwd20tZgo+ID4gCj4gPiBBbmQgbm93IGFsc286Cj4gPiAKPiA+IHB3bS0wCj4gPiAu Li4KPiA+IHB3bS0xNQo+ID4gCj4gPiBJcyB0aGVyZSB5ZXQgYW5vdGhlciBmb3JtYXQgSSdtIG1p c3Npbmc/Cj4gCj4gSSB0aGluayB0aGVyZSBpcyBhIG1pc3VuZGVyc3RhbmRpbmcgYWJvdXQgdGhl IHR5cGUgb2YgcGF0dGVybiBoZXJlLiBEbwo+IHdlIHRhbGsgYWJvdXQgYSBzaGVsbCBwYXR0ZXJu IHdoZXJlICJbMC05YS1mXSoiIG1hdGNoZXMgYSBuYW1lIHN0YXJ0aW5nCj4gd2l0aCBhIGhleCBk aWdpdCBmb2xsb3dlZCBieSBhbnkgbnVtYmVyIG9mIGFueSBjYXJhY3Rlciwgb3IgaXMgaXQgYQo+ IHJlZ2V4cCB3aGVyZSB0aGUgKiBtZWFucyAiYW55IG51bWJlciBvZiB0aGUgcHJlY2VkaW5nIHBh dHRlcm4iLCBzbwo+IGVmZmVjdGl2ZWx5IGEgd29yZCBjb25zaXN0aW5nIG9mIG9ubHkgaGV4IGRp Z2l0cy4KPiAKPiBUaGUgLiogcGFydCBtYWtlcyBtZSB0aGluayB3ZSdyZSB0YWxraW5nIGFib3V0 IGEgcmVnZXhwLCBzbyB0aGUgb2xkCj4gcGF0dGVybiAoIl5wd20oQC4qfC1bMC05YS1mXSkqJCIp IG1lYW5zIHRoYXQKPiAKPiAJcHdtLTEtMi0zLTQKPiAKPiBpcyBhbGxvd2VkIGJ1dAo+IAo+IAlw d20tMTAKPiAKPiBpc24ndC4gQW5kIEkgdGhpbmsgd2hhdCB3ZSB3YW50IGlzOgo+IAo+IAkiXnB3 bShALip8LVswLTlhLWZdKikkIgoKSGVoIHNvIHRoaXMgZmFpbHMgZm9yIGp1c3Qgbm9kZSBuYW1l IHB3bToKCnB3bTogJG5vZGVuYW1lOjA6ICdwd20nIGRvZXMgbm90IG1hdGNoICdecHdtKEAuKnwt WzAtOWEtZl0qKSQnCgpNYXliZSB0aGF0J3Mgd2h5IHRoZSBzZWNvbmQgJy4uKSokJyB3YXMgdGhl cmUgb3JpZ2luYWxseSBmb3I/CkFuZCBhZGRpbmcgaXQgYmFjayB0aGVyZSBmaXhlcyBwd20gYnV0 IGFsbG93cyBwd20tMS0yLTMuLgoKPiAob3IgbWF5YmUgYmV0dGVyICJecHdtKEAuK3wtWzAtOWEt Zl0rKSQiID8pCgpBbmQgdGhpcyB0b28gZmFpbHMgZm9yIGp1c3QgcHdtIG5vZGUgbmFtZS4KClJl Z2FyZHMsCgpUb255CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==